Re: [lng-odp] [PATCH v2] linux-gen: build: de-couple abi compatibility from shared lib

2016-10-13 Thread Mike Holmes
On 13 October 2016 at 12:39, Maxim Uvarov wrote: > On 10/13/16 19:33, Mike Holmes wrote: > >> Anders comments have not been addressed on the list, are they resloved ? >> >> > In current patch set - no. Because it's subject for separate patch. But we > need resolve version name before tagging. >

Re: [lng-odp] [PATCH v2] linux-gen: build: de-couple abi compatibility from shared lib

2016-10-13 Thread Maxim Uvarov
On 10/13/16 19:33, Mike Holmes wrote: Anders comments have not been addressed on the list, are they resloved ? In current patch set - no. Because it's subject for separate patch. But we need resolve version name before tagging. Maxim. On 13 October 2016 at 11:40, Maxim Uvarov

Re: [lng-odp] [PATCH v2] linux-gen: build: de-couple abi compatibility from shared lib

2016-10-13 Thread Mike Holmes
Anders comments have not been addressed on the list, are they resloved ? On 13 October 2016 at 11:40, Maxim Uvarov wrote: > Merged, > > we also need this option to be tested in CI. > > Maxim. > > > On 10/12/16 18:21, Bill Fischofer wrote: > >> This version resolves the issue with running from an

Re: [lng-odp] [PATCH v2] linux-gen: build: de-couple abi compatibility from shared lib

2016-10-13 Thread Maxim Uvarov
Merged, we also need this option to be tested in CI. Maxim. On 10/12/16 18:21, Bill Fischofer wrote: This version resolves the issue with running from an installed copy of ODP. On Thu, Sep 29, 2016 at 6:46 PM, Petri Savolainen < petri.savolai...@nokia.com> wrote: Building ABI compatible or

Re: [lng-odp] [PATCH v2] linux-gen: build: de-couple abi compatibility from shared lib

2016-10-12 Thread Bill Fischofer
This version resolves the issue with running from an installed copy of ODP. On Thu, Sep 29, 2016 at 6:46 PM, Petri Savolainen < petri.savolai...@nokia.com> wrote: > Building ABI compatible or shared library are two different > targets. A shared library may be used also without ABI > compatibility

Re: [lng-odp] [PATCH v2] linux-gen: build: de-couple abi compatibility from shared lib

2016-10-03 Thread Savolainen, Petri (Nokia - FI/Espoo)
> ## > > +# Enable/disable ABI compatible build > > > +# > # > > +ODP_ABI_COMPAT=1 > > +abi_compat=yes > > +AC_ARG_ENABLE([abi-compat], > > +[ --enab

Re: [lng-odp] [PATCH v2] linux-gen: build: de-couple abi compatibility from shared lib

2016-09-29 Thread Anders Roxell
On 30 September 2016 at 01:46, Petri Savolainen wrote: > Building ABI compatible or shared library are two different > targets. A shared library may be used also without ABI > compatibility. A new --enable-abi-compat configuration option > is introduced. By default libraries are not built in ABI c

[lng-odp] [PATCH v2] linux-gen: build: de-couple abi compatibility from shared lib

2016-09-29 Thread Petri Savolainen
Building ABI compatible or shared library are two different targets. A shared library may be used also without ABI compatibility. A new --enable-abi-compat configuration option is introduced. By default libraries are not built in ABI compat mode to enable function inlining. There is a noticeable pe

Re: [lng-odp] [PATCH v2] linux-gen: build: de-couple abi compatibility from shared lib

2016-09-22 Thread Bill Fischofer
I've posted patch http://patches.opendataplane.org/patch/6993/ that performs the same function as this patch but does so by using the autoconf structure of the base code which means that it works either directly from the ODP repo or from an installed copy of the library. On Thu, Sep 22, 2016 at 5:

Re: [lng-odp] [PATCH v2] linux-gen: build: de-couple abi compatibility from shared lib

2016-09-22 Thread Bill Fischofer
Actually, I have to withdraw my previous review of this patch. The problem is that the original works as part of autoconf to create the plat/inlines.h file from an inlines.h.in base while this one attempts to do this by specifying CFLAGs that #define ODP_ABI_COMPAT. That works fine if you're compi

Re: [lng-odp] [PATCH v2] linux-gen: build: de-couple abi compatibility from shared lib

2016-09-21 Thread Savolainen, Petri (Nokia - FI/Espoo)
p-boun...@lists.linaro.org] On Behalf Of Petri > Savolainen > Sent: Wednesday, September 14, 2016 3:11 PM > To: lng-odp@lists.linaro.org > Subject: Suspected SPAM - [lng-odp] [PATCH v2] linux-gen: build: de-couple > abi compatibility from shared lib > > Building ABI compatible or shared library

Re: [lng-odp] [PATCH v2] linux-gen: build: de-couple abi compatibility from shared lib

2016-09-19 Thread Mike Holmes
mber 14, 2016 3:11 PM > > > To: lng-odp@lists.linaro.org > > > Subject: Suspected SPAM - [lng-odp] [PATCH v2] linux-gen: build: > > de-couple > > > abi compatibility from shared lib > > > > > > Building ABI compatible or shared library are two dif

Re: [lng-odp] [PATCH v2] linux-gen: build: de-couple abi compatibility from shared lib

2016-09-19 Thread Bill Fischofer
Original Message- > > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of > Petri > > Savolainen > > Sent: Wednesday, September 14, 2016 3:11 PM > > To: lng-odp@lists.linaro.org > > Subject: Suspected SPAM - [lng-odp] [PATCH v2] linu

Re: [lng-odp] [PATCH v2] linux-gen: build: de-couple abi compatibility from shared lib

2016-09-19 Thread Savolainen, Petri (Nokia - FI/Espoo)
Subject: Suspected SPAM - [lng-odp] [PATCH v2] linux-gen: build: de-couple > abi compatibility from shared lib > > Building ABI compatible or shared library are two different > targets. A shared library may be used also without ABI > compatibility. A new --enable-abi-compat configu

[lng-odp] [PATCH v2] linux-gen: build: de-couple abi compatibility from shared lib

2016-09-14 Thread Petri Savolainen
Building ABI compatible or shared library are two different targets. A shared library may be used also without ABI compatibility. A new --enable-abi-compat configuration option is introduced. By default libraries are not built in ABI compat mode to enable function inlining. There is a noticeable pe