Re: [lng-odp] [PATCH v2] linux-generic: crypto: properly handle errors in packet copy

2017-04-24 Thread Peltonen, Janne (Nokia - FI/Espoo)
Hi, > > There is connected interesting question, which should be though wrt. all > 'packet-consuming' functions. Should such functions always consume and > free incoming packet? IOW: > > - odp_crypto_operation() returned -1. Should the app free inbound > packet afterwards? The API spec is not

Re: [lng-odp] [PATCH v2] linux-generic: crypto: properly handle errors in packet copy

2017-04-22 Thread Dmitry Eremin-Solenikov
On 20.04.2017 23:25, Maxim Uvarov wrote: > On 04/20/17 19:12, Bill Fischofer wrote: >> On Mon, Mar 13, 2017 at 6:44 AM, Dmitry Eremin-Solenikov < >> dmitry.ereminsoleni...@linaro.org> wrote: >> >>> Add proper handling for errors returned by odp_packet_copy_from_pkt(). >>> >>> Signed-off-by: Dmitry

Re: [lng-odp] [PATCH v2] linux-generic: crypto: properly handle errors in packet copy

2017-04-20 Thread Maxim Uvarov
On 04/20/17 19:12, Bill Fischofer wrote: > On Mon, Mar 13, 2017 at 6:44 AM, Dmitry Eremin-Solenikov < > dmitry.ereminsoleni...@linaro.org> wrote: > >> Add proper handling for errors returned by odp_packet_copy_from_pkt(). >> >> Signed-off-by: Dmitry Eremin-Solenikov

Re: [lng-odp] [PATCH v2] linux-generic: crypto: properly handle errors in packet copy

2017-04-20 Thread Bill Fischofer
On Mon, Mar 13, 2017 at 6:44 AM, Dmitry Eremin-Solenikov < dmitry.ereminsoleni...@linaro.org> wrote: > Add proper handling for errors returned by odp_packet_copy_from_pkt(). > > Signed-off-by: Dmitry Eremin-Solenikov > Reviewed-by: Bill Fischofer

Re: [lng-odp] [PATCH v2] linux-generic: crypto: properly handle errors in packet copy

2017-04-02 Thread Dmitry Eremin-Solenikov
On 13 March 2017 at 14:44, Dmitry Eremin-Solenikov wrote: > Add proper handling for errors returned by odp_packet_copy_from_pkt(). > > Signed-off-by: Dmitry Eremin-Solenikov > --- > platform/linux-generic/odp_crypto.c | 8

[lng-odp] [PATCH v2] linux-generic: crypto: properly handle errors in packet copy

2017-03-13 Thread Dmitry Eremin-Solenikov
Add proper handling for errors returned by odp_packet_copy_from_pkt(). Signed-off-by: Dmitry Eremin-Solenikov --- platform/linux-generic/odp_crypto.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/platform/linux-generic/odp_crypto.c