Re: [lng-odp] [PATCH v2 5/5] performance: odp_pktio_perf: fix potential overflow for burst_gap

2015-09-17 Thread Ivan Khoronzhuk
, Petri (Nokia - FI/Espoo); lng-odp@lists.linaro.org Subject: Re: [lng-odp] [PATCH v2 5/5] performance: odp_pktio_perf: fix potential overflow for burst_gap Petri, On 15.09.15 16:01, Ivan Khoronzhuk wrote: On 15.09.15 15:54, Ivan Khoronzhuk wrote: On 15.09.15 15:45, Savolainen, Petri (Nokia

Re: [lng-odp] [PATCH v2 5/5] performance: odp_pktio_perf: fix potential overflow for burst_gap

2015-09-16 Thread Savolainen, Petri (Nokia - FI/Espoo)
ptember 15, 2015 5:07 PM > >> To: Savolainen, Petri (Nokia - FI/Espoo); lng-odp@lists.linaro.org > >> Subject: Re: [lng-odp] [PATCH v2 5/5] performance: odp_pktio_perf: > fix > >> potential overflow for burst_gap > >> > >> Petri, > >> >

Re: [lng-odp] [PATCH v2 5/5] performance: odp_pktio_perf: fix potential overflow for burst_gap

2015-09-16 Thread Ivan Khoronzhuk
[mailto:ivan.khoronz...@linaro.org] Sent: Tuesday, September 15, 2015 3:08 PM To: Savolainen, Petri (Nokia - FI/Espoo); lng-odp@lists.linaro.org Subject: Re: [lng-odp] [PATCH v2 5/5] performance: odp_pktio_perf: fix potential overflow for burst_gap On 15.09.15 14:42, Savolainen, Petri (Nokia

Re: [lng-odp] [PATCH v2 5/5] performance: odp_pktio_perf: fix potential overflow for burst_gap

2015-09-16 Thread Ivan Khoronzhuk
@lists.linaro.org Subject: Re: [lng-odp] [PATCH v2 5/5] performance: odp_pktio_perf: fix potential overflow for burst_gap Petri, On 15.09.15 16:01, Ivan Khoronzhuk wrote: On 15.09.15 15:54, Ivan Khoronzhuk wrote: On 15.09.15 15:45, Savolainen, Petri (Nokia - FI/Espoo) wrote: -Original

Re: [lng-odp] [PATCH v2 5/5] performance: odp_pktio_perf: fix potential overflow for burst_gap

2015-09-16 Thread Ivan Khoronzhuk
[mailto:ivan.khoronz...@linaro.org] Sent: Tuesday, September 15, 2015 3:08 PM To: Savolainen, Petri (Nokia - FI/Espoo); lng-odp@lists.linaro.org Subject: Re: [lng-odp] [PATCH v2 5/5] performance: odp_pktio_perf: fix potential overflow for burst_gap On 15.09.15 14:42, Savolainen, Petri (Nokia - FI

Re: [lng-odp] [PATCH v2 5/5] performance: odp_pktio_perf: fix potential overflow for burst_gap

2015-09-16 Thread Savolainen, Petri (Nokia - FI/Espoo)
; >>> > >>> > >>>> -Original Message- > >>>> From: EXT Ivan Khoronzhuk [mailto:ivan.khoronz...@linaro.org] > >>>> Sent: Tuesday, September 15, 2015 3:08 PM > >>>> To: Savolainen, Petri (Nokia - FI/Espoo); lng-odp@lists.li

Re: [lng-odp] [PATCH v2 5/5] performance: odp_pktio_perf: fix potential overflow for burst_gap

2015-09-15 Thread Ivan Khoronzhuk
To: Savolainen, Petri (Nokia - FI/Espoo); lng-odp@lists.linaro.org Subject: Re: [lng-odp] [PATCH v2 5/5] performance: odp_pktio_perf: fix potential overflow for burst_gap On 15.09.15 14:42, Savolainen, Petri (Nokia - FI/Espoo) wrote: -Original Message- From: lng-odp [mailto:lng-odp

Re: [lng-odp] [PATCH v2 5/5] performance: odp_pktio_perf: fix potential overflow for burst_gap

2015-09-15 Thread Ivan Khoronzhuk
@lists.linaro.org Subject: Re: [lng-odp] [PATCH v2 5/5] performance: odp_pktio_perf: fix potential overflow for burst_gap On 15.09.15 14:42, Savolainen, Petri (Nokia - FI/Espoo) wrote: -Original Message- From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of EXT Ivan

Re: [lng-odp] [PATCH v2 5/5] performance: odp_pktio_perf: fix potential overflow for burst_gap

2015-09-15 Thread Ivan Khoronzhuk
To: lng-odp@lists.linaro.org Subject: [lng-odp] [PATCH v2 5/5] performance: odp_pktio_perf: fix potential overflow for burst_gap The direct comparing of "cur_cycles" and "next_tx_cycles" is not valid, as "next_tx_cycles" can be overflowed and comparison

Re: [lng-odp] [PATCH v2 5/5] performance: odp_pktio_perf: fix potential overflow for burst_gap

2015-09-15 Thread Savolainen, Petri (Nokia - FI/Espoo)
onzhuk > >> Sent: Friday, September 11, 2015 1:05 PM > >> To: lng-odp@lists.linaro.org > >> Subject: [lng-odp] [PATCH v2 5/5] performance: odp_pktio_perf: fix > >> potential overflow for burst_gap > >> > >> The direct comparing of "cur_cycles&q

Re: [lng-odp] [PATCH v2 5/5] performance: odp_pktio_perf: fix potential overflow for burst_gap

2015-09-15 Thread Ivan Khoronzhuk
] performance: odp_pktio_perf: fix potential overflow for burst_gap The direct comparing of "cur_cycles" and "next_tx_cycles" is not valid, as "next_tx_cycles" can be overflowed and comparison will give wrong result. So use odp_time_diff_cycles() for that, as it takes in accou

Re: [lng-odp] [PATCH v2 5/5] performance: odp_pktio_perf: fix potential overflow for burst_gap

2015-09-15 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of > EXT Ivan Khoronzhuk > Sent: Friday, September 11, 2015 1:05 PM > To: lng-odp@lists.linaro.org > Subject: [lng-odp] [PATCH v2 5/5] performance: odp_pktio_perf: fix > p

[lng-odp] [PATCH v2 5/5] performance: odp_pktio_perf: fix potential overflow for burst_gap

2015-09-11 Thread Ivan Khoronzhuk
The direct comparing of "cur_cycles" and "next_tx_cycles" is not valid, as "next_tx_cycles" can be overflowed and comparison will give wrong result. So use odp_time_diff_cycles() for that, as it takes in account ticks overflow. Signed-off-by: Ivan Khoronzhuk --- test/performance/odp_pktio_perf.c