[lng-odp] [PATCHv2] linux-generic: check return codes in odp_pktio_term_global

2015-11-05 Thread Maxim Uvarov
According to API odp_pktio_close() can be called only for stopped pktio. So in odp_pktio_term_global try to stop it first then call close. Also check all returns codes. https://bugs.linaro.org/show_bug.cgi?id=1854 Signed-off-by: Maxim Uvarov --- v2: lock pktio for stop and close in odp_pktio_ter

Re: [lng-odp] [PATCHv2] linux-generic: check return codes in odp_pktio_term_global

2015-11-06 Thread Nicolas Morey-Chaisemartin
Reviewed-by: Nicolas Morey-Chaisemartin On 11/05/2015 04:58 PM, Maxim Uvarov wrote: > According to API odp_pktio_close() can be called only for stopped > pktio. So in odp_pktio_term_global try to stop it first then > call close. Also check all returns codes. > https://bugs.linaro.org/show_bug.cgi

Re: [lng-odp] [PATCHv2] linux-generic: check return codes in odp_pktio_term_global

2015-11-06 Thread Nicolas Morey-Chaisemartin
On a side note, what is the expected behavior when stopping a stopped interface or starting a started one? On 11/05/2015 04:58 PM, Maxim Uvarov wrote: > According to API odp_pktio_close() can be called only for stopped > pktio. So in odp_pktio_term_global try to stop it first then > call close. A

Re: [lng-odp] [PATCHv2] linux-generic: check return codes in odp_pktio_term_global

2015-11-06 Thread Maxim Uvarov
On 11/06/2015 11:45, Nicolas Morey-Chaisemartin wrote: On a side note, what is the expected behavior when stopping a stopped interface or starting a started one? Current api does not say anything about it except first sentence. I think we should prevent double stop and double start and refin

Re: [lng-odp] [PATCHv2] linux-generic: check return codes in odp_pktio_term_global

2015-11-06 Thread Nicolas Morey-Chaisemartin
Ok. I have a patch series added check like for things like start when started, send when pktio is RONLY or config changes when pktio is started. As soon as your patch go through, I'll rebase and post. On 11/06/2015 09:51 AM, Maxim Uvarov wrote: > On 11/06/2015 11:45, Nicolas Morey-Chaisemartin wr

Re: [lng-odp] [PATCHv2] linux-generic: check return codes in odp_pktio_term_global

2015-11-09 Thread Maxim Uvarov
Merged, Maxim. On 11/06/2015 11:44, Nicolas Morey-Chaisemartin wrote: Reviewed-by: Nicolas Morey-Chaisemartin On 11/05/2015 04:58 PM, Maxim Uvarov wrote: According to API odp_pktio_close() can be called only for stopped pktio. So in odp_pktio_term_global try to stop it first then call close.