Re: [lng-odp] [PATCHv2 1/2] doc: userguide: add timer/timeout state diagram

2016-05-13 Thread Bill Fischofer
On Fri, May 13, 2016 at 4:50 AM, Christophe Milard < christophe.mil...@linaro.org> wrote: > > > On 12 May 2016 at 19:44, Bill Fischofer wrote: > >> >> >> On Thu, May 12, 2016 at 8:24 AM, Christophe Milard < >> christophe.mil...@linaro.org> wrote: >> >>> Hi Bill, >>> Just sent you a v4 containing

Re: [lng-odp] [PATCHv2 1/2] doc: userguide: add timer/timeout state diagram

2016-05-13 Thread Christophe Milard
On 12 May 2016 at 19:44, Bill Fischofer wrote: > > > On Thu, May 12, 2016 at 8:24 AM, Christophe Milard < > christophe.mil...@linaro.org> wrote: > >> Hi Bill, >> Just sent you a v4 containing my proposal regarding the FSMs and the text >> around it. >> I still have a few comments: >> >> First, yo

Re: [lng-odp] [PATCHv2 1/2] doc: userguide: add timer/timeout state diagram

2016-05-12 Thread Bill Fischofer
On Thu, May 12, 2016 at 8:24 AM, Christophe Milard < christophe.mil...@linaro.org> wrote: > Hi Bill, > Just sent you a v4 containing my proposal regarding the FSMs and the text > around it. > I still have a few comments: > > First, your FSM mixed events and actions on the transition arrow. I could

Re: [lng-odp] [PATCHv2 1/2] doc: userguide: add timer/timeout state diagram

2016-05-12 Thread Bill Fischofer
This looks good. I've sent a v5 that slightly reformats the images to make them consistent, but I'm happy with the two diagrams if that looks better to you. And I've now just read your other comments. Let me look and see if a v6 is needed to address them :) On Thu, May 12, 2016 at 8:24 AM, Chri

Re: [lng-odp] [PATCHv2 1/2] doc: userguide: add timer/timeout state diagram

2016-05-12 Thread Christophe Milard
Hi Bill, Just sent you a v4 containing my proposal regarding the FSMs and the text around it. I still have a few comments: First, your FSM mixed events and actions on the transition arrow. I could not get graphviz to have 2 colors on the same transition (one for events, one for actions), so I have

Re: [lng-odp] [PATCHv2 1/2] doc: userguide: add timer/timeout state diagram

2016-05-12 Thread Bill Fischofer
The green is for Timer related transitions while the blue is for Timeout related transitions. This format also seemed to get rid of some of the annoying line crossings. The red arrows are the transitions that relate to timer expiration and resulting timeout event scheduling, neither of which involv

Re: [lng-odp] [PATCHv2 1/2] doc: userguide: add timer/timeout state diagram

2016-05-12 Thread Christophe Milard
Hi, I am still confused with this shared FSM for the 2 distinct objects: The red seems to be actions associated with the transitions (and the timer expiration event is no longer shown on the transition showing the actions). I am not sure what the distinction between the green and blue events are.

Re: [lng-odp] [PATCHv2 1/2] doc: userguide: add timer/timeout state diagram

2016-05-10 Thread Bill Fischofer
I looked at them and I liked the added color so reworked my diagram adding that and posted a v3 for it. I'm not sure trying to separate into two diagrams really helps but perhaps this reworked diagram is easier to follow? On Tue, May 10, 2016 at 3:45 AM, Christophe Milard < christophe.mil...@linar

Re: [lng-odp] [PATCHv2 1/2] doc: userguide: add timer/timeout state diagram

2016-05-10 Thread Christophe Milard
Hi Bill, Just sent you an RFC with 2 FSMs. Had to fight a bit with graphviz. Not finished yet. I will continue working on it if you think that makes sense... Christophe. On 9 May 2016 at 17:15, Bill Fischofer wrote: > As we discussed in our call, we can both play around with graphviz and see >

Re: [lng-odp] [PATCHv2 1/2] doc: userguide: add timer/timeout state diagram

2016-05-09 Thread Bill Fischofer
As we discussed in our call, we can both play around with graphviz and see if a prettier diagram can be constructed that is perhaps clearer, possibly with two separate FSMs. On Mon, May 9, 2016 at 9:39 AM, Christophe Milard < christophe.mil...@linaro.org> wrote: > > > On 9 May 2016 at 16:28, Bill

Re: [lng-odp] [PATCHv2 1/2] doc: userguide: add timer/timeout state diagram

2016-05-09 Thread Christophe Milard
On 9 May 2016 at 16:28, Bill Fischofer wrote: > > > On Mon, May 9, 2016 at 7:58 AM, Christophe Milard < > christophe.mil...@linaro.org> wrote: > >> I am a bit confused by this diagram: It feels to me that timers and >> timeout have separate lives (even , if of course some dependency exist). >> Fr

Re: [lng-odp] [PATCHv2 1/2] doc: userguide: add timer/timeout state diagram

2016-05-09 Thread Bill Fischofer
On Mon, May 9, 2016 at 7:58 AM, Christophe Milard < christophe.mil...@linaro.org> wrote: > I am a bit confused by this diagram: It feels to me that timers and > timeout have separate lives (even , if of course some dependency exist). > From this diagram, it feels like these 2 separate objects (tim

Re: [lng-odp] [PATCHv2 1/2] doc: userguide: add timer/timeout state diagram

2016-05-09 Thread Christophe Milard
I am a bit confused by this diagram: It feels to me that timers and timeout have separate lives (even , if of course some dependency exist). >From this diagram, it feels like these 2 separate objects (timers and time out events) share states...? do they? In my head, and from the understanding I had

[lng-odp] [PATCHv2 1/2] doc: userguide: add timer/timeout state diagram

2016-05-07 Thread Bill Fischofer
Signed-off-by: Bill Fischofer --- doc/images/.gitignore | 1 + doc/images/timer_fsm.gv | 38 ++ doc/users-guide/Makefile.am | 1 + 3 files changed, 40 insertions(+) create mode 100644 doc/images/timer_fsm.gv diff --git a/doc/images/.gitignore b/do