Definitely larger than the previous version but would something like this
satisfy everyone?
For people not supporting segmented packet and/or segmented jumbo, it should be
fairly easy to get back to the old behavior.
If everyone is happy with this, I'm resubmitting the whole series.
Nicolas
--
On 07/06/15 12:31, Nicolas Morey-Chaisemartin wrote:
On 07/03/2015 04:54 PM, Maxim Uvarov wrote:
On 07/03/15 16:08, Nicolas Morey-Chaisemartin wrote:
In the end, how would you want me to test the support of segmented packets?
because we can not destroy pool (on some platfroms it's leaked).
On 07/03/2015 04:54 PM, Maxim Uvarov wrote:
> On 07/03/15 16:08, Nicolas Morey-Chaisemartin wrote:
>> In the end, how would you want me to test the support of segmented packets?
>>
> because we can not destroy pool (on some platfroms it's leaked). Then the
> only option is to create separate s
On 07/03/15 16:08, Nicolas Morey-Chaisemartin wrote:
In the end, how would you want me to test the support of segmented
packets?
because we can not destroy pool (on some platfroms it's leaked). Then
the only option is to create separate segmented pool in additional
to pkt_pool_default. So
In the end, how would you want me to test the support of segmented packets?
On 07/02/2015 06:57 PM, Bill Fischofer wrote:
> If the requested seg_len exceeds ODP_CONFIG_PACKET_SEG_LEN_MAX the
> odp_pool_create() call will fail, so applications need to be mindful that
> implementations may have m
If the requested seg_len exceeds ODP_CONFIG_PACKET_SEG_LEN_MAX the
odp_pool_create() call will fail, so applications need to be mindful that
implementations may have maximum segment size limits, so requesting large
segment sizes that aren't actually needed is not a good idea.
If an application doe
Also, Since seg_len gives information to the implementation as to how many
bytes are required to be contiguous on the first segment for faster access.
I would like to have the value of seg_len as something in the lines of 256
or 512 bytes rather than 3K or 9K.
Regards,
Bala
On 2 July 2015 at 02:3
The ODP API does not mandate that an implementation uses segments, only
that applications can discover and work with any segments that may be
present.
So it is not possible to force an implementation to use segments since, as
Stuart points out, seg_len is simply an application minimum value that
i
On Wed, Jul 01, 2015 at 01:00:07PM +0530, Bala Manoharan wrote:
> If the idea of this patch is to test segmented packets it can be
> accomplished by allocating packets of size greater than "seg_len" in an
> additional test case rather than modifying the segment length in pool
> create function.
>
If the idea of this patch is to test segmented packets it can be
accomplished by allocating packets of size greater than "seg_len" in an
additional test case rather than modifying the segment length in pool
create function.
Regards,
Bala
On 30 June 2015 at 22:26, Stuart Haslam wrote:
> On Tue,
On Tue, Jun 30, 2015 at 06:31:41PM +0300, Maxim Uvarov wrote:
> On 06/30/15 17:45, Stuart Haslam wrote:
> >On Tue, Jun 30, 2015 at 03:33:53PM +0200, Nicolas Morey-Chaisemartin wrote:
> >>Signed-off-by: Nicolas Morey-Chaisemartin
> >Reviewed-by: Stuart Haslam
> >
> >However this will cause test fa
On 06/30/15 17:45, Stuart Haslam wrote:
On Tue, Jun 30, 2015 at 03:33:53PM +0200, Nicolas Morey-Chaisemartin wrote:
Signed-off-by: Nicolas Morey-Chaisemartin
Reviewed-by: Stuart Haslam
However this will cause test failures due to bug #1661, so the fix for
that should be merged first.
---
On Tue, Jun 30, 2015 at 03:33:53PM +0200, Nicolas Morey-Chaisemartin wrote:
> Signed-off-by: Nicolas Morey-Chaisemartin
Reviewed-by: Stuart Haslam
However this will cause test failures due to bug #1661, so the fix for
that should be merged first.
> ---
> test/validation/pktio/pktio.c | 4 ++--
Signed-off-by: Nicolas Morey-Chaisemartin
---
test/validation/pktio/pktio.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/test/validation/pktio/pktio.c b/test/validation/pktio/pktio.c
index 82ced5c..b87586a 100644
--- a/test/validation/pktio/pktio.c
+++ b/test/validation
14 matches
Mail list logo
