Re: [lng-odp] [PATCHv3 0/4] Restructuring tests for clarity and new interfaces.

2016-07-21 Thread Maxim Uvarov
Merged to master and api-next then. It looks like at least some clean up patches should be suitable for monarch also. Maxim. On 07/15/16 06:46, Christophe Milard wrote: Cannot see them here when doing normal builds. you must be more accurate on what you do. Moreover, these warnings seems to

Re: [lng-odp] [PATCHv3 0/4] Restructuring tests for clarity and new interfaces.

2016-07-15 Thread Maxim Uvarov
On 07/15/16 11:13, Anders Roxell wrote: On 2016-07-15 05:46, Christophe Milard wrote: Cannot see them here when doing normal builds. you must be more accurate on what you do. Moreover, these warnings seems to relate to helper tests, which this serie doesn't touch. confused. Don't be confused...

Re: [lng-odp] [PATCHv3 0/4] Restructuring tests for clarity and new interfaces.

2016-07-15 Thread Anders Roxell
On 2016-07-15 05:46, Christophe Milard wrote: > Cannot see them here when doing normal builds. you must be more > accurate on what you do. Moreover, these warnings seems to relate to > helper tests, which this serie doesn't touch. > confused. Don't be confused... Maxim commented on the wrong patch

Re: [lng-odp] [PATCHv3 0/4] Restructuring tests for clarity and new interfaces.

2016-07-14 Thread Christophe Milard
Cannot see them here when doing normal builds. you must be more accurate on what you do. Moreover, these warnings seems to relate to helper tests, which this serie doesn't touch. confused. /C On 15 July 2016 at 05:21, Christophe Milard wrote: > Hi Maxim, > Warning when doing what? > > On 14 July

Re: [lng-odp] [PATCHv3 0/4] Restructuring tests for clarity and new interfaces.

2016-07-14 Thread Christophe Milard
Hi Maxim, Warning when doing what? On 14 July 2016 at 22:31, Maxim Uvarov wrote: > I see that warnings: > > helper/test/Makefile.am:27: warning: variable 'dist_chksum_SOURCES' is > defined but no program or > helper/test/Makefile.am:27: library has 'chksum' as canonical name (possible > typo) > h

Re: [lng-odp] [PATCHv3 0/4] Restructuring tests for clarity and new interfaces.

2016-07-14 Thread Maxim Uvarov
I see that warnings: helper/test/Makefile.am:27: warning: variable 'dist_chksum_SOURCES' is defined but no program or helper/test/Makefile.am:27: library has 'chksum' as canonical name (possible typo) helper/test/Makefile.am:28: warning: variable 'dist_odpthreads_SOURCES' is defined but no pro

Re: [lng-odp] [PATCHv3 0/4] Restructuring tests for clarity and new interfaces.

2016-07-14 Thread Mike Holmes
For this series: Reviewd-by: Mike Holmes On 14 July 2016 at 01:18, Yi He wrote: > For this series: > > Reviewed-and-tested-by: Yi He > > Best Regards, Yi > > On 14 July 2016 at 03:52, Bill Fischofer > wrote: > >> For this series: >> >> Reviewed-by: Bill Fischofer >> >> On Wed, Jul 13, 2016

Re: [lng-odp] [PATCHv3 0/4] Restructuring tests for clarity and new interfaces.

2016-07-13 Thread Yi He
For this series: Reviewed-and-tested-by: Yi He Best Regards, Yi On 14 July 2016 at 03:52, Bill Fischofer wrote: > For this series: > > Reviewed-by: Bill Fischofer > > On Wed, Jul 13, 2016 at 2:50 PM, Christophe Milard < > christophe.mil...@linaro.org> wrote: > >> since V2: >> -typo fix in i

Re: [lng-odp] [PATCHv3 0/4] Restructuring tests for clarity and new interfaces.

2016-07-13 Thread Bill Fischofer
For this series: Reviewed-by: Bill Fischofer On Wed, Jul 13, 2016 at 2:50 PM, Christophe Milard < christophe.mil...@linaro.org> wrote: > since V2: > -typo fix in implementers guide (Bill) > > since V1: > -new cosmetic fixes in patch 1 (Christophe) > -fixed patch 2's l2_fwd_run.sh patch (Yi)

[lng-odp] [PATCHv3 0/4] Restructuring tests for clarity and new interfaces.

2016-07-13 Thread Christophe Milard
since V2: -typo fix in implementers guide (Bill) since V1: -new cosmetic fixes in patch 1 (Christophe) -fixed patch 2's l2_fwd_run.sh patch (Yi) -fixed implementers guide (Bill, Mike) -comment regarding patch4 in this cover-letter (Bill). -"all-platforms" directory now named "common_plat" T