Re: [lng-odp] [PATCHv5] linux-generic: packet: Add lazy parsing support

2015-05-13 Thread Bill Fischofer
No, it was a legit failure. I posted v6 of the patch to correct that. The issue is that the classifier was directly accessing internal packet data for performance, so it needed its own lazy parse hook. All should pass now. On Wed, May 13, 2015 at 8:32 AM, Maxim Uvarov wrote: > On 05/13/2015 1

Re: [lng-odp] [PATCHv5] linux-generic: packet: Add lazy parsing support

2015-05-13 Thread Maxim Uvarov
On 05/13/2015 15:04, Bill Fischofer wrote: Thanks. I'll look into this. When I checked before everything was passing so perhaps a rebase is needed. I applied it to the master branch, not sure if it works for api-next. Maxim. On Wed, May 13, 2015 at 4:50 AM, Maxim Uvarov

Re: [lng-odp] [PATCHv5] linux-generic: packet: Add lazy parsing support

2015-05-13 Thread Bill Fischofer
Thanks. I'll look into this. When I checked before everything was passing so perhaps a rebase is needed. On Wed, May 13, 2015 at 4:50 AM, Maxim Uvarov wrote: > For linux-generic it breaks classification test: > > Test: classification_pktio_test ...FAILED > 1. classification/odp_classific

Re: [lng-odp] [PATCHv5] linux-generic: packet: Add lazy parsing support

2015-05-13 Thread Maxim Uvarov
For linux-generic it breaks classification test: Test: classification_pktio_test ...FAILED 1. classification/odp_classification_tests.c:513 - queue == queue_list[CLS_DEFAULT] 2. classification/odp_classification_tests.c:563 - queue == queue_list[CLS_ERROR] Maxim. On 05/08/2015 04

Re: [lng-odp] [PATCHv5] linux-generic: packet: Add lazy parsing support

2015-05-12 Thread Zoltan Kiss
I can't find the original of this mail in my Thunderbird, but anyhow: Reviewed-by: Zoltan Kiss And I've tested the packet_flags changes with ODP-DPDK. Zoli ___ lng-odp mailing list lng-odp@lists.linaro.org https://lists.linaro.org/mailman/listinfo/ln

[lng-odp] [PATCHv5] linux-generic: packet: Add lazy parsing support

2015-05-07 Thread Bill Fischofer
Lazy parsing defers parsing until the results are actually needed. This allows applications that do their own parsing and never reference ODP parse results to avoid the overhead of SW parsing. Signed-off-by: Bill Fischofer --- Changes in v5: - Streamline implementation for odp-dpdk compatibility