Ping
-Original Message-
From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Ion Grigore
Sent: Monday, January 04, 2016 2:54 PM
To: Maxim Uvarov ; Ilya Maximets
Cc: lng-odp@lists.linaro.org
Subject: Re: [lng-odp] [PATCHv7] helper : Fix UDP checksum computation
Done, as
Done, as it was suggested.
Thanks,
Grig
-Original Message-
From: Maxim Uvarov [mailto:maxim.uva...@linaro.org]
Sent: Thursday, December 31, 2015 10:07 AM
To: Ilya Maximets ; Ion Grigore
; lng-odp@lists.linaro.org
Subject: Re: [PATCHv7] helper : Fix UDP checksum computation
On 12/31/20
On 12/31/2015 08:26, Ilya Maximets wrote:
This version almost good.
2 more comments:
* no need to remove blank lines at the beginning of the file.
that is ok. Our checkpatch did not capture double empty lines at the
beginning, now it does.
So this patch just removes that checkpatch wa
This version almost good.
2 more comments:
* no need to remove blank lines at the beginning of the file.
* Why checksum is computed in the CPU endianness? There is no
reason to do so. I can't imagine case where checksum will be
needed in CPU endiannes. IMO, it's
Ilya is that version good for you? Do you want to add your Review-by?
Maxim.
On 12/17/2015 19:36, Ion Grigore wrote:
Ping
-Original Message-
From: ion.grig...@freescale.com [mailto:ion.grig...@freescale.com]
Sent: Monday, December 14, 2015 12:52 PM
To: lng-odp@lists.linaro.org
Cc: Grig
Ping
-Original Message-
From: ion.grig...@freescale.com [mailto:ion.grig...@freescale.com]
Sent: Monday, December 14, 2015 12:52 PM
To: lng-odp@lists.linaro.org
Cc: Grigore Ion-B17953
Subject: [PATCHv7] helper : Fix UDP checksum computation
From: Grigore Ion
This patch fixes the follo
From: Grigore Ion
This patch fixes the following problems:
- checksum computation for LE platforms
- checksum is computed in the CPU endianness. The returned result
must be converted to the BE ordering when it is used to update
the UDP checksum in a packet.
- checksum computation for packets havi
