Small patch series to:

- remove the basic socket support as it doesn't seem to be used anymore
- support segmented packets in socket MMSG mode.

The first and third patches are quite straight forward.

The second has more to discuss:
* I'm not fully happy the way we compute the max packet size using MAX_SEG * 
odp_buffer_pool_segment_size
It would make sense to have an API call the largest possible element 
allocatable using a pool.
In the mean time, I can probably add an inline function in pool_internal

* Does the API allow to send packets non allocated through a pool? (Ie malloced 
manually)
The code to convert packets to iovec has a little bit of complexity to handle 
per segment length,
 headroom and/or tailroom larger than a segment and so on.
If all packets are allocated using a pool, it would make sense to enforce 
headroom and tailroom < seg_len.
Plus we could assume all seg_len are equal.

Nicolas Morey-Chaisemartin (3):
  linux-generic: pktio: remove basic socket implementation
  linux-generic: pktio: handle segmented packet in socket mode
  test: pktio: reduce pools seg_len to test segmented packets

 example/generator/odp_generator.c                  |   1 -
 example/packet/odp_pktio.c                         |   1 -
 .../linux-generic/include/odp_packet_io_internal.h |   3 +-
 platform/linux-generic/odp_packet_io.c             |  18 ---
 platform/linux-generic/odp_packet_socket.c         | 176 ++++++++-------------
 platform/linux-generic/test/pktio/pktio_run        |   2 +-
 test/performance/odp_l2fwd.c                       |   1 -
 test/validation/pktio/pktio.c                      |   4 +-
 8 files changed, 72 insertions(+), 134 deletions(-)

_______________________________________________
lng-odp mailing list
lng-odp@lists.linaro.org
https://lists.linaro.org/mailman/listinfo/lng-odp

Reply via email to