Re: [lng-odp] odp_platform_init_t vs ODP_PLATFORM_PARAMS

2015-11-18 Thread Bill Fischofer
On Wed, Nov 18, 2015 at 4:58 AM, Zoltan Kiss wrote: > > On 17/11/15 20:46, Bill Fischofer wrote: > >> I vote for B. The idea is that if the application wishes to override it >> can do so otherwise let the implementation take its defaults from the >> environment or

Re: [lng-odp] odp_platform_init_t vs ODP_PLATFORM_PARAMS

2015-11-18 Thread Zoltan Kiss
On 18/11/15 12:05, Bill Fischofer wrote: On Wed, Nov 18, 2015 at 4:58 AM, Zoltan Kiss > wrote: On 17/11/15 20:46, Bill Fischofer wrote: I vote for B. The idea is that if the application wishes to override it

Re: [lng-odp] odp_platform_init_t vs ODP_PLATFORM_PARAMS

2015-11-18 Thread Bill Fischofer
On Wed, Nov 18, 2015 at 6:51 AM, Zoltan Kiss wrote: > > > On 18/11/15 12:05, Bill Fischofer wrote: > >> >> >> On Wed, Nov 18, 2015 at 4:58 AM, Zoltan Kiss > > wrote: >> >> >> On 17/11/15 20:46, Bill Fischofer

Re: [lng-odp] odp_platform_init_t vs ODP_PLATFORM_PARAMS

2015-11-18 Thread Savolainen, Petri (Nokia - FI/Espoo)
> > --- a/include/odp/api/init.h > +++ b/include/odp/api/init.h > @@ -152,6 +152,10 @@ typedef struct odp_platform_init_t { >* >* @see odp_term_global() >* @see odp_init_local() which is required per thread before use. > + * @note The underlying implementation may have an another way

Re: [lng-odp] odp_platform_init_t vs ODP_PLATFORM_PARAMS

2015-11-18 Thread Mike Holmes
On 18 November 2015 at 08:08, Savolainen, Petri (Nokia - FI/Espoo) < petri.savolai...@nokia.com> wrote: > > > > --- a/include/odp/api/init.h > > +++ b/include/odp/api/init.h > > @@ -152,6 +152,10 @@ typedef struct odp_platform_init_t { > >* > >* @see odp_term_global() > >* @see

[lng-odp] odp_platform_init_t vs ODP_PLATFORM_PARAMS

2015-11-17 Thread Zoltan Kiss
Hi all, Our odp_init_global() has a second parameter with type odp_platform_init_t. It's supposed to convey platform specific init parameters, however neither linux-generic nor linux-dpdk uses that. In the latter we use instead the ODP_PLATFORM_PARAMS environment variable. It has the little

Re: [lng-odp] odp_platform_init_t vs ODP_PLATFORM_PARAMS

2015-11-17 Thread Bill Fischofer
I vote for B. The idea is that if the application wishes to override it can do so otherwise let the implementation take its defaults from the environment or however else it wishes to support platform-specific configuration options. This is in keeping with how we handle other overridable defaults

Re: [lng-odp] odp_platform_init_t vs ODP_PLATFORM_PARAMS

2015-11-17 Thread Mike Holmes
On 17 November 2015 at 13:54, Zoltan Kiss wrote: > Hi all, > > Our odp_init_global() has a second parameter with type > odp_platform_init_t. It's supposed to convey platform specific init > parameters, however neither linux-generic nor linux-dpdk uses that. In the >