[lng-odp] packet copy questions

2016-06-06 Thread Zoltan Kiss
Hi, During the ODP-DPDK 1.10 upgrade I found these two things: - Should _odp_packet_copy_md_to_packet() copy timestamp and op_result? - odp_packet_copy() doesn't copy the user area. I think it would be better if it just calls _odp_packet_copy_md_to_packet() Regards, Zoltan __

Re: [lng-odp] packet copy questions

2016-06-06 Thread Bill Fischofer
The user area is explicitly reserved for use by the application. As a result any copying or other manipulation of it is the application's responsibility. The exception to this is ODP APIs that implicitly make a new copy of a source packet (e.g., in response to odp_packet_add_data() reallocating the

Re: [lng-odp] packet copy questions

2016-06-07 Thread Savolainen, Petri (Nokia - FI/Espoo)
/** * Full copy of a packet * * Create a new copy of the packet. The new packet is exact copy of the source * packet (incl. data and metadata). The pool must have been created with * ODP_POOL_PACKET type. * All metadata should be copied into the new packet. User controls user_area sizes in

Re: [lng-odp] packet copy questions

2016-06-07 Thread Bill Fischofer
Sounds like this should be considered a bug. I'll open one to track it. On Tue, Jun 7, 2016 at 2:18 AM, Savolainen, Petri (Nokia - FI/Espoo) < petri.savolai...@nokia.com> wrote: > /** > * Full copy of a packet > * > * Create a new copy of the packet. The new packet is exact copy of the > sourc

Re: [lng-odp] packet copy questions

2016-06-08 Thread Zoltan Kiss
And what about this first question: Should _odp_packet_copy_md_to_packet() copy timestamp and op_result? On 07/06/16 13:03, Bill Fischofer wrote: Sounds like this should be considered a bug. I'll open one to track it. On Tue, Jun 7, 2016 at 2:18 AM, Savolainen, Petri (Nokia - FI/Espoo) mailto: