Guten Tag Robert Middleton,
am Freitag, 8. Juli 2016 um 04:43 schrieben Sie:
> Here's a quick patch for it. Note that if 'zip' fails, the only
> thing that will be printed out is log4cxx: Exception during rollover.
Thanks, applied and in my mind we can live with that. We can't know
which zip uti
Author: tschoening
Date: Fri Jul 8 06:27:32 2016
New Revision: 1751863
URL: http://svn.apache.org/viewvc?rev=1751863&view=rev
Log:
If the child zip-process fails, throw an IOException, like with all the other
errors.
Modified:
incubator/log4cxx/trunk/src/main/cpp/zipcompressaction.cpp
Modi
This is the specific line in APR that causes the exit value to be -1 :
https://github.com/apache/apr/blob/42fa31d7219e9371771a1549e3c63c68f74a1540/threadproc/unix/proc.c#L592
When the apr_proc_t is created in log4cxx, it is set to be
APR_PROGRAM_PATH, which in APR will call execvp(). Since 'zip'
Author: tschoening
Date: Thu Jul 7 19:38:49 2016
New Revision: 1751829
URL: http://svn.apache.org/viewvc?rev=1751829&view=rev
Log:
Cleaning up the code a bit.
Modified:
incubator/log4cxx/trunk/src/main/cpp/zipcompressaction.cpp
Modified: incubator/log4cxx/trunk/src/main/cpp/zipcompressactio
Guten Tag Robert Middleton,
am Donnerstag, 7. Juli 2016 um 15:26 schrieben Sie:
> I have figured out why this test is failing on my machine, I don't
> have the 'zip' utility installed by default.
Good to hear it was that simple. ;-)
> Due to how APR works as well, we get back an exit code of 255
I have figured out why this test is failing on my machine, I don't have the
'zip' utility installed by default.
I did a bit of debugging on this as well, log4cxx does not currently check
to see what the exit status of the process is as well. Due to how APR
works as well, we get back an exit code
