DO NOT REPLY [Bug 17511] - Patch for Chainsaw to utilise Receiver framework

2003-03-10 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 17511] - Patch for Chainsaw to utilise Receiver framework

2003-03-10 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

cvs commit: jakarta-log4j/src/java/org/apache/log4j/chainsaw Main.java EventDetailSink.java ChainsawAppender.java

2003-03-10 Thread oburn
oburn 2003/03/10 21:22:50 Modified:src/java/org/apache/log4j/chainsaw Main.java EventDetailSink.java ChainsawAppender.java Log: Fix checkstyle errors Revision ChangesPath 1.7 +10 -10jakarta-log4j/src/java/org/apache/log4j/chainsaw/Main.

cvs commit: jakarta-log4j/src/java/org/apache/log4j/chainsaw RecentFilesMenu.java

2003-03-10 Thread oburn
oburn 2003/03/10 21:15:58 Modified:src/java/org/apache/log4j/chainsaw RecentFilesMenu.java Log: Patch to fix Checkstyle errors Revision ChangesPath 1.4 +10 -1 jakarta-log4j/src/java/org/apache/log4j/chainsaw/RecentFilesMenu.java Index: RecentFilesMenu.ja

cvs commit: jakarta-log4j/src/java/org/apache/log4j/chainsaw PreferencesDialog.java

2003-03-10 Thread oburn
oburn 2003/03/10 21:15:27 Modified:src/java/org/apache/log4j/chainsaw PreferencesDialog.java Log: Patch to fix Checkstyle errors Revision ChangesPath 1.3 +42 -3 jakarta-log4j/src/java/org/apache/log4j/chainsaw/PreferencesDialog.java Index: PreferencesDia

cvs commit: jakarta-log4j/src/java/org/apache/log4j/chainsaw Preferences.java

2003-03-10 Thread oburn
oburn 2003/03/10 21:14:57 Modified:src/java/org/apache/log4j/chainsaw Preferences.java Log: Patch to fix Checkstyle errors Revision ChangesPath 1.3 +17 -5 jakarta-log4j/src/java/org/apache/log4j/chainsaw/Preferences.java Index: Preferences.java ===

cvs commit: jakarta-log4j/src/java/org/apache/log4j/chainsaw MyTableColumnModel.java

2003-03-10 Thread oburn
oburn 2003/03/10 21:14:28 Modified:src/java/org/apache/log4j/chainsaw MyTableColumnModel.java Log: Patch to fix Checkstyle errors Revision ChangesPath 1.4 +29 -6 jakarta-log4j/src/java/org/apache/log4j/chainsaw/MyTableColumnModel.java Index: MyTableColum

cvs commit: jakarta-log4j/src/java/org/apache/log4j/chainsaw Log4JConfigurationFinder.java

2003-03-10 Thread oburn
oburn 2003/03/10 21:13:58 Modified:src/java/org/apache/log4j/chainsaw Log4JConfigurationFinder.java Log: Patch to fix Checkstyle errors Revision ChangesPath 1.3 +12 -1 jakarta-log4j/src/java/org/apache/log4j/chainsaw/Log4JConfiguration

cvs commit: jakarta-log4j build.xml

2003-03-10 Thread mwomack
mwomack 2003/03/10 20:24:50 Modified:.build.xml Log: Changes to use the Start class to executes Chainsaw instead of the Main class. Revision ChangesPath 1.55 +2 -2 jakarta-log4j/build.xml Index: build.xml ==

cvs commit: jakarta-log4j/src/java/org/apache/log4j/chainsaw Start.java

2003-03-10 Thread mwomack
mwomack 2003/03/10 20:18:34 Modified:src/java/org/apache/log4j/chainsaw Start.java Log: Added a LocalDirectoryFinder to the FinderStrategies, after ResourceLoaderFinder, but before FileOpenFinder. It looks for the config file in the current directory. Revision ChangesPath

[Chainsaw]: Checkstyle fixes

2003-03-10 Thread Paul Smith
Find attached a large patch which adds JavaDoc comments and generally conforms to the requirements of the checkstyle target. There are only 2 errors now: [checkstyle] C:\Jakarta\jakarta-log4j\src\java\org\apache\log4j\chainsaw\ControlPanel.jav a:100: Constructor length is 198 lines (max allowed i

cvs commit: jakarta-log4j/src/java/org/apache/log4j/chainsaw ChainsawAppender.java

2003-03-10 Thread oburn
oburn 2003/03/10 19:56:58 Modified:src/java/org/apache/log4j/chainsaw ChainsawAppender.java Log: After a run through Jalopy Revision ChangesPath 1.2 +13 -20 jakarta-log4j/src/java/org/apache/log4j/chainsaw/ChainsawAppender.java Index: ChainsawAppender.jav

cvs commit: jakarta-log4j build.properties.sample

2003-03-10 Thread oburn
oburn 2003/03/10 19:42:24 Modified:.build.properties.sample Log: Improved doco Revision ChangesPath 1.8 +3 -2 jakarta-log4j/build.properties.sample Index: build.properties.sample =

RE: Checkstyle target problem

2003-03-10 Thread Paul Smith
Thanks to Oliver for prodding the easy things to check. The solution turns out that I had a copy of Checkstyle 3.0 in my AN_HOME/lib directory, and of couse the classloader found the class in that jar first. I renamed the checkstyle 3.0 jar to *.bak and it worked beautifully. thanks Oliver. Pau

cvs commit: jakarta-log4j build.xml

2003-03-10 Thread oburn
oburn 2003/03/10 14:24:21 Modified:.build.xml Log: Added Chainsaw source code to list of styled files. Revision ChangesPath 1.54 +1 -0 jakarta-log4j/build.xml Index: build.xml ===

RE: Checkstyle target problem

2003-03-10 Thread Paul Smith
> Try using an absolute path to the jar file. Like: > > checkstyle.jar=/path/to/checkstyle-2.4/checkstyle-all-2.4.jar Bummer, nope that didn't work either. ant -debug shows the class and property file being loaded by the parent class loader. So it seems to be finding it. weird. Is there some

RE: Checkstyle target problem

2003-03-10 Thread Oliver Burn
Try using an absolute path to the jar file. Like: checkstyle.jar=/path/to/checkstyle-2.4/checkstyle-all-2.4.jar > -Original Message- > From: Paul Smith [mailto:[EMAIL PROTECTED] > Sent: Tuesday, 11 March 2003 08:58 > To: 'Log4J Developers List' > Subject: RE: Checkstyle target problem >

RE: Checkstyle target problem

2003-03-10 Thread Paul Smith
> Are they any objections if I upgrade the Log4J build.xml to > use it? That would be cool. Inidicently, I think my cause isn't the lack of finding the jar, as I've found the checkstyle target under -verbose setting and get this: checkstyle: [taskdef] Loading definitions from resource checksty

RE: Chainsaw Log4JConfigurationFinder

2003-03-10 Thread Oliver Burn
+1 on this idea Mark. I would suggest you commit the changes you made. > -Original Message- > From: Mark Womack [mailto:[EMAIL PROTECTED] > Sent: Tuesday, 11 March 2003 08:36 > To: Log4j-Dev (E-mail) > Subject: Chainsaw Log4JConfigurationFinder > > > I really liked this addition with the

RE: Chainsaw Log4JConfigurationFinder

2003-03-10 Thread Mark Womack
> Incidently, there is still some issue on my system with a race to > configurate Log4j during Chainsaw startup. Somehow during > the intLog4j > method, Log4j initialises, configures a Chainsaw appender, > which in turn > inits a MyTableModel, which seems to kick off ANOTHER log4j > search for

RE: Checkstyle target problem

2003-03-10 Thread Mark Womack
> BTW - there is a Checkstyle version 3.0 which has many improvements. > See http://checkstyle.sourceforge.net/releasenotes.html. > > Are they any objections if I upgrade the Log4J build.xml to > use it? +1 -Mark - To unsubscri

RE: Checkstyle target problem

2003-03-10 Thread Oliver Burn
Yes - that would be the cause. BTW - there is a Checkstyle version 3.0 which has many improvements. See http://checkstyle.sourceforge.net/releasenotes.html. Are they any objections if I upgrade the Log4J build.xml to use it? Regards, Oliver > -Original Message- > From: Mark Womack [mail

RE: Checkstyle target problem

2003-03-10 Thread Paul Smith
> Did you define the "checkstyle.jar" property in your local > build.properties? Yup: [build.properties] # Checkstyle OPTIONAL; required to run the checkstyle target Available from http://checkstyle.sf.net checkstyle.jar=../checkstyle-2.4/checkstyle-all-2.4.jar Inside the checkstyle-all-2.4.

DO NOT REPLY [Bug 17511] - Patch for Chainsaw to utilise Receiver framework

2003-03-10 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

RE: Checkstyle target problem

2003-03-10 Thread Mark Womack
Did you define the "checkstyle.jar" property in your local build.properties? -Mark > -Original Message- > From: Paul Smith [mailto:[EMAIL PROTECTED] > Sent: Monday, March 10, 2003 1:47 PM > To: Log4j-Dev (E-mail) > Subject: Checkstyle target problem > > > I can't seem to run the checkst

RE: Chainsaw Log4JConfigurationFinder

2003-03-10 Thread Paul Smith
> I added one > more on my local system that looks for the config file in the current > directory (ie the directory you launch chainsaw from). I put > it after the > classpath finder, but before the gui finder. That's a really good idea. > Also, do we want it to search for a file named "chains

Checkstyle target problem

2003-03-10 Thread Paul Smith
I can't seem to run the checkstyle target, I've got Checkstyle 2.4 downloaded and modified the build.properties file but when I do an 'ant checkstyle' I get: $ ant checkstyle Buildfile: build.xml init: checkstyle: BUILD FAILED file:c:/Jakarta/jakarta-log4j/build.xml:327: Must specify 'config'.

Chainsaw Log4JConfigurationFinder

2003-03-10 Thread Mark Womack
I really liked this addition with the recent patches from Paul. I added one more on my local system that looks for the config file in the current directory (ie the directory you launch chainsaw from). I put it after the classpath finder, but before the gui finder. Does anyone think that this wou

DO NOT REPLY [Bug 17511] - Patch for Chainsaw to utilise Receiver framework

2003-03-10 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

cvs commit: jakarta-log4j/src/java/org/apache/log4j/chainsaw log4j.xml Start.java Log4JConfigurationFinder.java EventDetailSink.java ChainsawAppender.java XMLFileHandler.java RecentFilesMenu.java MyTableModel.java MyTableColumnModel.java Main.java LoggingReceiver.java LoadXMLAction.java DetailPanel.java

2003-03-10 Thread oburn
oburn 2003/03/10 02:24:13 Modified:src/java/org/apache/log4j/chainsaw XMLFileHandler.java RecentFilesMenu.java MyTableModel.java MyTableColumnModel.java Main.java LoggingReceiver.java LoadXMLAction.java

DO NOT REPLY [Bug 17511] - Patch for Chainsaw to utilise Receiver framework

2003-03-10 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu