sdeboy 2004/08/01 23:01:22
Modified:src/java/org/apache/log4j/chainsaw/color RuleColorizer.java
ColorPanel.java
Log:
removed 'clear' method from RuleColorizer - use 'setRules' instead
Revision ChangesPath
1.11 +0 -4
logging-log4j/src/ja
Ahh. All makes sense now. Perhaps we should leave ourselves a
note in the code then to highlight the 'weirdness' of why we don't notify
listeners at this point. (Maybe a TODO while we're there).
Thanks for taking the time to write a really detailed description.
Cheers,
Paul
> -
The code calling clear (ColorPanel's applyRules method) does end up triggering the
colorrule propertychange notification, through the 'addRules' call (as does setRules).
Clear is unneeded - I'll change the caller to use setRules and remove the clear
method.
There was a cycle in the ColorPanel/
I would help out more quickly if the patches were in the Unified diff format
(diff -u ). I think some of the new ones are in Contextual diff format, and
since my IDE (Eclipse) doesn't support that, I'm less motivated to go to the
command line to apply the patch...
However a definitive list on wha
I'm curious about the below change. I would have thought the code should
notify listeners when the information the rule is based on is changed?
Could you describe why we need to remove that line?
Paul
>
> Index: RuleColorizer.java
> =
+---+
| Bugzilla Bug ID |
| +-+
| | Status: UNC=Unconfirmed NEW=New ASS=Assigned
mp/public/workspace/dist/junit/junit.jar:/usr/local/gump/public/workspace/logging-log4j/log4j-20040801.jar:/usr/local/gump/public/workspace/logging-log4j/log4j-chainsaw-20040801.jar:/usr/local/gump/public/workspace/logging-log4j/log4j-lf5-20040801.jar:/usr/local/gump/public/worksp
