Re: TimeZone and locale for PatternLayout Was: [RESULT][VOTE]

2004-12-20 Thread Curt Arnold
At this moment, I'm too tired to try to fully understand why it fails and how it could be fixed. More tomorrow. The underlying code did not anticipate the use of only two 'SS' which I assume that milliseconds 0 to 99 are represented with two digits and 100-999 with three. I have attached anot

DO NOT REPLY [Bug 32064] - Simplify Obsolete and Buggy DateFormat, maybe specify TimeZone and Locale

2004-12-20 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

cvs commit: logging-log4j/src/java/org/apache/log4j/helpers AbsoluteTimeDateFormat.java DateTimeDateFormat.java ISO8601DateFormat.java RelativeTimeDateFormat.java

2004-12-20 Thread carnold
carnold 2004/12/20 20:19:47 Modified:src/java/org/apache/log4j PatternLayout.java src/java/org/apache/log4j/helpers AbsoluteTimeDateFormat.java DateTimeDateFormat.java ISO8601DateFormat.java RelativeTimeDateFormat.java Log:

DO NOT REPLY [Bug 22369] - TelnetAppender.SocketHandler.send removes elements in Vector while iterating

2004-12-20 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

cvs commit: logging-log4j/tests .cvsignore build.xml

2004-12-20 Thread carnold
carnold 2004/12/20 18:53:37 Modified:tests.cvsignore build.xml Log: Bug 32722: Test coverage analysis with clover Revision ChangesPath 1.3 +3 -0 logging-log4j/tests/.cvsignore Index: .cvsignore

DO NOT REPLY [Bug 32722] - Test coverage analysis

2004-12-20 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 22369] - TelnetAppender.SocketHandler.send removes elements in Vector while iterating

2004-12-20 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

cvs commit: logging-log4j/src/java/org/apache/log4j/net TelnetAppender.java

2004-12-20 Thread carnold
carnold 2004/12/20 17:49:25 Modified:src/java/org/apache/log4j/net TelnetAppender.java Log: Bug 22369: TelnetAppender removes elements while iterating Revision ChangesPath 1.11 +13 -8 logging-log4j/src/java/org/apache/log4j/net/TelnetAppender.java Index: Te

DO NOT REPLY [Bug 22368] - TelnetAppender should check if any connections before rendering message

2004-12-20 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

cvs commit: logging-log4j/tests/input/performance telnet.xml

2004-12-20 Thread carnold
carnold 2004/12/20 17:24:10 Modified:src/java/org/apache/log4j/net TelnetAppender.java testsperformance.xml Added: tests/input/performance telnet.xml Log: Bug 22368: TelnetAppender should check for connections before rendering message Revision Change

Re: TimeZone and locale for PatternLayout Was: [RESULT][VOTE]

2004-12-20 Thread Curt Arnold
On Dec 20, 2004, at 3:26 PM, Ceki Gülcü wrote: As invoked earlier, I think CachedDateFormat may fail for certain patterns at certain dates. If we can recognize the limited number of formats for which it fails (if it does) and sidestep those, then fine. Before going any further, do you agree that pa

Re: TimeZone and locale for PatternLayout Was: [RESULT][VOTE]

2004-12-20 Thread Ceki Gülcü
Not necessarily the most convincing use case, but the following fails, import org.apache.log4j.*; import org.apache.log4j.helpers.*; import java.text.*; import java.util.*; public class CDF { protected static FieldPosition pos = new FieldPosition(0); public static void main(String[] args) throw

Re: TimeZone and locale for PatternLayout Was: [RESULT][VOTE]

2004-12-20 Thread Ceki Gülcü
Curt, At 10:26 PM 12/20/2004, Ceki Gülcü wrote: As invoked earlier, I think CachedDateFormat may fail for certain patterns at certain dates. If we can recognize the limited number of formats for which it fails (if it does) and sidestep those, then fine. Before going any further, do you agree that p

Re: TimeZone and locale for PatternLayout Was: [RESULT][VOTE]

2004-12-20 Thread Ceki Gülcü
At 06:11 PM 12/20/2004, Curt Arnold wrote: The existing AbsoluteTimeDateFormat, ISO8601DateFormat, and DateTimeDateFormat contained buggy caching code and had been effectively abandoned since PatternLayout no longer created these classes, but created java.text.SimpleDateFormat objects. The prop

Re: Logging configuration XML schema (was Re: [RESULT][VOTE])

2004-12-20 Thread Ceki Gülcü
At 08:22 PM 12/20/2004, Curt Arnold wrote: On Dec 20, 2004, at 8:48 AM, Ceki Gülcü wrote: I still owe the list an iteration on an XML schema for the http://logging.apache.org namespace. I assume that I should file a bug report on this when ready. Any suggestions on the appropriate location in

RE: cvs commit: logging-log4j/src/java/org/apache/log4j LogManager.java

2004-12-20 Thread Ceki Gülcü
LocationInfo is allowed to fail in extracting caller information while Logger.getLogger(...) must always succeed. If LocationInfo fails you either get incorrect location information or just '?' for the %M, %C, %L, %F pattern converters. If Logger.getLogger() fails then the whole named hierarchy bec

Logging configuration XML schema (was Re: [RESULT][VOTE])

2004-12-20 Thread Curt Arnold
On Dec 20, 2004, at 8:48 AM, Ceki Gülcü wrote: I still owe the list an iteration on an XML schema for the http://logging.apache.org namespace. I assume that I should file a bug report on this when ready. Any suggestions on the appropriate location in the hierarchy? I think docs/logging.xsd w

RE: cvs commit: logging-log4j/src/java/org/apache/log4j LogManager.java

2004-12-20 Thread Scott Deboy
To help wrap this up, would you mind providing a little history into the conversations that took place when LocationInfo was first added? I assume the same issue was discussed - LocationInfo's lack of reliability versus its benefit to the end user. That conversation must have tipped in favor o

RE: cvs commit: logging-log4j/src/java/org/apache/log4j LogManager.java

2004-12-20 Thread Ceki Gülcü
Hello, Indeed, testing the automatic logger naming feature will be quite hard to test on all platforms. Not only that, the behavior of a particular JVM may vary between the test environment and the environment of a real-world application. So no amount of brute-force (automated) testing

Re: TimeZone and locale for PatternLayout Was: [RESULT][VOTE]

2004-12-20 Thread Curt Arnold
On Dec 20, 2004, at 8:33 AM, Ceki Gülcü wrote: CachedDateFormat is pretty interesting. However, I suspect that it may not work properly in case the data format passed by the user causes the length of the returned data to change over time. For example, if the format is '-M-dd HH:mm:ss' and t

Re: [RESULT][VOTE] Curt Arnold as a new log4j committer

2004-12-20 Thread Ceki Gülcü
I still owe the list an iteration on an XML schema for the http://logging.apache.org namespace. I assume that I should file a bug report on this when ready. Any suggestions on the appropriate location in the hierarchy? I think docs/logging.xsd would probably be best. How about 'http://loggin

Re: [RESULT][VOTE] Curt Arnold as a new log4j committer

2004-12-20 Thread Ceki Gülcü
At 12:55 AM 12/19/2004, Curt Arnold wrote: Thanks, I think. What a strange and unusual Christmas gift. You are the one who is making the gift. There are several bugs that I have previously reported, please let me know if anyone has any objects to my proceeding to address them. The bugs are: Tel

RE: cvs commit: logging-log4j/src/java/org/apache/log4j LogManager.java

2004-12-20 Thread Scott Deboy
I don't think we (dev) have the resources ourselves to perform this testing, since testing this chane necessarily requires a wide variety of JVMs. It sounds like we have a bit of a chicken and egg problem here. I made the change for these reasons: - No existing code relies on this change - It's

TimeZone and locale for PatternLayout Was: [RESULT][VOTE]

2004-12-20 Thread Ceki Gülcü
At 12:55 AM 12/19/2004, Curt Arnold wrote: CachedDateFormat is pretty interesting. However, I suspect that it may not work properly in case the data format passed by the user causes the length of the returned data to change over time. For example, if the format is '-M-dd HH:mm:ss' and the c

Re: [RESULT][VOTE] Curt Arnold as a new log4j committer

2004-12-20 Thread Ceki Gülcü
At 12:55 AM 12/19/2004, Curt Arnold wrote: Thanks, I think. What a strange and unusual Christmas gift. You are the one who is making the gift. There are several bugs that I have previously reported, please let me know if anyone has any objects to my proceeding to address them. The bugs are: Tel

DO NOT REPLY [Bug 32722] - Test coverage analysis

2004-12-20 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 22368] - TelnetAppender should check if any connections before rendering message

2004-12-20 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 22369] - TelnetAppender.SocketHandler.send removes elements in Vector while iterating

2004-12-20 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

RE: cvs commit: logging-log4j build.xml

2004-12-20 Thread Ceki Gülcü
Hello Scott, -1, because: The build file is already non trivial. Duplicating it sounds like a terribly bad idea. At 10:39 PM 12/18/2004, Scott Deboy wrote: How about a compromise: Rename the current build target to build-deps-optional and make a new (default) build target that fails on missing d

cvs commit: logging-log4j/src/java/org/apache/log4j LogManager.java

2004-12-20 Thread ceki
ceki2004/12/20 03:10:16 Modified:src/java/org/apache/log4j LogManager.java Log: Unsafe feature. Revision ChangesPath 1.29 +0 -10 logging-log4j/src/java/org/apache/log4j/LogManager.java Index: LogManager.java

Re: cvs commit: logging-log4j/src/java/org/apache/log4j LogManager.java

2004-12-20 Thread Ceki Gülcü
Scott, Please see http://marc.theaimsgroup.com/?t=11015036401&r=1&w=2 Log4, as the most popular a logging API, must be reliable. Speed, convenience, user demand are all secondary considerations when compared with reliably. This change severely compromises reliability. It must be either backed u

Re: Throwable Debugging with Log4J 1.3 (patch for 1.3a? )

2004-12-20 Thread Ceki Gülcü
Kevin, Thank you for your comments. This problem has been discussed before. Please sse http://marc.theaimsgroup.com/?t=11015036401&r=1&w=2 In short, we'd very much like to add this feature but fear that it cannot be done do reliably. At 01:19 AM 12/20/2004, Kevin A. Burton wrote: I just blogg

DO NOT REPLY [Bug 24159] - Log4J can create deadlock conditions

2004-12-20 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu