Re: Removing PluginClassloader

2005-01-12 Thread Paul Smith
First I apologise if my email came across harsh (it does to me now that I read it again) I blame it on the jetlag and the cold weather. :D (it's 10 degrees C in London at the moment, and 37 degrees back home in Melbourne) Could I ask for a bit longer to think about this before committing eith

DO NOT REPLY [Bug 29726] - DailyRollingFileAppender : log4j:ERROR Failed to rename

2005-01-12 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

cvs commit: logging-log4j/tests/src/java/org/apache/log4j/joran/action - New directory

2005-01-12 Thread ceki
ceki2005/01/12 10:04:25 logging-log4j/tests/src/java/org/apache/log4j/joran/action - New directory - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: logging-log4j/src/java/org/apache/log4j/joran JoranConfigurator.java

2005-01-12 Thread ceki
ceki2005/01/12 07:08:27 Modified:src/java/org/apache/log4j/joran/action ConversionRuleAction.java LoggerAction.java AppenderRefAction.java AppenderAction.java PluginAction.java PropertyAction.java

cvs commit: logging-log4j/src/java/org/apache/log4j/joran JoranConfigurator.java

2005-01-12 Thread ceki
ceki2005/01/12 07:04:21 Modified:src/java/org/apache/log4j/joran/action LevelAction.java ConversionRuleAction.java LoggerAction.java AppenderRefAction.java AppenderAction.java PropertyAction.java RootLoggerAction

cvs commit: logging-log4j/src/java/org/apache/log4j/joran/spi - New directory

2005-01-12 Thread ceki
ceki2005/01/12 07:04:11 logging-log4j/src/java/org/apache/log4j/joran/spi - New directory - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

Re: Removing PluginClassloader

2005-01-12 Thread Ceki Gülcü
Recalling a previous discussion [1], I was under the (possibly wrong?) impression that you were also convinced that dropping the PluginRepositoryFactory would be good thing. Setting the thread context class loader, unless absolutely necessary, usually amounts to bad practice. Anyway, if you fe

Re: Removing PluginClassloader

2005-01-12 Thread Paul Smith
Ceki, I know you have a problem with classloader trickery, and I'm sure it's for good reason, but I'm not sure why we have to remove it for Chainsaw? Is it really that big a deal? Chainsaw is for all intents and purposes an application built around log4j, rather than a core log4j component.

Removing PluginClassloader

2005-01-12 Thread Ceki Gülcü
Hello Paul, Scott, Here is a patch that gets rid of PluginClassLoaderFactory class in o.a.l.chainsaw.plugins. To accomodate this change it renames LogUI.loadConfigurationUsingPluginClassLoader() as logUI.loadConfiguration(URL). It also removes the dependency on PluginClassLoaderFactory in o.a.

cvs commit: logging-log4j/tests/integration/src/webapp/WEB-INF/classes test-log4j.xml

2005-01-12 Thread ceki
ceki2005/01/12 04:06:23 Modified:tests/integration build.xml tests/integration/src/webapp/WEB-INF/classes test-log4j.xml Added: tests/integration README.txt tests/integration/src/java TestAppender.java Removed: tests/input/xml fallback1.xml

cvs commit: logging-log4j/tests/integration build.properties.sample

2005-01-12 Thread ceki
ceki2005/01/12 03:46:24 Added: tests/integration build.properties.sample Log: Missing file Revision ChangesPath 1.1 logging-log4j/tests/integration/build.properties.sample Index: build.properties.sample ===