Re: Appenders + Managers + Reconfiguration

2013-04-28 Thread Nick Williams
Okay. So consider this scenario: Someone has the FileAppender configured to write to file X. They change the configuration to write to file Y. Since the FileManager already exists writing to file X, the FileManager won't be stopped. Its use count will increase to 2 and the newly-configured FileA

Re: Appenders + Managers + Reconfiguration

2013-04-28 Thread Ralph Goers
When a reconfiguration takes place a new configuration is first created. All the Filters, Appenders, etc named in the configuration will be created. However, when the Appender calls getManager() it may find that one already exists with the name it is searching for. If so, that manager's use cou

Appenders + Managers + Reconfiguration

2013-04-28 Thread Nick Williams
Guys, I'm almost ready to submit a patch for JDBC/JPA/MongoDB/CouchDB, but I'd like a little bit of instruction on something. I want to make sure I'm understanding things correctly, because I'm getting ... strange ... results when reloading configuration in between unit tests. So, if you have

Re: Trivialities

2013-04-28 Thread Remko Popma
I went ahead and committed changes to checkstyle.xml to remove false positives  for NewlineAtEndOfFile and whitespace at end of line. (revision 1476883) The CheckStyle error count went down from 429 to 175. Any objections on (2) below: adding false to the findbugs-maven-plugin configuration in a

Re: Nick, want to be mentioned as contributor in Project Team page?

2013-04-28 Thread Gary Gregory
Yes, please leave the TZ in. Gary On Apr 28, 2013, at 17:10, Ralph Goers wrote: Yes - I like knowing when people might be awake. Ralph On Apr 28, 2013, at 12:43 PM, Nick Williams wrote: I think the "Actual Time" column is unnecessary (and it's what's REALLY taking up a lot of space), but the

Re: Restrict JPA classes to specific package?

2013-04-28 Thread Remko Popma
Yes, I am using that expression to allow spaces in javadoc after a '*' locally and it works fine. Would love to commit if nobody objects. About NewlineAtEndOfFile, I was wrong. The files I committed end in 0x0A (unix newline). Same with the files Ralph committed (and I think he works on a Mac).

Re: Nick, want to be mentioned as contributor in Project Team page?

2013-04-28 Thread Remko Popma
+1 We can add it for everyone. (My timezone is +9.) From: Ralph Goers To: Log4J Developers List Sent: Monday, April 29, 2013 6:10 AM Subject: Re: Nick, want to be mentioned as contributor in Project Team page? Yes - I like knowing when people might be awak

Re: Restrict JPA classes to specific package?

2013-04-28 Thread Nick Williams
As for the RegexpSingleline issue, this might help: http://stackoverflow.com/questions/9100059/checkstyle-trailing-spaces-regexp-issue As for the NewlineAtEndOfFile issue, I would suggest that files should NEVER be committed to SVN with CRLF endings. This is an incorrect ending. This is one pla

Re: Nick, want to be mentioned as contributor in Project Team page?

2013-04-28 Thread Ralph Goers
Yes - I like knowing when people might be awake. Ralph On Apr 28, 2013, at 12:43 PM, Nick Williams wrote: > I think the "Actual Time" column is unnecessary (and it's what's REALLY > taking up a lot of space), but the Time Zone column can be useful. It's nice > to know when someone is on a comp

Re: commit notification

2013-04-28 Thread Ralph Goers
I guess I should have mentioned it. I at least glance through every commit. I kind of expect every committer will do the same at this point. In larger projects with lots of parts and committers they tend to only look at the components they maintain, but we aren't that big. Ralph On Apr 28

Re: Restrict JPA classes to specific package?

2013-04-28 Thread Remko Popma
About CheckStyle: I would like to change the "RegexpSingleline" rule to allow spaces in javadoc after a '*'. Also, the NewlineAtEndOfFile check seems broken. (http://checkstyle.sf.net/config_misc.html#NewlineAtEndOfFile) If I commit something on a PC the file will end with "crlf". Then someone on

Re: Restrict JPA classes to specific package?

2013-04-28 Thread Nick Williams
Using the CheckStyle ImportControl module, I was able to restrict uses of javax.persistence to o.a.l.l.core.appender.db.jpa, uses of org.mongodb to o.a.l.l.core.appender.db.nosql.mongo, etc. It doesn't "break the build" if someone violates this rule, which would be ideal. Currently it's just a n

[commit] moved classes to helpers package

2013-04-28 Thread Remko Popma
I have moved the Clock interface, ClockFactory class and Clock impl classes  from the core.async package to core.helpers. Updated the manual/async.xml page accordingly. It may be an idea to replace all calls to System.currentTimeMillis() with ClockFactory.getClock().currentTimeMillis(). In the as

Re: Nick, want to be mentioned as contributor in Project Team page?

2013-04-28 Thread Christian Grobmeier
Remko, you can always change it later - so just do what finds your pleasure ;-) Christian On Sun, Apr 28, 2013 at 10:05 PM, Remko Popma wrote: > Christian, > > I see your point and I think it is valid. Roles may only make sense for the > contributor section. > On the other hand I am quite proud

Re: Nick, want to be mentioned as contributor in Project Team page?

2013-04-28 Thread Remko Popma
Christian, I see your point and I think it is valid. Roles may only make sense for the contributor section. On the other hand I am quite proud of my Async Logger contribution... (Ego, ego, I know...)  Hmm... Let me think about it for a little. Remko From: Chri

Re: Nick, want to be mentioned as contributor in Project Team page?

2013-04-28 Thread Christian Grobmeier
On Sun, Apr 28, 2013 at 9:54 PM, Nick Williams wrote: > Remember that some of us (me) are not committers, so the role can be a > helpful indicator. Just my $0.02. What would it help you? As said, I am not opposed to utilize the role section, I am just trying to understand the benefit. Things al

[jira] [Resolved] (LOG4J2-225) Improve documentation on use of location in pattern layouts

2013-04-28 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Remko Popma resolved LOG4J2-225. Resolution: Fixed Fixed in revision 1476820. Changed most sample pattern layouts that used %C to %

Re: Nick, want to be mentioned as contributor in Project Team page?

2013-04-28 Thread Nick Williams
Remember that some of us (me) are not committers, so the role can be a helpful indicator. Just my $0.02. N On Apr 28, 2013, at 2:48 PM, Christian Grobmeier wrote: > We are not usually using the "role" section. If you like it, keep it, > but basically we are all just "committers". My guess is yo

Re: Nick, want to be mentioned as contributor in Project Team page?

2013-04-28 Thread Christian Grobmeier
We are not usually using the "role" section. If you like it, keep it, but basically we are all just "committers". My guess is you will touch so much code while committing to log4j that this section will fill a whole page along (maybe release manager? ;-)). If you ask me, drop the role - we are all

Re: Nick, want to be mentioned as contributor in Project Team page?

2013-04-28 Thread Remko Popma
Committed. I put timezone back for you. Pls take a look and just give a shout if you want to change anything. From: Remko Popma To: Log4J Developers List Sent: Monday, April 29, 2013 4:36 AM Subject: Re: Nick, want to be mentioned as contributor in Project Tea

Re: Nick, want to be mentioned as contributor in Project Team page?

2013-04-28 Thread Nick Williams
I think the "Actual Time" column is unnecessary (and it's what's REALLY taking up a lot of space), but the Time Zone column can be useful. It's nice to know when someone is on a completely different schedule than you are. :-) N On Apr 28, 2013, at 2:36 PM, Remko Popma wrote: > I just moved mys

Re: Nick, want to be mentioned as contributor in Project Team page?

2013-04-28 Thread Remko Popma
I just moved myself to the committers list and removed the timezone columns as it was taking up too much space. Any preference for showing timezone or not? From: Nick Williams To: Log4J Developers List ; Remko Popma Sent: Monday, April 29, 2013 4:31 AM Subje

Re: Nick, want to be mentioned as contributor in Project Team page?

2013-04-28 Thread Nick Williams
This email address is fine. My time zone is America/Chicago. Nick On Apr 28, 2013, at 2:28 PM, Remko Popma wrote: > Do you want an email address mentioned or do you prefer to keep that blank? > > From: Nick Williams > To: Log4J Developers List > Sent: Monday, April 29, 2013 4:23 AM > Subjec

Re: Nick, want to be mentioned as contributor in Project Team page?

2013-04-28 Thread Christian Grobmeier
definitely +1. Thanks keeping that record up to date On Sun, Apr 28, 2013 at 9:23 PM, Remko Popma wrote: > I'm kind of assuming that everybody else won't mind me asking, I hope that's > ok... :-) > > > From: Remko Popma > To: Log4J Dev-List > Sent: Monday, April

Re: Nick, want to be mentioned as contributor in Project Team page?

2013-04-28 Thread Remko Popma
Do you want an email address mentioned or do you prefer to keep that blank? From: Nick Williams To: Log4J Developers List Sent: Monday, April 29, 2013 4:23 AM Subject: Re: Nick, want to be mentioned as contributor in Project Team page? Sure. Especially sin

Re: Nick, want to be mentioned as contributor in Project Team page?

2013-04-28 Thread Nick Williams
Sure. Especially since I'll soon be contributing three database appenders with two NoSQL providers :-). Nick On Apr 28, 2013, at 2:18 PM, Remko Popma wrote: > Nick, > > You contributed the JSP taglib module, so I thought I'd ask. > Do you want to be mentioned as a contributor in the Project Te

Re: Nick, want to be mentioned as contributor in Project Team page?

2013-04-28 Thread Remko Popma
I'm kind of assuming that everybody else won't mind me asking, I hope that's ok... :-) From: Remko Popma To: Log4J Dev-List Sent: Monday, April 29, 2013 4:18 AM Subject: Nick, want to be mentioned as contributor in Project Team page? Nick, You contribute

Nick, want to be mentioned as contributor in Project Team page?

2013-04-28 Thread Remko Popma
Nick, You contributed the JSP taglib module, so I thought I'd ask. Do you want to be mentioned as a contributor in the Project Team page? Remko

Re: commit notification

2013-04-28 Thread Remko Popma
Christian, I didn't know, thanks! Remko From: Christian Grobmeier To: Log4J Developers List ; Remko Popma Sent: Monday, April 29, 2013 3:47 AM Subject: Re: commit notification Remko, do you know about comm...@logging.apache.org? It sending every diff yo

Re: commit notification

2013-04-28 Thread Christian Grobmeier
Remko, do you know about comm...@logging.apache.org? It sending every diff you are doing directly to our inbox. If you would like to get the same notifications, just subscribe to commits-subscr...@logging.apache.org HTH :-) Anyway, the intention to notify everybody is great! Christian On Sun,

commit notification

2013-04-28 Thread Remko Popma
commit -m "fixed spelling errors" C:/Users/remko/workspace/log4j2-trunk/src/site/xdoc/manual/markers.xml C:/Users/remko/workspace/log4j2-trunk/src/site/xdoc/manual/eventlogging.xml C:/Users/remko/workspace/log4j2-trunk/src/site/xdoc/manual/flowtracing.xml     Sending         C:/Users/remko/works

[jira] [Created] (LOG4J2-226) PDF table of contents misses Configuration and Layouts sections

2013-04-28 Thread Remko Popma (JIRA)
Remko Popma created LOG4J2-226: -- Summary: PDF table of contents misses Configuration and Layouts sections Key: LOG4J2-226 URL: https://issues.apache.org/jira/browse/LOG4J2-226 Project: Log4j 2

[jira] [Created] (LOG4J2-225) Improve documentation on use of location in pattern layouts

2013-04-28 Thread Remko Popma (JIRA)
Remko Popma created LOG4J2-225: -- Summary: Improve documentation on use of location in pattern layouts Key: LOG4J2-225 URL: https://issues.apache.org/jira/browse/LOG4J2-225 Project: Log4j 2 Issu

[jira] [Closed] (LOG4J2-218) Improve documentation for FileAppender and basic use cases

2013-04-28 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-218?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Remko Popma closed LOG4J2-218. -- > Improve documentation for FileAppender and basic use cases >

[jira] [Resolved] (LOG4J2-218) Improve documentation for FileAppender and basic use cases

2013-04-28 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-218?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Remko Popma resolved LOG4J2-218. Resolution: Invalid Well, this is embarrassing: immediateFlush is actually true by default. Ahem.

commit notification

2013-04-28 Thread Remko Popma
commit -m "fixed Checkstyle errors" (10 paths specified)     Sending         C:/Users/remko/workspace/log4j2-trunk/core/src/main/java/org/apache/logging/log4j/core/jmx/AppenderAdmin.java     Sending         C:/Users/remko/workspace/log4j2-trunk/core/src/main/java/org/apache/logging/log4j/core/jmx/A

Re: Trivialities

2013-04-28 Thread Nick Williams
On Apr 28, 2013, at 8:02 AM, Remko Popma wrote: > Trivialities > > 1) (note) > In o.a.l.l.c.c.p.ResolverUtil line 279 > I put the cast back in this line removing the cast broke the build on my > machine: > > //Do not remove the cast on the next line as removing it will cause a compile > erro

[jira] [Closed] (LOG4J2-173) BurstFilter does not honour level

2013-04-28 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ralph Goers closed LOG4J2-173. -- > BurstFilter does not honour level > - > > Key: LOG4J2

[jira] [Resolved] (LOG4J2-173) BurstFilter does not honour level

2013-04-28 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ralph Goers resolved LOG4J2-173. Resolution: Not A Problem > BurstFilter does not honour level > ---

Trivialities

2013-04-28 Thread Remko Popma
Trivialities 1) (note) In o.a.l.l.c.c.p.ResolverUtil line 279  I put the cast back in this line removing the cast broke the build on my machine: //Do not remove the cast on the next line as removing it will cause a compile error on Java 7. final BundleWiring wiring = (BundleWiring) FrameworkUti

Bug report for Log4j [2013/04/28]

2013-04-28 Thread bugzilla
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned