[jira] [Commented] (LOG4J2-593) INFO: Illegal access: this web application instance has been stopped already.

2014-04-01 Thread Arul Anthony Sebastian (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13957406#comment-13957406 ] Arul Anthony Sebastian commented on LOG4J2-593: --- Hi We have restarted the

[jira] [Created] (LOG4J2-593) INFO: Illegal access: this web application instance has been stopped already.

2014-04-01 Thread Arul Anthony Sebastian (JIRA)
Arul Anthony Sebastian created LOG4J2-593: - Summary: INFO: Illegal access: this web application instance has been stopped already. Key: LOG4J2-593 URL: https://issues.apache.org/jira/browse/LOG4J2-593

Re: LOG4J2-583, XML and JSON unmarshalling

2014-04-01 Thread Gary Gregory
Also interesting: Google GSON in on my Eclipse project CP, so it must be brought in... somehow... Gary On Tue, Apr 1, 2014 at 5:37 PM, Gary Gregory wrote: > JacksonXmlProperty? Why not JsonProperty? Couldn't you then use JSON or > XML? Still learning Jackson... > > Gary > > > On Tue, Apr 1, 20

Re: LOG4J2-583, XML and JSON unmarshalling

2014-04-01 Thread Ralph Goers
I have no idea why it is named JacksonXmlProperty instead of JsonProperty, but it is for extended XML annotations. Ralph On Apr 1, 2014, at 2:37 PM, Gary Gregory wrote: > JacksonXmlProperty? Why not JsonProperty? Couldn't you then use JSON or XML? > Still learning Jackson... > > Gary > > >

Re: LOG4J2-583, XML and JSON unmarshalling

2014-04-01 Thread Ralph Goers
I have both examples there. Ralph On Apr 1, 2014, at 1:57 PM, Matt Sicker wrote: > Is that for the XML or JSON mapping? > > > On 1 April 2014 15:55, Ralph Goers wrote: > Also, with Jackson you only have to annotate things where the normal mapping > doesn’t do what you want. For example, by

Re: LOG4J2-583, XML and JSON unmarshalling

2014-04-01 Thread Gary Gregory
JacksonXmlProperty? Why not JsonProperty? Couldn't you then use JSON or XML? Still learning Jackson... Gary On Tue, Apr 1, 2014 at 4:49 PM, Ralph Goers wrote: > I just did this the other day for both XML and JSON. > > For XML I did: > > public static TransactionRequest deserialize(String xm

Re: core.impl.Log4jLogEvent.LogEventProxy

2014-04-01 Thread Gary Gregory
On Tue, Apr 1, 2014 at 4:40 PM, Matt Sicker wrote: > With the existing JAXB annotations, do you think a compatible JSON file > could be generated? > No. Because it is not enough to annotate, you need custom un/marshallers. > Minus namespaces of course (or even with namespaces by prepending the

Re: LOG4J2-583, XML and JSON unmarshalling

2014-04-01 Thread Matt Sicker
Actually, that brought up an idea I just had. Since the XML parsing log4j's config does isn't strict about whether you use an attribute or nested element (which sounds like it meshes nicely with JSON), maybe the parsing can be unified somewhat? I know I made some progress at de-duplicating code in

Re: LOG4J2-583, XML and JSON unmarshalling

2014-04-01 Thread Matt Sicker
Is that for the XML or JSON mapping? On 1 April 2014 15:55, Ralph Goers wrote: > Also, with Jackson you only have to annotate things where the normal > mapping doesn’t do what you want. For example, by default everything will > be an element. You need to annotate it if you want it to be an attr

Re: LOG4J2-583, XML and JSON unmarshalling

2014-04-01 Thread Ralph Goers
Also, with Jackson you only have to annotate things where the normal mapping doesn’t do what you want. For example, by default everything will be an element. You need to annotate it if you want it to be an attribute. On Apr 1, 2014, at 1:52 PM, Ralph Goers wrote: > Oops - For XML the serializ

Re: LOG4J2-583, XML and JSON unmarshalling

2014-04-01 Thread Ralph Goers
Oops - For XML the serialization is public void serialize(OutputStream stream) { try { final XmlMapper mapper = new XmlMapper(); mapper.writeValue(stream, this); } catch (Exception ex) { ex.printStackTrace(); } } On Apr 1, 2014,

Re: LOG4J2-583, XML and JSON unmarshalling

2014-04-01 Thread Matt Sicker
It's amusing that both Jackson and Woodstox are both FasterXML projects. You'd think there'd be some code sharing going on? Or is FasterXML more like Apache or Codehaus? On 1 April 2014 15:49, Ralph Goers wrote: > I just did this the other day for both XML and JSON. > > For XML I did: > > p

Re: LOG4J2-583, XML and JSON unmarshalling

2014-04-01 Thread Ralph Goers
I just did this the other day for both XML and JSON. For XML I did: public static TransactionRequest deserialize(String xmlFile) { try { XmlMapper mapper = new XmlMapper(); InputStream stream = new FileInputStream(xmlFile); return mapper.readValue

Re: core.impl.Log4jLogEvent.LogEventProxy

2014-04-01 Thread Matt Sicker
With the existing JAXB annotations, do you think a compatible JSON file could be generated? Minus namespaces of course (or even with namespaces by prepending them to keys). I might tinker with that later to see. Could get a structured text sort of API going out of it. On 1 April 2014 11:03, Gary

[jira] [Commented] (LOG4J2-590) HTMLLayout filter stacktrace

2014-04-01 Thread Matt Sicker (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13956987#comment-13956987 ] Matt Sicker commented on LOG4J2-590: Alright, then perhaps it would make more sense fo

Re: LOG4J2-583, XML and JSON unmarshalling

2014-04-01 Thread Gary Gregory
Well... so much for Jackson making my life easy. Jackson says it "supports" JAXB annotations but that must be only for the simplest cases. Jackson does not work with the JAXB annotations I used on Log4jLogEvents. This suppose this is not surprising. Back to the drawing board... Gary On Tue, Apr

[jira] [Resolved] (LOG4J2-592) Update Jackson to 2.3.2 from 2.2.2.

2014-04-01 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory resolved LOG4J2-592. - Resolution: Fixed > Update Jackson to 2.3.2 from 2.2.2. > --- > >

[jira] [Created] (LOG4J2-592) Update Jackson to 2.3.2 from 2.2.2.

2014-04-01 Thread Gary Gregory (JIRA)
Gary Gregory created LOG4J2-592: --- Summary: Update Jackson to 2.3.2 from 2.2.2. Key: LOG4J2-592 URL: https://issues.apache.org/jira/browse/LOG4J2-592 Project: Log4j 2 Issue Type: Improvement

Re: LOG4J2-583, XML and JSON unmarshalling

2014-04-01 Thread Gary Gregory
All good ideas, thank you. The JSON API I know best is GSON, which let's you listen to objects opening and closing. Maybe Jackson has something like that... I'll have to dig in. Gary On Tue, Apr 1, 2014 at 11:14 AM, Ralph Goers wrote: > So you are hacking the stream before passing it to the unm

Re: core.impl.Log4jLogEvent.LogEventProxy

2014-04-01 Thread Gary Gregory
On Tue, Apr 1, 2014 at 11:04 AM, Matt Sicker wrote: > Oh good catch. Maybe in JDK9 they'll put JSON in there. > One can only hope... but I do marvel at the lack of vision though, how can this not be a tweak on top of JAXB? Gary > > > On 1 April 2014 07:39, Gary Gregory wrote: > >> OK, I've l

[jira] [Commented] (LOG4J2-590) HTMLLayout filter stacktrace

2014-04-01 Thread JIRA
[ https://issues.apache.org/jira/browse/LOG4J2-590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13956635#comment-13956635 ] Matej Vitásek commented on LOG4J2-590: -- Ralph, absolutely correct. Let me customize t

[jira] [Commented] (LOG4J2-590) HTMLLayout filter stacktrace

2014-04-01 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13956629#comment-13956629 ] Ralph Goers commented on LOG4J2-590: Matt, that sounds good but in practice I have no

[jira] [Comment Edited] (LOG4J2-591) Log4j closes MongoDB connections after the first log message

2014-04-01 Thread Matt Sicker (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13956624#comment-13956624 ] Matt Sicker edited comment on LOG4J2-591 at 4/1/14 3:18 PM: So

[jira] [Commented] (LOG4J2-591) Log4j closes MongoDB connections after the first log message

2014-04-01 Thread Matt Sicker (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13956624#comment-13956624 ] Matt Sicker commented on LOG4J2-591: So does MongoClient hold an internal pool of conn

[jira] [Commented] (LOG4J2-591) Log4j closes MongoDB connections after the first log message

2014-04-01 Thread Tal Liron (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13956621#comment-13956621 ] Tal Liron commented on LOG4J2-591: -- I would suggest that it's unnecessary to close the Mo

Re: LOG4J2-583, XML and JSON unmarshalling

2014-04-01 Thread Ralph Goers
So you are hacking the stream before passing it to the unmarshalling framework? Then you will have to keep track of the ‘{‘ and ‘}’ characters yourself, either with the stack Matt suggests or as a counter. Ralph On Apr 1, 2014, at 8:07 AM, Matt Sicker wrote: > Keep a stack of {'s and pop the

[jira] [Created] (LOG4J2-591) Log4j closes MongoDB connections after the first log message

2014-04-01 Thread Tal Liron (JIRA)
Tal Liron created LOG4J2-591: Summary: Log4j closes MongoDB connections after the first log message Key: LOG4J2-591 URL: https://issues.apache.org/jira/browse/LOG4J2-591 Project: Log4j 2 Issue T

Re: LOG4J2-583, XML and JSON unmarshalling

2014-04-01 Thread Nick Williams
That would work if he was parsing the JSON manually, which is itself an extremely complex thing to do. It sounds like he's using Jackson—and rightly so. I'm not entirely sure how to do this with Jackson, but I help out with the development over there from time to time, and I can ask the mailing

[jira] [Commented] (LOG4J2-590) HTMLLayout filter stacktrace

2014-04-01 Thread Matt Sicker (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13956609#comment-13956609 ] Matt Sicker commented on LOG4J2-590: I propose adding the ability to chain together la

Re: LOG4J2-583, XML and JSON unmarshalling

2014-04-01 Thread Matt Sicker
Keep a stack of {'s and pop them when you get a }. Like a deterministic pushdown automaton. On 1 April 2014 07:45, Gary Gregory wrote: > I have a local patch for LOG4J2-583 to have the Log4j TCP and UDP socket > servers unmarhsal XML log events. > > This is "easy" for XML because when you have

Re: core.impl.Log4jLogEvent.LogEventProxy

2014-04-01 Thread Matt Sicker
Oh good catch. Maybe in JDK9 they'll put JSON in there. On 1 April 2014 07:39, Gary Gregory wrote: > OK, I've looked at EJ item #78, JAXB and Jackson a little more. Initially, > it looks like #78 is specific to Java Serializable objects but the pattern > should also apply to other "extralinguis

Re: unit test failures?

2014-04-01 Thread Matt Sicker
I converted the file appender tests in question to use a JUnit rule to delete files after a test is run. This doesn't happen until after the @Test method is executed (so no checking for files and such in an @After method). This was to get rid of all the duplicate calls to file.delete() in several t

[jira] [Created] (LOG4J2-590) HTMLLayout filter stacktrace

2014-04-01 Thread JIRA
Matej Vitásek created LOG4J2-590: Summary: HTMLLayout filter stacktrace Key: LOG4J2-590 URL: https://issues.apache.org/jira/browse/LOG4J2-590 Project: Log4j 2 Issue Type: Wish Rep

LOG4J2-583, XML and JSON unmarshalling

2014-04-01 Thread Gary Gregory
I have a local patch for LOG4J2-583 to have the Log4j TCP and UDP socket servers unmarhsal XML log events. This is "easy" for XML because when you have a stream of bytes and you know its encoding, you can look for the end of an event by looking for its closing tag: . Right now, my XML processing c

Re: core.impl.Log4jLogEvent.LogEventProxy

2014-04-01 Thread Gary Gregory
OK, I've looked at EJ item #78, JAXB and Jackson a little more. Initially, it looks like #78 is specific to Java Serializable objects but the pattern should also apply to other "extralinguistic mechanisms" for marshalling. I'll go back and see my JAXB implementation can be made cleaner... Gary O

Re: unit test failures?

2014-04-01 Thread Gary Gregory
I should also point out that the tests themselves might be at issue. I just fixed a couple of bugs (locally only) in the socket server tests that held never closed server sockets as part of my change set for LOG4J2-583. So more problems would not be a surprise. Gary On Tue, Apr 1, 2014 at 8:21 AM

Re: unit test failures?

2014-04-01 Thread Gary Gregory
On Tue, Apr 1, 2014 at 1:51 AM, Ralph Goers wrote: > Is this a flaw in the recent changes Matt made? > My guess is yes. > Do they need to be reverted? Or are the tests themselves flawed? I also > haven't had the time to investigate. > Well, this is the tricky part. Matt has suggested that th