I would be in favor of renaming .add(Marker parent) to
.addParents(Marker... parents). If people think it's a big deal, we could
have .addParent(Marker parent) and .addParents(Marker... parents), but I
don't see a lot of value in having two methods.
It is true, I do really want to have the vararg
ASAIKS, there are currently only two places that use
System.currentTimeMillis() for creating the log event timestamp:
* one of the Log4jLogEvent constructors
* PatternProcessor#formatFileName - the log event created here is a
temporary object used only by the StrSubstitutor
Not 100% sure about the
Ha I didn't notice this was a JIRA thread!
On Thursday, 1 May 2014, Remko Popma wrote:
> Actually, Matt, I take that back with apologies. I'll start a discussion
> thread on the dev list. The Jira can be focussed on the user requirements.
>
>
> On Fri, May 2, 2014 at 7:02 AM, Remko Popma
>
> >
In recent Jira ticket LOG4J2-628 "Cannot set log4j.Clock with Async
appender", the user requests that all log event timestamps are generated
from the a configurable Clock. Currently only log event timestamps
generated by Async Loggers are configurable.
I think it makes sense to do this.
I propose
Actually, Matt, I take that back with apologies. I'll start a discussion
thread on the dev list. The Jira can be focussed on the user requirements.
On Fri, May 2, 2014 at 7:02 AM, Remko Popma wrote:
> Matt, can you make this a Jira comment? Not sure Bryan is on this list &
> I'd prefer to have
Matt, can you make this a Jira comment? Not sure Bryan is on this list & I'd
prefer to have the full discussion either in the Jira comments or on the list:
half-half will be confusing...
Sent from my iPhone
> On 2014/05/02, at 5:19, Matt Sicker wrote:
>
> If we used Clock consistently through
If we used Clock consistently throughout, does this make sense to use
everywhere? We use the clock to determine thread killing timeouts for
instance. There are other places time is used that if it were to use the
Clock interface, we'd have to document the contract required to be followed
by it in o
So it seems like using the word "add" in this context sort of implies
adding a child or contained marker when it actually does the opposite. A
word like "with" or "from" or "using" might make more sense if we wanted to
keep the single word method name idea. Otherwise, addParent[s] or parent[s]
migh
[
https://issues.apache.org/jira/browse/LOG4J2-628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13986881#comment-13986881
]
Bryan Hsueh commented on LOG4J2-628:
Correct, my use case is not performance related.
I'm fine with that. Let's whittle & vote... and release the next RC!
On Mon, Apr 28, 2014 at 6:16 AM, Ralph Goers wrote:
> http://wiki.apache.org/logging/Log4jLogoNominations has a list of the
> logos and who likes what. I would hardly call that a vote. It is more like
> a poll. We currently h
Glad to hear it. With the duplicate OSGi modules gone, now it doesn't seem
so bad to add more modularity.
On 30 April 2014 20:37, Ralph Goers wrote:
> That makes a lot of sense to me
>
> Sent from my iPhone
>
> On Apr 30, 2014, at 6:05 PM, Bruce Brouwer
> wrote:
>
> Can we agree to pull out jp
Yeah, I was looking at minimal changes. I like the idea of making it more
obvious which are internal classes and which are public APIs.
The web module sounds like a good idea, too. I still don't understand
exactly why it's needed for using log4j in a web container on its own
(besides the shutdown
Well, a hierarchy has has node that are parents and children.
Our docs say:
/**
* Markers are objects that are used to add easily filterable information
to log messages.
*
* Markers can be hierarchical - each Marker may have a parent. This
allows for broad categories
* being subdivided int
Well, Bruce wants that method to accept a variable number of Markers, so a name
that is singular would be awkward. What else would one be adding?
It seems like we spend more time discussing renames than anything else - like
actually picking a logo.
Ralph
> On May 1, 2014, at 6:57 AM, Gary Gre
[
https://issues.apache.org/jira/browse/LOG4J2-609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13986604#comment-13986604
]
Bruce Brouwer commented on LOG4J2-609:
--
Ah yes, I wasn't thinking about that. I'll ha
I find the API name Marker.add(Marker) unclear.
OTOH, Marker.setParents(Marker...) is clear.
I propose to rename add(Marker) to addParent(Marker).
And I do not want to think about addChild(Marker) ;)
Gary
--
E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
Java Persistence with Hibernate,
[
https://issues.apache.org/jira/browse/LOG4J2-609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13986564#comment-13986564
]
Ralph Goers commented on LOG4J2-609:
But the StatusLogger is a singleton. If the jars
[
https://issues.apache.org/jira/browse/LOG4J2-609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13986527#comment-13986527
]
Bruce Brouwer commented on LOG4J2-609:
--
It seemed odd to me that a configuration (be
18 matches
Mail list logo
