Re: svn commit: r1594370 - in /logging/log4j/log4j2/trunk: log4j-1.2-api/src/main/java/org/apache/log4j/ log4j-1.2-api/src/test/java/org/apache/log4j/ log4j-core/src/main/java/org/apache/logging/log4j

2014-05-16 Thread Ralph Goers
On May 15, 2014, at 9:09 AM, Gary Gregory wrote: > On Wed, May 14, 2014 at 3:16 AM, Ralph Goers > wrote: > > On May 13, 2014, at 1:26 PM, ggreg...@apache.org wrote: > > > Author: ggregory > > Date: Tue May 13 20:26:31 2014 > > New Revision: 1594370 > > > > URL: http://svn.apache.org/r1594370

Re: [jira] [Commented] (LOG4J2-639) NPE in AsyncLogger.log(..)

2014-05-16 Thread Ralph Goers
I prefer not throwing an exception but logging it to the status logger. Ralph On May 16, 2014, at 7:16 PM, Remko Popma (JIRA) wrote: > >[ > https://issues.apache.org/jira/browse/LOG4J2-639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14000616#comm

Re: [proposal] import guidelines

2014-05-16 Thread Ralph Goers
Here is what I have in Intellij - http://imgur.com/wU4Y3wO. I agree with Remko that we should make an exception for org.junit.Assert.* Ralph On May 16, 2014, at 2:53 PM, Gary Gregory wrote: > I import most general (java, javax) to most specific (com) with org in > between. I think this is the

[jira] [Assigned] (LOG4J2-637) Log4j2 JMX: Updating the logging level via jConsole doesn't take effect

2014-05-16 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Remko Popma reassigned LOG4J2-637: -- Assignee: Remko Popma > Log4j2 JMX: Updating the logging level via jConsole doesn't take effect

[jira] [Commented] (LOG4J2-639) NPE in AsyncLogger.log(..)

2014-05-16 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14000616#comment-14000616 ] Remko Popma commented on LOG4J2-639: What is the expected behaviour if an application

Re: build ok?

2014-05-16 Thread Remko Popma
The build works for me as of Friday 21:15 EDT. I did have to remove an @Override tag. On Fri, May 16, 2014 at 1:08 AM, Gary Gregory wrote: > Is any one having problems running the tests from maven with the latest > from trunk? > > Gary > > -- > E-Mail: garydgreg...@gmail.com | ggreg...@apache.o

[jira] [Commented] (LOG4J2-635) Log4j 2 should also support properties file

2014-05-16 Thread Yang Hua Jie (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14000637#comment-14000637 ] Yang Hua Jie commented on LOG4J2-635: - It's just the opposite for me. I found xml and

[jira] [Assigned] (LOG4J2-639) NPE in AsyncLogger.log(..)

2014-05-16 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-639?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Remko Popma reassigned LOG4J2-639: -- Assignee: Remko Popma > NPE in AsyncLogger.log(..) > -- > >

Re: svn commit: r1595342 - /logging/log4j/log4j2/trunk/log4j-core/src/test/java/org/apache/logging/log4j/test/appender/ListAppender.java

2014-05-16 Thread Remko Popma
Why would you want to use CopyOnWriteArrayList? Is there a potential concurrency issue? Sent from my iPhone > On 2014/05/17, at 5:48, ggreg...@apache.org wrote: > > CopyOnWriteArrayList - To unsubscribe, e-mail: log4j-dev-unsu

Re: svn commit: r1595279 - in /logging/log4j/log4j2/trunk: log4j-core/src/main/java/org/apache/logging/log4j/core/ log4j-core/src/main/java/org/apache/logging/log4j/core/appender/db/jpa/ log4j-core/sr

2014-05-16 Thread Remko Popma
Sorry, but I honestly don't like this change. First, you'll probably find that this is incomplete: the client code also likely needs to know the key values, so in future we'd have to add a "getContextKeys()" method. (Any api that has a "getValue(key)" method needs a "getKeys()" method too.) Y

Re: Log4j 2 plugin to Liquibase

2014-05-16 Thread Mikael Ståldal
Yes, this is currently based on 2.0-rc1. On Wed, May 14, 2014 at 6:55 PM, Matt Sicker wrote: > Looks like you'll have to update it for the current API (which will be > finalized with 2.0). > > > On 14 May 2014 11:26, Mikael Ståldal wrote: > >> I have made an Log4j 2 plugin to Liquibase (http://

Re: Possible NPEs and LogEvent.getContextMap()

2014-05-16 Thread Remko Popma
I'm ok with changing the semantics & reflecting that in the docs. As long as we are careful not to create objects unnecessarily (if we return a constant that should be fine). Sent from my iPhone > On 2014/05/17, at 3:20, Gary Gregory wrote: > > Hm... the contract for LogEvent.getContextMap()

Re: [proposal] import guidelines

2014-05-16 Thread Paul Benedict
Why would you have to manually fiddle with anything after setting the import order in Eclipse? On May 16, 2014 5:29 PM, "Gary Gregory" wrote: > I import most general (java, javax) to most specific (com) with org in > between. I think this is the eclipse default. > > I want guidelines that eclipse

Re: [proposal] import guidelines

2014-05-16 Thread Remko Popma
I propose that we use wildcart imports for static imports. (I believe that's why this thread was started in the first place.) As Gary pointed out, often it is better to avoid static imports, but there are places where it is just too convenient. JUnit tests is one of those places. I really don'

Re: svn commit: r1595341 - /logging/log4j/log4j2/trunk/log4j-core/src/test/java/org/apache/logging/log4j/core/net/server/AbstractSocketServerTest.java

2014-05-16 Thread Remko Popma
Oh good! Does that mean we can reduce or perhaps even eliminate the sleep time? That would speed up the build by quite a bit! Sent from my iPhone > On 2014/05/17, at 5:48, ggreg...@apache.org wrote: > > Author: ggregory > Date: Fri May 16 20:48:28 2014 > New Revision: 1595341 > > URL: http://sv

build ok?

2014-05-16 Thread Gary Gregory
Is any one having problems running the tests from maven with the latest from trunk? Gary -- E-Mail: garydgreg...@gmail.com | ggreg...@apache.org Java Persistence with Hibernate, Second Edition JUnit in Action, Second Edition Spri

Fwd: svn commit: r1594582 - in /logging/log4j/log4j2/trunk/src/ide: ./ eclipse/ eclipse/4.3.2/ eclipse/4.3.2/organize-imports.importorder

2014-05-16 Thread Ralph Goers
I added settings for Intellij. I think I managed to order the imports in the same order although Intellij lets you specify whether you want blank lines between imports so I have some between javax and org and after the 4 listed and before static imports. I also specified that org.junit.Assert.

Re: Possible NPEs and LogEvent.getContextMap()

2014-05-16 Thread Ralph Goers
That should be fine if no code has to be changed. Ralph On May 16, 2014, at 11:20 AM, Gary Gregory wrote: > Hm... the contract for LogEvent.getContextMap() says it can return null, but > our implementation never returns null and in fact uses > java.util.Collections.EMPTY_ > MAP. > > What abo

Re: Mail problem?

2014-05-16 Thread Remko Popma
Oh. I didn't catch that. Thanks for letting me know. Any ETA on when things will be back to normal? Sent from my iPhone > On 2014/05/17, at 6:12, Gary Gregory wrote: > > There was an announcement a couple of days ago. On my phone now, can't find > it. > > Gary > > > Original messa

Re: svn commit: r1595201 - /logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/util/OptionConverter.java

2014-05-16 Thread Remko Popma
You're saying I should've fixed that too. I would have, but I didn't notice. I just fixed the content: docs said "true" but should be "false". Sent from my iPhone > On 2014/05/17, at 0:54, Gary Gregory wrote: > > Why not use {@code } consistently instead of a mix with ? > > Gary > > > ---

Re: build ok?

2014-05-16 Thread Gary Gregory
Specifically: ClockFactoryTest org.apache.logging.log4j.core.helpers.ClockFactoryTest testCustomClock(org.apache.logging.log4j.core.helpers.ClockFactoryTest) java.lang.AssertionError: expected: but was: at org.junit.Assert.fail(Assert.java:88) at org.junit.Assert.failNotEquals(Assert.jav

[jira] [Updated] (LOG4J2-638) Log4j2 JMX: getConfigText in LoggerContext is not working as documented

2014-05-16 Thread Mansoor Sajjad (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mansoor Sajjad updated LOG4J2-638: -- Description: I am trying to configure log4j2 to access the loggers via JMX and change their lo

[jira] [Updated] (LOG4J2-638) Log4j2 JMX: getConfigText in LoggerContext is not working as documented

2014-05-16 Thread Mansoor Sajjad (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mansoor Sajjad updated LOG4J2-638: -- Description: I am trying to configure log4j2 to access the loggers via JMX and change their lo

Re: svn commit: r1595334 - /logging/log4j/log4j2/trunk/log4j-core/src/test/java/org/apache/logging/log4j/core/net/server/AbstractSocketServerTest.java

2014-05-16 Thread Remko Popma
I don't know how many tests use this class, but they each take roughly 8 seconds on my laptop now... Altogether about a minute (maybe more) of the build is spent here. Is there not a different way to check if events have all arrived? Perhaps multiple short sleeps? Or use a "well-known" constant

Re: [proposal] import guidelines

2014-05-16 Thread Gary Gregory
I import most general (java, javax) to most specific (com) with org in between. I think this is the eclipse default.  I want guidelines that eclipse can sort automatically.  This way there is no time wasting with manual fiddling.  Gary Original message From: Paul Benedict Da

[jira] [Commented] (LOG4J2-623) Better structure of Thread Context Map in JSONLayout

2014-05-16 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14000394#comment-14000394 ] Ralph Goers commented on LOG4J2-623: Mikael, I would say that the Javadoc for the comp

[jira] [Created] (LOG4J2-639) NPE in AsyncLogger.log(..)

2014-05-16 Thread Mck SembWever (JIRA)
Mck SembWever created LOG4J2-639: Summary: NPE in AsyncLogger.log(..) Key: LOG4J2-639 URL: https://issues.apache.org/jira/browse/LOG4J2-639 Project: Log4j 2 Issue Type: Bug Componen

[jira] [Updated] (LOG4J2-639) NPE in AsyncLogger.log(..)

2014-05-16 Thread Mck SembWever (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-639?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mck SembWever updated LOG4J2-639: - Description: Our production environment suffers from {noformat} java.lang.NullPointerException at

Re: Mail problem?

2014-05-16 Thread Ralph Goers
You didn’t notice that the ASF email system was down for 3 days last week? If not we need to get you more involved! ;-) It appears to be still catching up because it is definitely acting strangely. I think I’ve received some emails twice. In one commit gary did I got messages 2-4 but not 1.

RE: Mail problem?

2014-05-16 Thread Gary Gregory
There was an announcement a couple of days ago. On my phone now, can't find it. Gary Original message From: Remko Popma Date:05/16/2014 11:59 (GMT-05:00) To: in...@apache.org,Log4J Developers List Subject: Mail problem? Is there a problem with email? I don't see emails fo

Re: build ok?

2014-05-16 Thread Gary Gregory
That's been fixed.  Darn email delays... Gary Original message From: Matt Sicker Date:05/16/2014 16:08 (GMT-05:00) To: Log4J Developers List Subject: Re: build ok? Yeah I was having issues, too. I sent a mail to the list I thought, but maybe it didn't get through? I trie

[jira] [Commented] (LOG4J2-637) Log4j2 JMX: Updating the logging level via jConsole doesn't take effect

2014-05-16 Thread Mansoor Sajjad (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13998732#comment-13998732 ] Mansoor Sajjad commented on LOG4J2-637: --- Configuration file attached. > Log4j2 JMX

Re: [proposal] import guidelines

2014-05-16 Thread Paul Benedict
I'd like to throw out something I've grown fond of, which is making one's home project the top import priority. For you guys, it would be "org.apache.logging.log4j". What I like so much about this choice is that it makes eye-balling the use of your own classes very apparent. Paul Cheers, Paul

Re: I think I've got a possible use for log4j-streams.

2014-05-16 Thread Matt Sicker
I know the Oracle Commerce framework (being as old as it is) has several places where they use PrintStream or PrintWriter for loggers. That seems to be a popular legacy-style product out there. On 16 May 2014 09:27, Gary Gregory wrote: > There are other non-JDK APIs that take streams for debugg

Fwd: svn commit: r1595201 - /logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/util/OptionConverter.java

2014-05-16 Thread Gary Gregory
Why not use {@code } consistently instead of a mix with ? Gary Original message From: rpo...@apache.org Date:05/16/2014 10:01 (GMT-05:00) To: comm...@logging.apache.org Subject: svn commit: r1595201 - /logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/

Re: Porting from v1 LoggerRepository

2014-05-16 Thread Ralph Goers
I have no idea what you mean by “port”. If you are accessing the LoggerRepository then you are in the guts of Log4j. The equivalent construct in Log4j 2 is the LoggerContext. Ralph On May 16, 2014, at 7:37 AM, Gary Gregory wrote: > What is the recommend way to port from version 1 LoggerRepo

Re: build ok?

2014-05-16 Thread Matt Sicker
Yeah I was having issues, too. I sent a mail to the list I thought, but maybe it didn't get through? I tried it in JDK9 and wasn't sure if that was the problem, but then I tried again with JDK7 and got the same exact error. On 15 May 2014 12:42, Gary Gregory wrote: > Specifically: > > ClockFact

Re: Build failing, my fault likely

2014-05-16 Thread Gary Gregory
Fixed in SVN. The email slowpokeness will likely make this thread irrelevant. Gary On Fri, May 16, 2014 at 3:11 PM, Gary Gregory wrote: > It looks like I broke something in the build, digging... and apologies. > > G > > -- > E-Mail: garydgreg...@gmail.com | ggreg...@apache.org > Java Persisten

Build failing, my fault likely

2014-05-16 Thread Gary Gregory
It looks like I broke something in the build, digging... and apologies. G -- E-Mail: garydgreg...@gmail.com | ggreg...@apache.org Java Persistence with Hibernate, Second Edition JUnit in Action, Second Edition Spring Batch in Act

Re: svn commit: r1593125 - in /logging/log4j/log4j2/trunk/log4j-api/src/main/java/org/apache/logging/log4j: ThreadContext.java spi/ThreadContextStack.java

2014-05-16 Thread Gary Gregory
Wow, that's interesting. The current problem I see with our implementation is that ThreadContext.EMPTY_STACK is not read-only while org.apache.logging.log4j.ThreadContext.EMPTY_MAP is read-only, as it should be. Gary On Fri, May 16, 2014 at 12:07 PM, Ralph Goers wrote: > Believe it or not, whe

[Bug 56505] New: Trace level logging broken when code is built with Java 6 Update 45 JDK

2014-05-16 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56505 Bug ID: 56505 Summary: Trace level logging broken when code is built with Java 6 Update 45 JDK Product: Log4j Version: 1.2.17 Hardware: PC Status: NEW

[proposal] import guidelines

2014-05-16 Thread Gary Gregory
I propose we use the following guidelines for import statements: https://svn.apache.org/repos/asf/logging/log4j/log4j2/trunk/src/ide/eclipse/4.3.2/organize-imports.importorder which in Eclipse looks like this: https://i.imgur.com/04C84XY.png Note that default settings are not reflected in the .

[jira] [Updated] (LOG4J2-637) Log4j2 JMX: Updating the logging level via jConsole doesn't take effect

2014-05-16 Thread Mansoor Sajjad (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mansoor Sajjad updated LOG4J2-637: -- Attachment: log4j2.xml > Log4j2 JMX: Updating the logging level via jConsole doesn't take effec

RE: Getting some failing tests in log4j-core

2014-05-16 Thread Gary Gregory
I fixed the pattern test. I see the other failure on Java 7. Gary Original message From: Matt Sicker Date:05/14/2014 12:42 (GMT-05:00) To: Log4J Developers List Subject: Getting some failing tests in log4j-core Failed tests: ClockFactoryTest.testCustomClock:82 expected

Re: Possible NPEs and LogEvent.getContextMap()

2014-05-16 Thread Gary Gregory
Hm... the contract for LogEvent.getContextMap() says it can return null, but our implementation never returns null and in fact uses java.util.Collections.EMPTY_ MAP. What about changing the LogEvent.getContextMap() Javadoc to require that a map always be returned? Gary On Fri, May 16, 2014 at 2

Possible NPEs and LogEvent.getContextMap()

2014-05-16 Thread Gary Gregory
LogEvent.getContextMap() can return null if there is no map. It seems that a default of a read-only empty Map (java.util.Collections.EMPTY_MAP) would be safer since it would avoid any NPEs from our own call sites and users' as well. Thoughts? Gary -- E-Mail: garydgreg...@gmail.com | ggreg...@a

Re: Getting some failing tests in log4j-core

2014-05-16 Thread Remko Popma
I have the same problem. Taking a look now. On Thu, May 15, 2014 at 1:42 AM, Matt Sicker wrote: > Failed tests: > ClockFactoryTest.testCustomClock:82 expected: org.apache.logging.log4j.core.helpers.ClockFactoryTest$MyClock> but > was: > PatternParserTest.testCustomPattern:106 Expected to en

Re: svn commit: r1594370 - in /logging/log4j/log4j2/trunk: log4j-1.2-api/src/main/java/org/apache/log4j/ log4j-1.2-api/src/test/java/org/apache/log4j/ log4j-core/src/main/java/org/apache/logging/log4j

2014-05-16 Thread Gary Gregory
On Wed, May 14, 2014 at 3:16 AM, Ralph Goers wrote: > > On May 13, 2014, at 1:26 PM, ggreg...@apache.org wrote: > > > Author: ggregory > > Date: Tue May 13 20:26:31 2014 > > New Revision: 1594370 > > > > URL: http://svn.apache.org/r1594370 > > Log: > > Rename org.apache.logging.log4j.core.util.Con

Re: svn commit: r1593598 - in /logging/log4j/log4j2/trunk/log4j-core/src: main/java/org/apache/logging/log4j/core/async/ test/java/org/apache/logging/log4j/core/async/

2014-05-16 Thread Remko Popma
Hang on! Doesn't this have large performance impact? You're creating the ThrowableProxy, with all the reflection and stack trace walking etc in the critical path - in the application thread that calls Logger.log(msg, ex). So we're always paying the cost of constructing an (expensive) ThrowableProxy

Re: svn commit: r1593125 - in /logging/log4j/log4j2/trunk/log4j-api/src/main/java/org/apache/logging/log4j: ThreadContext.java spi/ThreadContextStack.java

2014-05-16 Thread Ralph Goers
Believe it or not, when I tested ArrayDeque I found that it was slower than Stack. Ralph On May 16, 2014, at 7:33 AM, Gary Gregory wrote: > It's also hard to think of a "stack" as _not_ being a "collection". > > This is a good time to talk about it since we'll be stuck with it when we > ship

Mail problem?

2014-05-16 Thread Remko Popma
Is there a problem with email? I don't see emails for my commits or emails sent to the PMC, and I am receiving emails that are 9 hours or even 23 hours old. I've tried looking at the Apache site but I can't find any announcement... Remko

Re: svn commit: r1593125 - in /logging/log4j/log4j2/trunk/log4j-api/src/main/java/org/apache/logging/log4j: ThreadContext.java spi/ThreadContextStack.java

2014-05-16 Thread Remko Popma
Gary, You mention that it makes XML JSON serialization easier if the ContextStack held in Log4jLogEvent implements the Collection interface. Can you explain that a bit more? Perhaps there is another way to achieve the same benefit. Remko On Fri, May 16, 2014 at 11:33 PM, Gary Gregory wrote: > I

[jira] [Commented] (LOG4J2-623) Better structure of Thread Context Map in JSONLayout

2014-05-16 Thread JIRA
[ https://issues.apache.org/jira/browse/LOG4J2-623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13999668#comment-13999668 ] Mikael Ståldal commented on LOG4J2-623: --- But how is the poor Log4j user supposed to

Re: Dependency to javax.persistence

2014-05-16 Thread Gary Gregory
XML and JSON layouts and listeners are all Jackson-based and in svn. Gary Original message From: Matt Sicker Date:05/14/2014 21:53 (GMT-05:00) To: Log4J Developers List Subject: Re: Dependency to javax.persistence So what about generating or receiving XML log events? Gary

Re: Dependency to javax.persistence

2014-05-16 Thread Ralph Goers
Those would be the receivers I mentioned. I don’t know what you mean by “based on the presence of Jackson”. I suspect if you configure them without Jackson you will get a runtime error, which is what Mikael dislikes and why Joern suggested moving the stuff depending on Jackson into another mod

[jira] [Created] (LOG4J2-640) java.lang.NullPointerException cause by NULLThread.currentThread().getContextClassLoader() when logging

2014-05-16 Thread LIUJIAN (JIRA)
LIUJIAN created LOG4J2-640: -- Summary: java.lang.NullPointerException cause by NULLThread.currentThread().getContextClassLoader() when logging Key: LOG4J2-640 URL: https://issues.apache.org/jira/browse/LOG4J2-640

Re: Getting some failing tests in log4j-core

2014-05-16 Thread Remko Popma
The reason for the failing test is: java.lang.IllegalAccessException: Class org.apache.logging.log4j.core.util.Loader can not access a member of class org.apache.logging.log4j.core.helpers.ClockFactoryTest$MyClock with modifiers "" Problem in the core.util.Loader class. The loadClass method will r

[jira] [Commented] (LOG4J2-623) Better structure of Thread Context Map in JSONLayout

2014-05-16 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13999896#comment-13999896 ] Ralph Goers commented on LOG4J2-623: Gary, I would not be in favor of making Jackson a

Re: Getting some failing tests in log4j-core

2014-05-16 Thread Gary Gregory
See my separate thread on an picking import set of rules we can all use in our IDEs. Let pick something and then do an organize imports. Gary Original message From: Remko Popma Date:05/16/2014 09:36 (GMT-05:00) To: Log4J Developers List Subject: Re: Getting some failing t

Re: Porting from v1 LoggerRepository

2014-05-16 Thread Ralph Goers
Let me rephrase. If you needed access to the LoggerRepository I would like to know why so that we can make sure you don’t need access to the LoggerContext in Log4j 2. Ralph On May 16, 2014, at 9:07 AM, Ralph Goers wrote: > I have no idea what you mean by “port”. If you are accessing the > L

[jira] [Updated] (LOG4J2-636) IOException: Stream Closed RollingRandomAccessFile

2014-05-16 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-636?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Remko Popma updated LOG4J2-636: --- Description: After some time, RollingRandomAccessFile can no longer write logging events (have not r

Re: Log4J-2.0 New Logo

2014-05-16 Thread Ralph Goers
Good question. Someone needs to start a vote thread. But will we be voting for only our top pick, top 3 or 4 or what? Ralph On May 15, 2014, at 9:15 AM, Gary Gregory wrote: > So... what are we doing here? > > Gary > > > On Wed, May 14, 2014 at 9:43 AM, Ralph Goers wrote: > > > On May 1

Re: Getting some failing tests in log4j-core

2014-05-16 Thread Remko Popma
It was caused by the package rename from core.helpers to core.util: The Loader class is in package core.util, but the package of this test is still core.helpers. The inner class MyClock is package protected, so invisible to the Loader class. Fixed by moving all tests in core.helpers to core.util.

[jira] [Commented] (LOG4J2-623) Better structure of Thread Context Map in JSONLayout

2014-05-16 Thread Joern Huxhorn (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13999867#comment-13999867 ] Joern Huxhorn commented on LOG4J2-623: -- @Ralph Ah, I see. I wasn't aware that JSON co

Re: svn commit: r1593125 - in /logging/log4j/log4j2/trunk/log4j-api/src/main/java/org/apache/logging/log4j: ThreadContext.java spi/ThreadContextStack.java

2014-05-16 Thread Gary Gregory
All of the ThreadContextStack implementations we have are Collections though... (that was the case before the refactoring) Gary On Thu, May 15, 2014 at 11:19 AM, Ralph Goers wrote: > I actually dislike ThreadContextStack but it is there for compatibility > with Log4j 1.x. I guess there are peo

[jira] [Commented] (LOG4J2-623) Better structure of Thread Context Map in JSONLayout

2014-05-16 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13999223#comment-13999223 ] Ralph Goers commented on LOG4J2-623: While I agree in principal, what is awkward about

Re: Log4j 2 plugin to Liquibase

2014-05-16 Thread Mikael Ståldal
I can do that, but I wonder if the current state of the API is expected to be stable from now till the 2.0 GA release? On Wed, May 14, 2014 at 8:21 PM, Gary Gregory wrote: > Time to create a Jira and attach a patch for a new module then. > > Will you be able to maintain it? > > Gary > > > --

[jira] [Updated] (LOG4J2-638) Log4j2 JMX: getConfigText in LoggerContext is not working as documented

2014-05-16 Thread Mansoor Sajjad (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mansoor Sajjad updated LOG4J2-638: -- Description: I am trying to configure log4j2 to access the loggers via JMX and change their lo

[jira] [Commented] (LOG4J2-623) Better structure of Thread Context Map in JSONLayout

2014-05-16 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13999824#comment-13999824 ] Gary Gregory commented on LOG4J2-623: - Another path would be to redo XML and JSON conf

Re: JSON and XML tag format for log events

2014-05-16 Thread Gary Gregory
On Thu, May 15, 2014 at 9:20 AM, Ralph Goers wrote: > Thanks, that looks much better. > YW :) GG > > Sent from my iPad > > On May 14, 2014, at 2:30 PM, Gary Gregory wrote: > > In SVN, see http://pastebin.com/7Tkichnf > > For a FooArray element, the array items are FooArrayItem. > > I will fix

Porting from v1 LoggerRepository

2014-05-16 Thread Gary Gregory
What is the recommend way to port from version 1 LoggerRepository? I'm back to looking at our app server and that's were I'm currently stuck. Gary -- E-Mail: garydgreg...@gmail.com | ggreg...@apache.org Java Persistence with Hibernate, Second Edition JUnit in Act

[jira] [Updated] (LOG4J2-638) Log4j2 JMX: getConfigText in LoggerContext is not working as documented

2014-05-16 Thread Mansoor Sajjad (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mansoor Sajjad updated LOG4J2-638: -- Description: I am trying to configure log4j2 to access the loggers via JMX and change their lo

Re: Log4J-2.0 New Logo

2014-05-16 Thread Gary Gregory
So... what are we doing here? Gary On Wed, May 14, 2014 at 9:43 AM, Ralph Goers wrote: > > > On May 14, 2014, at 4:04 AM, "Christian Grobmeier" > wrote: > > > >> On 14 May 2014, at 8:52, Ralph Goers wrote: > >> > >> Yes the Jira outlines a process that was proposed by Christian in the > Jira

[jira] [Updated] (LOG4J2-638) Log4j2 JMX: getConfigText in LoggerContext is not working as documented

2014-05-16 Thread Mansoor Sajjad (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mansoor Sajjad updated LOG4J2-638: -- Description: I am trying to configure log4j2 to access the loggers via JMX and change their lo

Re: svn commit: r1593125 - in /logging/log4j/log4j2/trunk/log4j-api/src/main/java/org/apache/logging/log4j: ThreadContext.java spi/ThreadContextStack.java

2014-05-16 Thread Gary Gregory
It's also hard to think of a "stack" as _not_ being a "collection". This is a good time to talk about it since we'll be stuck with it when we ship 2.0. Also I could understand why we would not want a java.util.Stack since it is a Vector, but Java offers ArrayDeque. So why not use that? Gary On

Re: svn commit: r1593125 - in /logging/log4j/log4j2/trunk/log4j-api/src/main/java/org/apache/logging/log4j: ThreadContext.java spi/ThreadContextStack.java

2014-05-16 Thread Mikael Ståldal
If implementing java.util.Collection is inconvenient, you could use java.lang.Iterable instead. On Thu, May 15, 2014 at 6:24 AM, Remko Popma wrote: > Well, the difference is that now the api (the ThreadContext.ContextStack > interface) extends Collection, so all implementations now *must* suppo

Re: I think I've got a possible use for log4j-streams.

2014-05-16 Thread Gary Gregory
There are other non-JDK APIs that take streams for debugging. I can't recall one ATM, but I've run into it. I thought we already could capture Sys err and Sys out and redirect that to our core? Gary On Thu, May 8, 2014 at 8:55 PM, Matt Sicker wrote: > These are just from the JDK: > > javax.sq

Re: Log4j 2 plugin to Liquibase

2014-05-16 Thread Gary Gregory
On Thu, May 15, 2014 at 5:39 AM, Mikael Ståldal < mikael.stal...@appearnetworks.com> wrote: > Yes, this is currently based on 2.0-rc1. > You'd better check out trunk, adjust and build against that... Gary > > On Wed, May 14, 2014 at 6:55 PM, Matt Sicker wrote: > >> Looks like you'll have to u

Re: Getting some failing tests in log4j-core

2014-05-16 Thread Ralph Goers
i have lots more failing tests than that, although I don’t see the PatternParserTest failure ClockFactoryTest.testCustomClock:82 expected: but was: ThrowableProxyTest.testJsonIoContainer:52 expected: org.apache.logging.log4j.core.impl.ThrowableProxy but was: org.apache.logging.log4j.core.im

Re: JSON and XML tag format for log events

2014-05-16 Thread Ralph Goers
Thanks, that looks much better. Sent from my iPad > On May 14, 2014, at 2:30 PM, Gary Gregory wrote: > > In SVN, see http://pastebin.com/7Tkichnf > > For a FooArray element, the array items are FooArrayItem. > > I will fix the ContextMap's "item" name later. > > Gary > > >> On Wed, May 14,

Re: svn commit: r1593125 - in /logging/log4j/log4j2/trunk/log4j-api/src/main/java/org/apache/logging/log4j: ThreadContext.java spi/ThreadContextStack.java

2014-05-16 Thread Ralph Goers
I actually dislike ThreadContextStack but it is there for compatibility with Log4j 1.x. I guess there are people who use it. I didn’t make it a Collection in the first place for the exact reasons you mention - they aren’t used. Ralph On May 14, 2014, at 9:24 PM, Remko Popma wrote: > Well, t

[jira] [Commented] (LOG4J2-623) Better structure of Thread Context Map in JSONLayout

2014-05-16 Thread Matt Sicker (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13999290#comment-13999290 ] Matt Sicker commented on LOG4J2-623: You're just supposed to add jackson-databind to y

[jira] [Created] (LOG4J2-638) Log4j2 JMX: getConfigText in LoggerContext is not working as documented

2014-05-16 Thread Mansoor Sajjad (JIRA)
Mansoor Sajjad created LOG4J2-638: - Summary: Log4j2 JMX: getConfigText in LoggerContext is not working as documented Key: LOG4J2-638 URL: https://issues.apache.org/jira/browse/LOG4J2-638 Project: Log4

[jira] [Updated] (LOG4J2-638) Log4j2 JMX: getConfigText in LoggerContext is not working as documented

2014-05-16 Thread Mansoor Sajjad (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mansoor Sajjad updated LOG4J2-638: -- Description: I am trying to configure log4j2 to access the loggers via JMX and change their lo

[jira] [Commented] (LOG4J2-636) IOException: Stream Closed RollingRandomAccessFile

2014-05-16 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13998855#comment-13998855 ] Remko Popma commented on LOG4J2-636: Could you post your full configuration? Also, doe

[jira] [Updated] (LOG4J2-638) Log4j2 JMX: getConfigText in LoggerContext is not working as documented

2014-05-16 Thread Mansoor Sajjad (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mansoor Sajjad updated LOG4J2-638: -- Description: I am trying to configure log4j2 to access the loggers via JMX and change their lo