Re: JMH for log4j microbenchmarks

2014-05-24 Thread Ralph Goers
This is a very good idea. You really don't have a lot to worry about. ASF projects can use GPL tools to build or do things like you are suggesting. However, we can't ship things that are under the GPL and should not commit them to svn. From what you are describing I don't think we would be doin

Re: Clean up org.apache.logging.log4j.Marker.getParent()

2014-05-24 Thread Matt Sicker
Looking forward to the new work! ;) On 19 May 2014 22:40, Bruce Brouwer wrote: > Give me commit rights and I'll do it. (I believe that is in the works) > > > On Sun, May 18, 2014 at 9:31 PM, Gary Gregory wrote: > >> Any volunteers to remove org.apache.logging.log4j.Marker.getParent() ? >> :-) >

Re: Possible NPEs in org.apache.logging.log4j.core.layout.PatternLayout

2014-05-24 Thread Matt Sicker
I added a createDefaultLayout() method to PatternLayout, but I don't think I addressed the header/footer concern. I did, however, replace all those calls to createLayout() with a bunch of null values as part of the migration to typed parameters in factory methods. On 20 May 2014 22:55, Gary Grego

[jira] [Created] (LOG4J2-653) Add plugin builder classes as alternative to factory methods.

2014-05-24 Thread Matt Sicker (JIRA)
Matt Sicker created LOG4J2-653: -- Summary: Add plugin builder classes as alternative to factory methods. Key: LOG4J2-653 URL: https://issues.apache.org/jira/browse/LOG4J2-653 Project: Log4j 2 Is

[jira] [Resolved] (LOG4J2-652) Add plugin annotation for default values

2014-05-24 Thread Matt Sicker (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Sicker resolved LOG4J2-652. Resolution: Implemented Fix Version/s: 2.0-rc2 Added the basic support by r1597368. Still ne

[jira] [Resolved] (LOG4J2-598) Support more data types in plugin attributes

2014-05-24 Thread Matt Sicker (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Sicker resolved LOG4J2-598. Resolution: Implemented Fix Version/s: 2.0-rc2 Feature has been added. As of r1597368, this

Re: svn commit: r1597311 - /logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/impl/Log4jLogEvent.java

2014-05-24 Thread Remko Popma
That's what I thought but unfortunately it doesn't work that way: the deserialization itself fails with a ClassDefNotFound... So the receiver just gets that error. I thought the error would occur when receiver accessed the throwable but it is before that. I've added junit tests for this now. Y

Re: svn commit: r1597291 - in /logging/log4j/log4j2/trunk: log4j-core/src/main/java/org/apache/logging/log4j/core/appender/rewrite/ log4j-core/src/main/java/org/apache/logging/log4j/core/impl/ log4j-c

2014-05-24 Thread Remko Popma
No, I had to add these tests. They are a bit awkward, as it involves creating a serialized event and then deleting the exception class and testing... Sent from my iPhone > On 2014/05/25, at 4:03, Gary Gregory wrote: > > Did the commit break a unit test then. > > Gary > > > Original

Fwd: svn commit: r1597311 - /logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/impl/Log4jLogEvent.java

2014-05-24 Thread Gary Gregory
That does not seem quite right to me. Why not let the throwable be serialized and let the receiving end decides whether or not it should catch the error if the throwable class is not present. Then this leaves the opportunity to the receiver to use the throwable if present otherwise it can use th

Re: Cool plugin typed rework

2014-05-24 Thread Gary Gregory
The not breaking is the key part! ;-) Gary Original message From: Matt Sicker Date:05/24/2014 14:30 (GMT-05:00) To: Log4J Developers List Subject: Re: Cool plugin typed rework Yeah, I'm slowly working on porting things while making sure nothing breaks. So far so good.

Re: Cool plugin typed rework

2014-05-24 Thread Matt Sicker
Yeah, I'm slowly working on porting things while making sure nothing breaks. So far so good. On 23 May 2014 21:00, Gary Gregory wrote: > Matt, > > Do you plan on reworking all the plugins, like all the appenders? > > Gary > > -- > E-Mail: garydgreg...@gmail.com | ggreg...@apache.org > Java Pers

JMH for log4j microbenchmarks

2014-05-24 Thread Remko Popma
I've been using JMH (http://openjdk.java.net/projects/code-tools/jmh/ ) for performance tests recently and I'm very impressed. JMH is developed by the Oracle java performance team and used internally by Oracle to performance tune the JVM and java core libraries. I would like to use JMH to start bu

[jira] [Comment Edited] (LOG4J2-250) (TBD) Refactor Log4jLogEvent to lazily create ThrowableProxy

2014-05-24 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14008138#comment-14008138 ] Remko Popma edited comment on LOG4J2-250 at 5/24/14 4:53 PM: -

[jira] [Commented] (LOG4J2-250) (TBD) Refactor Log4jLogEvent to lazily create ThrowableProxy

2014-05-24 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14008138#comment-14008138 ] Remko Popma commented on LOG4J2-250: Additional fix in revision 1597311 (made Throwabl

Re: svn commit: r1597291 - in /logging/log4j/log4j2/trunk: log4j-core/src/main/java/org/apache/logging/log4j/core/appender/rewrite/ log4j-core/src/main/java/org/apache/logging/log4j/core/impl/ log4j-c

2014-05-24 Thread Ralph Goers
I think this breaks serialization - the fix I did for LOG4J2-542. The Throwable must be volatile as it may not exist on the remote system, so you cannot rely on it for deserialization. Sent from my iPad > On May 24, 2014, at 6:54 AM, rpo...@apache.org wrote: > > Author: rpopma > Date: Sat May

[jira] [Resolved] (LOG4J2-250) (TBD) Refactor Log4jLogEvent to lazily create ThrowableProxy

2014-05-24 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Remko Popma resolved LOG4J2-250. Resolution: Fixed Fix Version/s: 2.0-rc2 Fixed in revision 1597291. JMH performance test sh

[jira] [Resolved] (LOG4J2-647) Upgrade to Flume 1.5.0

2014-05-24 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory resolved LOG4J2-647. - Resolution: Fixed Fix Version/s: 2.0-rc2 {noformat} commit -m "..." C:/vcs/svn/apache/log