Re: [VOTE] Log4j 2.0-rc2 candidate 1

2014-06-24 Thread Remko Popma
I think it's parallel in the api module but not in core. AFAIK Core needs more work before its tests can be run in parallel. Sent from my iPhone > On 2014/06/25, at 14:07, Gary Gregory wrote: > > Now that I running tests over and over, I am wondering if the error I saw was > due to Surefire

Re: [VOTE] Log4j 2.0-rc2 candidate 1

2014-06-24 Thread Gary Gregory
Now that I running tests over and over, I am wondering if the error I saw was due to Surefire trying to run tests in parallel. Didn't we turn on parallel tests recently? Or was that just an experiment I seem to recall? Gary On Wed, Jun 25, 2014 at 12:10 AM, Gary Gregory wrote: > I think I fixe

[RESULT][VOTE] Log4j 2.0-rc2 candidate 1

2014-06-24 Thread Ralph Goers
The vote passes with +1s from Remko Popma, Gary Gregory and Ralph Goers along with a non-binding +1 from Matt Sicker. I will proceed with the rest of the release process shortly. Ralph - To unsubscribe, e-mail: log4j-dev-unsubsc

Finding free ports

2014-06-24 Thread Gary Gregory
We have two ways of finding free socket ports: - org.apache.logging.log4j.test.AvailablePortFinder has been around for a while, and - org.apache.logging.log4j.core.net.FreePortFinder which is a new class I refactored out of a bunch of duplicate code in the Flume tests. We need to pick on way of d

org.apache.logging.log4j.core.util.Closer.closeSilent()

2014-06-24 Thread Gary Gregory
I just found a bunch of handy org.apache.logging.log4j.core.util.Closer.closeSilent() methods, very nice, I just reused one in a test. BUT these should be called IMO closeSilently(). They also should be varargs methinks. Gary -- E-Mail: garydgreg...@gmail.com | ggreg...@apache.org Java Persiste

Re: [VOTE] Log4j 2.0-rc2 candidate 1

2014-06-24 Thread Gary Gregory
I think I fixed that in SVN now, the failing test was NOT using a dynamic port. I'd appreciate a code review/sanity check from Ralph or someone familiar with the Flume tests. Thank you, Gary On Tue, Jun 24, 2014 at 11:59 PM, Gary Gregory wrote: > +1 > > But let's keep talking about the interm

Re: [VOTE] Log4j 2.0-rc2 candidate 1

2014-06-24 Thread Gary Gregory
+1 But let's keep talking about the intermittent Flume test failures which could be a test issue on busy machines. Gary On Tue, Jun 24, 2014 at 11:30 PM, Ralph Goers wrote: > Probably not timing related. You got “no flume agents”. That probably > means the port it tried to listen on was not a

Re: [VOTE] Log4j 2.0-rc2 candidate 1

2014-06-24 Thread Gary Gregory
Where is the dynamic port allocation performed in org.apache.logging.log4j.flume.appender.FlumeAppenderTest? This looks hard wired: private static final int testServerPort = 12345; But I did not look too deep. Gary On Tue, Jun 24, 2014 at 11:30 PM, Ralph Goers wrote: > Probably not timing r

Re: [VOTE] Log4j 2.0-rc2 candidate 1

2014-06-24 Thread Ralph Goers
Probably not timing related. You got “no flume agents”. That probably means the port it tried to listen on was not available for some reason. I’m not sure why that would happen since the tests try to dynamically acquire ports, but that logic might be flawed. In any case, since it re-ran I doub

Re: [VOTE] Log4j 2.0-rc2 candidate 1

2014-06-24 Thread Gary Gregory
Weird, now I re-ran 'mvn clean test' with Maven 3.2.1 instead of 3.0.5 and all went well. I wonder if my machine was too busy doing doing stuff when I saw the failure... Any thoughts on the Flume tests being dependent on timing? Gary On Tue, Jun 24, 2014 at 10:12 PM, Gary Gregory wrote: > ah

Re: [VOTE] Log4j 2.0-rc2 candidate 1

2014-06-24 Thread Gary Gregory
ah, but it does eventually complete: 2014-06-24 22:11:06,683 INFO Log4j appears to be running in a Servlet environment, but there's no log4j-web module available. If you want better web container support, please add the log4j-web JAR to your web archive or server lib directory . 2014-06-24 22:11:0

Re: [VOTE] Log4j 2.0-rc2 candidate 1

2014-06-24 Thread Gary Gregory
With the src zip, I am seeing: Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 53.732 sec - in org.apache.logging.log4j.flume.appender.FlumeEmbeddedAgentTest Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 54.021 sec - in org.apache.logging.log4j.flume.appender.Flum

[jira] [Created] (LOG4J2-680) Build fails on Java 8

2014-06-24 Thread Gary Gregory (JIRA)
Gary Gregory created LOG4J2-680: --- Summary: Build fails on Java 8 Key: LOG4J2-680 URL: https://issues.apache.org/jira/browse/LOG4J2-680 Project: Log4j 2 Issue Type: Bug Environment: Apa

Re: Vagrantfile

2014-06-24 Thread Ralph Goers
Yeah, I don’t see any admin functions when i am logged in so I must not be able to do it. Ralph On Jun 24, 2014, at 4:24 PM, Remko Popma wrote: > I vaguely recall I had the same issue when selecting a logo, and Christian > gave me edit rights. > > Sent from my iPhone > > On 2014/06/25, at

Re: Vagrantfile

2014-06-24 Thread Remko Popma
I vaguely recall I had the same issue when selecting a logo, and Christian gave me edit rights. Sent from my iPhone > On 2014/06/25, at 3:39, Matt Sicker wrote: > > I created a user, but all the pages are immutable. > > >> On 24 June 2014 11:46, Ralph Goers wrote: >> If I recall correctly

Re: Vagrantfile

2014-06-24 Thread Matt Sicker
I created a user, but all the pages are immutable. On 24 June 2014 11:46, Ralph Goers wrote: > If I recall correctly all you need to do is create a user on the logging > wiki. I believe everyone can edit once they have a valid userid. Did you do > that? > > Ralph > > On Jun 21, 2014, at 5:57 PM

Re: [VOTE] Log4j 2.0-rc2 candidate 1

2014-06-24 Thread Christian Grobmeier
Haven't reviewed yet - would be great if there this one would make it without my vote (trouble to solve). However if there is nobody available for review, i am going to do that On 24 Jun 2014, at 2:59, Ralph Goers wrote: +1 from me too. We still need another +1 from a PMC member. Ralph On J

Re: Vagrantfile

2014-06-24 Thread Ralph Goers
If I recall correctly all you need to do is create a user on the logging wiki. I believe everyone can edit once they have a valid userid. Did you do that? Ralph On Jun 21, 2014, at 5:57 PM, Ralph Goers wrote: > I will see if I have rights to fix that when I get home > > Sent from my iPhone >

[jira] [Commented] (LOG4J2-323) ThreadLocal-leak on tomcat shutdown when using async logging

2014-06-24 Thread Ilya Tepikin (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14042333#comment-14042333 ] Ilya Tepikin commented on LOG4J2-323: - I'm using RC1, but I tried this also with RC2 s

[jira] [Commented] (LOG4J2-323) ThreadLocal-leak on tomcat shutdown when using async logging

2014-06-24 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14042297#comment-14042297 ] Ralph Goers commented on LOG4J2-323: Interesting. The only conclusion I can come to is

[jira] [Commented] (LOG4J2-323) ThreadLocal-leak on tomcat shutdown when using async logging

2014-06-24 Thread Ilya Tepikin (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14042267#comment-14042267 ] Ilya Tepikin commented on LOG4J2-323: - {code}

[jira] [Comment Edited] (LOG4J2-679) Log rotation partly failed with error: "Unable to create directory ..."

2014-06-24 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14042262#comment-14042262 ] Ralph Goers edited comment on LOG4J2-679 at 6/24/14 3:41 PM: -

[jira] [Commented] (LOG4J2-679) Log rotation partly failed with error: "Unable to create directory ..."

2014-06-24 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14042262#comment-14042262 ] Ralph Goers commented on LOG4J2-679: Unfortunately, File.mkdirs returns no information

[jira] [Comment Edited] (LOG4J2-679) Log rotation partly failed with error: "Unable to create directory ..."

2014-06-24 Thread Rene Schoenlein (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14042187#comment-14042187 ] Rene Schoenlein edited comment on LOG4J2-679 at 6/24/14 3:32 PM: ---

[jira] [Commented] (LOG4J2-323) ThreadLocal-leak on tomcat shutdown when using async logging

2014-06-24 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14042248#comment-14042248 ] Ralph Goers commented on LOG4J2-323: Can you show the configuration of the Appender?

[jira] [Commented] (LOG4J2-679) Log rotation partly failed with error: "Unable to create directory ..."

2014-06-24 Thread Rene Schoenlein (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14042187#comment-14042187 ] Rene Schoenlein commented on LOG4J2-679: I am pretty convinced now that this is mo

[jira] [Created] (LOG4J2-679) Log rotation partly failed with error: "Unable to create directory ..."

2014-06-24 Thread Rene Schoenlein (JIRA)
Rene Schoenlein created LOG4J2-679: -- Summary: Log rotation partly failed with error: "Unable to create directory ..." Key: LOG4J2-679 URL: https://issues.apache.org/jira/browse/LOG4J2-679 Project: Lo

[jira] [Commented] (LOG4J2-323) ThreadLocal-leak on tomcat shutdown when using async logging

2014-06-24 Thread Ilya Tepikin (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14042104#comment-14042104 ] Ilya Tepikin commented on LOG4J2-323: - Remko, I have {code} Log4jContex

[jira] [Commented] (LOG4J2-441) logger level configuration does not work correct

2014-06-24 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14041971#comment-14041971 ] Ralph Goers commented on LOG4J2-441: This change, when I commit it, won't be in rc2. T