Fwd: logging-log4j2 git commit: Clarified which methods are performance-sensitive.

Nice: +// Profiling showed this method is important to log4j performance. Modify with care! // 33 bytes (allows immediate JVM inlining: < 35 bytes) LOG4J2-1096 Maybe: // Profiling showed this method is important to log4j performance. Modify with care! + // See FooBenchmark class.

Fwd: logging-log4j2 git commit: LOG4J2-1097 initial version of CustomTimeFormat

I can't say I'm in love with the "2" postfix on the names. How about ABSOLUTE2 -> ABSOLUTE_PERIOD, and so on? WRT: // 28 bytes (allows immediate JVM inlining: < 35 bytes) This is much better, thank you. I would add what version and vendor this is based on, maybe like: // 28 bytes (allows immed

[jira] [Commented] (LOG4J2-1096) Performance improvement for PatternMessage.format

[ https://issues.apache.org/jira/browse/LOG4J2-1096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14706252#comment-14706252 ] Ralph Goers commented on LOG4J2-1096: - That is a very good idea. I think documenting

[jira] [Commented] (LOG4J2-1096) Performance improvement for PatternMessage.format

[ https://issues.apache.org/jira/browse/LOG4J2-1096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14706237#comment-14706237 ] Remko Popma commented on LOG4J2-1096: - Good idea! The performance improvements I am

Re: logging-log4j2 git commit: LOG4J2-1096 bugfix and additional unit test for case where one or more arguments is null

I agree. I made some changes clarifying that (a) this is a performance sensitive method, and (b) why the method size is important and (c) linked to the Jira containing the performance measurements. Note that I don't intend to do this with all methods. :-) Only places where profiling shows that log

[jira] [Commented] (LOG4J2-1097) [Perf] Custom TimeFormat

[ https://issues.apache.org/jira/browse/LOG4J2-1097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14706200#comment-14706200 ] Remko Popma commented on LOG4J2-1097: - I committed an initial version of CustomDateFo

[jira] [Commented] (LOG4J2-752) Log4J2 not finding core Log4J2Plugins.dat when a custom appender is present

[ https://issues.apache.org/jira/browse/LOG4J2-752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14705902#comment-14705902 ] Zachary Boe commented on LOG4J2-752: And just like that I found a solution (workaround

[jira] [Comment Edited] (LOG4J2-752) Log4J2 not finding core Log4J2Plugins.dat when a custom appender is present

[ https://issues.apache.org/jira/browse/LOG4J2-752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14705826#comment-14705826 ] Zachary Boe edited comment on LOG4J2-752 at 8/20/15 9:48 PM: -

[jira] [Commented] (LOG4J2-752) Log4J2 not finding core Log4J2Plugins.dat when a custom appender is present

[ https://issues.apache.org/jira/browse/LOG4J2-752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14705826#comment-14705826 ] Zachary Boe commented on LOG4J2-752: Upon further inspection (and a year later), I've

Re: Jenkins build became unstable: Log4j 2.x #1302

Oh. I don’t know that that will fix the random failures then. Ralph > On Aug 20, 2015, at 11:52 AM, Remko Popma wrote: > > This problem was caused by my ParameterizedMessage changes not handling null > parameters. Now fixed in master. > > Sent from my iPhone > > On 2015/08/21, at 2:02, Ralp

Re: Jenkins build became unstable: Log4j 2.x #1302

This problem was caused by my ParameterizedMessage changes not handling null parameters. Now fixed in master. Sent from my iPhone > On 2015/08/21, at 2:02, Ralph Goers wrote: > > Really? What is it? It has been failing every other build for quite a while. > > Ralph > >> On Aug 20, 2015, at

[jira] [Commented] (LOG4J2-1099) AbstractStringLayout implements Serializable, but is not Serializable

[ https://issues.apache.org/jira/browse/LOG4J2-1099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14705490#comment-14705490 ] Louis Burton commented on LOG4J2-1099: -- Thanks for responding Gary, We'll look to c

[jira] [Commented] (LOG4J2-1099) AbstractStringLayout implements Serializable, but is not Serializable

[ https://issues.apache.org/jira/browse/LOG4J2-1099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14705439#comment-14705439 ] Gary Gregory commented on LOG4J2-1099: -- Louis, Thank you for your report. The TODO

[jira] [Created] (LOG4J2-1099) AbstractStringLayout implements Serializable, but is not Serializable

Louis Burton created LOG4J2-1099: Summary: AbstractStringLayout implements Serializable, but is not Serializable Key: LOG4J2-1099 URL: https://issues.apache.org/jira/browse/LOG4J2-1099 Project: Log4j

Re: Jenkins build became unstable: Log4j 2.x #1302

Really? What is it? It has been failing every other build for quite a while. Ralph > On Aug 20, 2015, at 9:06 AM, Remko Popma wrote: > > I found the problem and I'm fixing this now. > > On Thu, Aug 20, 2015 at 11:01 PM, Apache Jenkins Server > mailto:[email protected]>> wrote: > See <

What is the name in org.apache.logging.log4j.core.config.Configurator.initialize(String, String)

It's not clear to me what the point of having a name for org.apache.logging.log4j.core.config.Configurator.initialize(String, String) does. When I follow the code, it does not seem to be used. What am I missing? Thank you, Gary -- E-Mail: [email protected] | [email protected] Java Persi

Jenkins build is back to stable : Log4j 2.x #1303

See - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]

[jira] [Commented] (LOG4J2-1096) Performance improvement for PatternMessage.format

[ https://issues.apache.org/jira/browse/LOG4J2-1096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14705247#comment-14705247 ] Gary Gregory commented on LOG4J2-1096: -- It would be great to update our site/FAQ for

Fwd: logging-log4j2 git commit: LOG4J2-1096 bugfix and additional unit test for case where one or more arguments is null

I think we need better comments than: // 30 bytes Think of what someone checking out the code would think and then do to modify the code. At the very minimum a URL to the Jira issue is required. Gary -- Forwarded message -- From: Date: Thu, Aug 20, 2015 at 9:13 AM Subject: logg

Re: Jenkins build became unstable: Log4j 2.x #1302

I found the problem and I'm fixing this now. On Thu, Aug 20, 2015 at 11:01 PM, Apache Jenkins Server < [email protected]> wrote: > See > > > - > To unsubscribe, e-m

Jenkins build became unstable: Log4j 2.x #1302

See - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]

[jira] [Resolved] (LOG4J2-1096) Performance improvement for PatternMessage.format

[ https://issues.apache.org/jira/browse/LOG4J2-1096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Remko Popma resolved LOG4J2-1096. - Resolution: Fixed Fixed in git master in commit 8124d9b0. Added JUnit tests, and updated Paramet

[jira] [Updated] (LOG4J2-1098) log4j.shutdownHookEnabled=false from log4j-web ignored?

[ https://issues.apache.org/jira/browse/LOG4J2-1098?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robin Jansohn updated LOG4J2-1098: -- Description: In the documentation it says for the System Property 'log4j.shutdownHookEnabled':

[jira] [Updated] (LOG4J2-1098) log4j.shutdownHookEnabled=false from log4j-web ignored?

[ https://issues.apache.org/jira/browse/LOG4J2-1098?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robin Jansohn updated LOG4J2-1098: -- Description: In the documentation it says for the System Property 'log4j.shutdownHookEnabled':

[jira] [Created] (LOG4J2-1098) log4j.shutdownHookEnabled=false from log4j-web ignored?

Robin Jansohn created LOG4J2-1098: - Summary: log4j.shutdownHookEnabled=false from log4j-web ignored? Key: LOG4J2-1098 URL: https://issues.apache.org/jira/browse/LOG4J2-1098 Project: Log4j 2 I