[
https://issues.apache.org/jira/browse/LOG4J2-1271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15149988#comment-15149988
]
Remko Popma edited comment on LOG4J2-1271 at 2/17/16 7:54 AM:
-
[
https://issues.apache.org/jira/browse/LOG4J2-1271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15149988#comment-15149988
]
Remko Popma commented on LOG4J2-1271:
-
* postpone creating the formatted message unti
[
https://issues.apache.org/jira/browse/LOG4J2-1271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15149949#comment-15149949
]
Ralph Goers edited comment on LOG4J2-1271 at 2/17/16 5:56 AM:
-
[
https://issues.apache.org/jira/browse/LOG4J2-1271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15149949#comment-15149949
]
Ralph Goers commented on LOG4J2-1271:
-
The way I would prefer to handle this is to no
[
https://issues.apache.org/jira/browse/LOG4J2-1270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15149767#comment-15149767
]
Remko Popma commented on LOG4J2-1270:
-
You are right: this won't work for arbitrary M
[
https://issues.apache.org/jira/browse/LOG4J2-1271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15149759#comment-15149759
]
Remko Popma commented on LOG4J2-1271:
-
I see your point. The thing is, why are we cur
[
https://issues.apache.org/jira/browse/LOG4J2-1274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Remko Popma reassigned LOG4J2-1274:
---
Assignee: Remko Popma
> Layout improvements to enable avoiding temporary object allocation
>
[
https://issues.apache.org/jira/browse/LOG4J2-1274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15149735#comment-15149735
]
Remko Popma commented on LOG4J2-1274:
-
Thanks for the feedback, everyone. I think nob
[
https://issues.apache.org/jira/browse/LOG4J2-1278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15149653#comment-15149653
]
Ralph Goers commented on LOG4J2-1278:
-
Of all of these I like the "LevelLogger" the b
[
https://issues.apache.org/jira/browse/LOG4J2-1274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15149628#comment-15149628
]
Ralph Goers commented on LOG4J2-1274:
-
This seems reasonable to me.
> Layout improve
[
https://issues.apache.org/jira/browse/LOG4J2-1274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15149625#comment-15149625
]
Ralph Goers commented on LOG4J2-1274:
-
There is no way to know, but this was a featur
[
https://issues.apache.org/jira/browse/LOG4J2-1274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15149616#comment-15149616
]
Ralph Goers commented on LOG4J2-1274:
-
I am fine with this.
> Layout improvements to
[
https://issues.apache.org/jira/browse/LOG4J2-1274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ralph Goers updated LOG4J2-1274:
Comment: was deleted
(was: If you add it to the interface I would hope the method could be added to
[
https://issues.apache.org/jira/browse/LOG4J2-1274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15149615#comment-15149615
]
Ralph Goers commented on LOG4J2-1274:
-
If you add it to the interface I would hope th
[
https://issues.apache.org/jira/browse/LOG4J2-1271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15149599#comment-15149599
]
Ralph Goers edited comment on LOG4J2-1271 at 2/17/16 12:46 AM:
[
https://issues.apache.org/jira/browse/LOG4J2-1271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15149599#comment-15149599
]
Ralph Goers commented on LOG4J2-1271:
-
I believe the first 2 bullets are being done t
[
https://issues.apache.org/jira/browse/LOG4J2-1270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15149594#comment-15149594
]
Ralph Goers edited comment on LOG4J2-1270 at 2/17/16 12:39 AM:
[
https://issues.apache.org/jira/browse/LOG4J2-1270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15149594#comment-15149594
]
Ralph Goers commented on LOG4J2-1270:
-
Actually, it occurs to me that you can't use a
[
https://issues.apache.org/jira/browse/LOG4J2-1270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15149589#comment-15149589
]
Remko Popma commented on LOG4J2-1270:
-
The test code is a proof of concept to give ev
[
https://issues.apache.org/jira/browse/LOG4J2-1270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15149573#comment-15149573
]
Ralph Goers edited comment on LOG4J2-1270 at 2/17/16 12:29 AM:
[
https://issues.apache.org/jira/browse/LOG4J2-1270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15149575#comment-15149575
]
Ralph Goers commented on LOG4J2-1270:
-
I don't understand how this works for arbitrar
[
https://issues.apache.org/jira/browse/LOG4J2-1270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15149573#comment-15149573
]
Ralph Goers commented on LOG4J2-1270:
-
Yes it is a big difference. But
Classic u
I don't think Log4J should get into the proxying or weaving business. By
that I mean the framework shouldn't gain the knowledge how to do it. It's a
specialization best deferred to the JDK, Spring, AspectJ, and other tools
that are devoted to the problem space. Rather, Log4J should provide all the
I think a trace should be added for all return statements. If the method
has no return statement, then it just goes at the end. I agree with the
exceptional case Gary mentions as well.
On 16 February 2016 at 16:55, Gary Gregory wrote:
> I did not explain myself correctly because I am talking abo
I did not explain myself correctly because I am talking about editing class
files, not java files. Or being part of the byte code generation, however
that works.
Also the trace on finally you describe is a no go for me. I want to *not*
see a trace exit when an exception is thrown.
Gary
On Feb 16,
If it worked that way the annotation processor would have to act as
pre-processor and generate new .java files that would then be compiled. My
expectation is that this functionality would be built into the existing
annotation processor and the logging would be added during the compilation
proce
On Mon, Feb 15, 2016 at 7:58 PM, Paul Benedict wrote:
> You could create special interfaces for these sets of special methods.
> There is not a design rule that says Logger must be the interface that does
> all things.
>
You're right but the current design is a kitchen-sink interface.
If you lo
In my mind, the annotations would cause a build to inject code into class
files using the new traceEntry/Exit APIs. That's the easiest to understand
IMO. It would also generate the simplest code. It also does not force you
into using annotations if you want to "see" the real thing in your code.
Ga
[
https://issues.apache.org/jira/browse/LOG4J2-1270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15149149#comment-15149149
]
Gary Gregory commented on LOG4J2-1270:
--
Wow, that's a big difference!
> Garbage-fre
[
https://issues.apache.org/jira/browse/LOG4J2-1270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15149003#comment-15149003
]
Remko Popma commented on LOG4J2-1270:
-
As requested in LOG4J2-1274 and LOG4J2-1278, I
I'd much prefer the annotation approach.
On 16 February 2016 at 10:35, Ralph Goers
wrote:
> SLF4J created XLogger to do this. I wasn’t really happy with that and so
> added the methods to the Logger class when I started Log4j 2.
>
> The more I think about this I am wondering if the effort should
SLF4J created XLogger to do this. I wasn’t really happy with that and so added
the methods to the Logger class when I started Log4j 2.
The more I think about this I am wondering if the effort shouldn’t just be
spent on implementing the annotations rather than arguing about this stuff. The
anno
I messed up the code example. Sorry. Let all supported logging interfaces
come from an empty marker interface.
public interface LogManager {
T getLogger(Class clz);
}
Cheers,
Paul
On Tue, Feb 16, 2016 at 10:27 AM, Paul Benedict
wrote:
> Maybe it's something worth discussing for version 3.0
Maybe it's something worth discussing for version 3.0 :-) but you could
have something like this:
public interface LogManager {
T getLogger(Class clz);
}
My suggestion is about allowing a "logger" (in the abstract) to be more
than just the definite Logger interface. Having 200-some methods is
Well, you just need one interface: FlowLogger and all traceEntry and
traceExit methods can live there. But that means that a user must hold on
to 2 loggers for a given class for example. Unless FlowLogger extends
Logger. Then you'd also need to add getFlowLogger methods to LogManager.
Which is bet
[
https://issues.apache.org/jira/browse/LOG4J2-1246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15148766#comment-15148766
]
Tony Baines commented on LOG4J2-1246:
-
We deploy nodes across multiple timezones, and
[
https://issues.apache.org/jira/browse/LOG4J2-1274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15148579#comment-15148579
]
Remko Popma commented on LOG4J2-1274:
-
Fair enough, I will create a test.
> Layout i
[
https://issues.apache.org/jira/browse/LOG4J2-1278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15148582#comment-15148582
]
Remko Popma commented on LOG4J2-1278:
-
Makes sense. I will create a test.
> Garbage-
[
https://issues.apache.org/jira/browse/LOG4J2-1274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15148508#comment-15148508
]
Ralph Goers commented on LOG4J2-1274:
-
This issue presupposes that there is a problem
[
https://issues.apache.org/jira/browse/LOG4J2-1278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15148504#comment-15148504
]
Ralph Goers commented on LOG4J2-1278:
-
Before spending time on this it would be great
[
https://issues.apache.org/jira/browse/LOG4J2-506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15146634#comment-15146634
]
Remko Popma edited comment on LOG4J2-506 at 2/16/16 11:37 AM:
--
[
https://issues.apache.org/jira/browse/LOG4J2-1274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15148483#comment-15148483
]
Remko Popma edited comment on LOG4J2-1274 at 2/16/16 11:35 AM:
[
https://issues.apache.org/jira/browse/LOG4J2-1274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15148422#comment-15148422
]
Remko Popma edited comment on LOG4J2-1274 at 2/16/16 11:34 AM:
[
https://issues.apache.org/jira/browse/LOG4J2-1274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15148483#comment-15148483
]
Remko Popma commented on LOG4J2-1274:
-
Actually, given that I want to do something ve
[
https://issues.apache.org/jira/browse/LOG4J2-506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15146634#comment-15146634
]
Remko Popma edited comment on LOG4J2-506 at 2/16/16 11:21 AM:
--
[
https://issues.apache.org/jira/browse/LOG4J2-1278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15148460#comment-15148460
]
Remko Popma edited comment on LOG4J2-1278 at 2/16/16 11:01 AM:
[
https://issues.apache.org/jira/browse/LOG4J2-1278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15148460#comment-15148460
]
Remko Popma commented on LOG4J2-1278:
-
Personally I like option 3 (new LevelLogger in
[
https://issues.apache.org/jira/browse/LOG4J2-1274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15148438#comment-15148438
]
Remko Popma commented on LOG4J2-1274:
-
We don't know: users could have written a cust
[
https://issues.apache.org/jira/browse/LOG4J2-1278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15148425#comment-15148425
]
Remko Popma edited comment on LOG4J2-1278 at 2/16/16 10:38 AM:
[
https://issues.apache.org/jira/browse/LOG4J2-1278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15148425#comment-15148425
]
Remko Popma commented on LOG4J2-1278:
-
True. Doubles and floats will never be cached
[
https://issues.apache.org/jira/browse/LOG4J2-1274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15148422#comment-15148422
]
Remko Popma commented on LOG4J2-1274:
-
StringLayout or AbstractStringLayout, I guess.
[
https://issues.apache.org/jira/browse/LOG4J2-1274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15148410#comment-15148410
]
Mikael Ståldal commented on LOG4J2-1274:
Is anyone actually using this?
> Layout
[
https://issues.apache.org/jira/browse/LOG4J2-1274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15148402#comment-15148402
]
Remko Popma commented on LOG4J2-1274:
-
I could be wrong, but the nice thing about the
[
https://issues.apache.org/jira/browse/LOG4J2-1278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15148391#comment-15148391
]
Mikael Ståldal commented on LOG4J2-1278:
{{byte}} and {{boolean}} are always comp
[
https://issues.apache.org/jira/browse/LOG4J2-1274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15148384#comment-15148384
]
Mikael Ståldal commented on LOG4J2-1274:
Perhaps the {{String toString(LogEvent)}
[
https://issues.apache.org/jira/browse/LOG4J2-1278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15148382#comment-15148382
]
Remko Popma commented on LOG4J2-1278:
-
True, by default Object values between -128 an
[
https://issues.apache.org/jira/browse/LOG4J2-1274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15148383#comment-15148383
]
Mikael Ståldal commented on LOG4J2-1274:
It seems like the only non-{{StringLayou
[
https://issues.apache.org/jira/browse/LOG4J2-1274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15148378#comment-15148378
]
Mikael Ståldal edited comment on LOG4J2-1274 at 2/16/16 10:01 AM:
-
[
https://issues.apache.org/jira/browse/LOG4J2-1274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15148378#comment-15148378
]
Mikael Ståldal commented on LOG4J2-1274:
Cannot we just change JMS Appender then?
[
https://issues.apache.org/jira/browse/LOG4J2-1274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15148374#comment-15148374
]
Remko Popma commented on LOG4J2-1274:
-
It is currently used in the JMS Appender, so l
[
https://issues.apache.org/jira/browse/LOG4J2-1278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15148298#comment-15148298
]
Mikael Ståldal edited comment on LOG4J2-1278 at 2/16/16 9:10 AM:
--
[
https://issues.apache.org/jira/browse/LOG4J2-1278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15148298#comment-15148298
]
Mikael Ståldal commented on LOG4J2-1278:
Do we really need to avoid auto-boxing o
[
https://issues.apache.org/jira/browse/LOG4J2-1274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15148283#comment-15148283
]
Mikael Ståldal commented on LOG4J2-1274:
Yes, having a {{String toString(LogEvent
63 matches
Mail list logo
