[jira] [Closed] (LOG4J2-1343) Update ConsoleAppender to utilize gc-free Layout method

2016-04-13 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Remko Popma closed LOG4J2-1343. --- > Update ConsoleAppender to utilize gc-free Layout method > -

Re: Layout extends Encoder

2016-04-13 Thread Remko Popma
Ralph, After rereading your email I see I may have missed your point. Layout deliberately extends Encoder and not the other way around because Layouts have additional responsibilities like header, footer, content type etc. Remko On Thursday, 14 April 2016, Remko Popma wrote: > I'm actually qui

Re: FileAppender synchronous logging performance

2016-04-13 Thread Remko Popma
Sure. By the way, the previous email had an attachment with the spreadsheet containing the graphs. Can you see if you can open that? I can see what I can do but it'll take a day. Sent from my iPhone > On 2016/04/14, at 3:31, Ralph Goers wrote: > > I’m wondering if you could do me a favor.

Re: Layout extends Encoder

2016-04-13 Thread Remko Popma
I'm actually quite attached to this name. It took several iterations to come up with, I think it's intuitive and descriptive and I'm very happy with this name. I don't see any confusion: Logback's Encoder interface writes the resulting bytes to a stream where log4j 2 writes the resulting bytes

Re: Layout extends Encoder

2016-04-13 Thread Ralph Goers
I am not really sure when the data is written. I suppose it could also be named ByteBufferLayout. Ralph > On Apr 13, 2016, at 12:33 PM, Gary Gregory wrote: > > Just by its name, BufferedLayout sounds like a Layout with an internal buffer > that is flushed once is a while and on close. Is that

Re: Layout extends Encoder

2016-04-13 Thread Gary Gregory
Just by its name, BufferedLayout sounds like a Layout with an internal buffer that is flushed once is a while and on close. Is that what it would be? G On Wed, Apr 13, 2016 at 11:42 AM, Ralph Goers wrote: > I guess I do have one issue with Encoder. Logback essentially replaced > Layout with En

Re: Layout extends Encoder

2016-04-13 Thread Ralph Goers
I guess I do have one issue with Encoder. Logback essentially replaced Layout with Encoder. However, my recollection is that it was done as part of converting to having Layouts write to outputStreams using character encoding. The Encoder interface we have is confusing in that regard as it doesn

Re: FileAppender synchronous logging performance

2016-04-13 Thread Ralph Goers
I’m wondering if you could do me a favor. I am color blind and have a hard time differentiating which graph is which. Can you also incorporate dots or dashes into the lines so I can tell the difference? Ralph > On Apr 13, 2016, at 8:31 AM, Remko Popma wrote: > > On Linux 2.6, using a thread-

[jira] [Commented] (LOG4J2-1365) Add CharSequenceFormattable interface for Messages to improve performance of Layouts

2016-04-13 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15239727#comment-15239727 ] Remko Popma commented on LOG4J2-1365: - I'm not being facetious; I really can't see wh

Jenkins build is back to stable : Log4j 2.x #1868

2016-04-13 Thread Apache Jenkins Server
See - To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org

Re: Jenkins build is still unstable: Log4j 2.x #1867

2016-04-13 Thread Remko Popma
Took 7 minutes! First time I see this one. FlumePersistentAppenderTest.testMultipleConcurrent(FlumePersistentAppenderTest.java:274) Sent from my iPhone > On 2016/04/14, at 2:16, Apache Jenkins Server > wrote: > > See > > > ---

Jenkins build is still unstable: Log4j 2.x #1867

2016-04-13 Thread Apache Jenkins Server
See - To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org

[jira] [Updated] (LOG4J2-1334) Add LogEventFactory that reuses a cached LogEvent for garbage-free synchronous logging

2016-04-13 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Remko Popma updated LOG4J2-1334: Summary: Add LogEventFactory that reuses a cached LogEvent for garbage-free synchronous logging (w

[jira] [Updated] (LOG4J2-1334) Add support for GC-free synchronous logging: reusable LogEvent

2016-04-13 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Remko Popma updated LOG4J2-1334: Summary: Add support for GC-free synchronous logging: reusable LogEvent (was: Add support for GC-f

Re: Layout extends Encoder

2016-04-13 Thread Remko Popma
One usage is the StringBuilderEncoder class I just committed (it implements Encoder). For binary layouts, this still needs more thinking, but log4j could have a registry of custom encoders. Then, when a client logs an Order object we do a lookup, find the Encoder and use that encoder to write the

[jira] [Commented] (LOG4J2-1365) Add CharSequenceFormattable interface for Messages to improve performance of Layouts

2016-04-13 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15239539#comment-15239539 ] Remko Popma commented on LOG4J2-1365: - I am not sure I understand. What problem does

[jira] [Commented] (LOG4J2-1365) Add CharSequenceFormattable interface for Messages to improve performance of Layouts

2016-04-13 Thread JIRA
[ https://issues.apache.org/jira/browse/LOG4J2-1365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15239493#comment-15239493 ] Mikael Ståldal commented on LOG4J2-1365: What do you think [~rem...@yahoo.com]?

[jira] [Commented] (LOG4J2-1329) API change: let Message.getFormattedMessage() return CharSequence instead of String

2016-04-13 Thread JIRA
[ https://issues.apache.org/jira/browse/LOG4J2-1329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15239492#comment-15239492 ] Mikael Ståldal commented on LOG4J2-1329: See https://issues.apache.org/jira/brows

[jira] [Commented] (LOG4J2-1365) Add CharSequenceFormattable interface for Messages to improve performance of Layouts

2016-04-13 Thread JIRA
[ https://issues.apache.org/jira/browse/LOG4J2-1365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15239490#comment-15239490 ] Mikael Ståldal commented on LOG4J2-1365: See branch LOG4J2-1365 in Git. > Add Ch

[jira] [Created] (LOG4J2-1365) Add CharSequenceFormattable interface for Messages to improve performance of Layouts

2016-04-13 Thread JIRA
Mikael Ståldal created LOG4J2-1365: -- Summary: Add CharSequenceFormattable interface for Messages to improve performance of Layouts Key: LOG4J2-1365 URL: https://issues.apache.org/jira/browse/LOG4J2-1365

[jira] [Updated] (LOG4J2-1364) PatternLayout can't put newline in substitution

2016-04-13 Thread Delphin (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Delphin updated LOG4J2-1364: Affects Version/s: 2.5 > PatternLayout can't put newline in substitution >

[jira] [Updated] (LOG4J2-1364) PatternLayout can't put newline in substitution

2016-04-13 Thread Delphin (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Delphin updated LOG4J2-1364: Description: I try this configuration: {noformat} {noformat} And log message like this: {noformat} LOG.err

[jira] [Created] (LOG4J2-1364) PatternLayout can't put newline in substitution

2016-04-13 Thread Delphin (JIRA)
Delphin created LOG4J2-1364: --- Summary: PatternLayout can't put newline in substitution Key: LOG4J2-1364 URL: https://issues.apache.org/jira/browse/LOG4J2-1364 Project: Log4j 2 Issue Type: Bug

Re: Layout extends Encoder

2016-04-13 Thread Mikael Ståldal
How would such an Encoder look like? On Wed, Apr 13, 2016 at 12:40 AM, Remko Popma wrote: > It does break binary compatibility, but since it's log4j-core (not api) > we agreed that this is acceptable here. > > The reason it's a separate super interface is that I plan to have other > Encoder impl