[jira] [Commented] (LOG4J2-1448) Allow comma separated agents, host list to be passed to FlumeAppender

2016-06-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15349088#comment-15349088 ] ASF GitHub Bot commented on LOG4J2-1448: Github user kelaban commented on the iss

[jira] [Updated] (LOG4J2-1447) Garbage-free data structure for LogEvent's context map data

2016-06-24 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Remko Popma updated LOG4J2-1447: Description: With each logging call, context map data is copied from the {{ThreadContext}} map int

[jira] [Updated] (LOG4J2-1447) Garbage-free data structure for LogEvent's context map data

2016-06-24 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Remko Popma updated LOG4J2-1447: Description: With each logging call, context map data is copied from the {{ThreadContext}} map int

[jira] [Commented] (LOG4J2-1010) Injectable context properties

2016-06-24 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15349081#comment-15349081 ] Remko Popma commented on LOG4J2-1010: - Good questions. * I like to see the ContextDa

[jira] [Commented] (LOG4J2-1448) Allow comma separated agents, host list to be passed to FlumeAppender

2016-06-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15349036#comment-15349036 ] ASF GitHub Bot commented on LOG4J2-1448: Github user jvz commented on the issue:

Re: 2.6.2?

2016-06-24 Thread Remko Popma
I noticed that Ralph reopened LOG4J2-1440, but is there anything else that we want to include in the 2.6.2 release? I'm kind of keen to start on some items scheduled for 2.7. :-) Remko Sent from my iPhone > On 2016/06/21, at 1:49, Leon Finker wrote: > > Hi, > > Can we please start on 2.6.2

[jira] [Commented] (LOG4J2-1448) Allow comma separated agents, host list to be passed to FlumeAppender

2016-06-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15349020#comment-15349020 ] ASF GitHub Bot commented on LOG4J2-1448: Github user kelaban commented on the iss

[jira] [Commented] (LOG4J2-1448) Allow comma separated agents, host list to be passed to FlumeAppender

2016-06-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15349014#comment-15349014 ] ASF GitHub Bot commented on LOG4J2-1448: GitHub user kelaban opened a pull reques

[jira] [Created] (LOG4J2-1448) Allow comma separated agents, host list to be passed to FlumeAppender

2016-06-24 Thread Keith Laban (JIRA)
Keith Laban created LOG4J2-1448: --- Summary: Allow comma separated agents, host list to be passed to FlumeAppender Key: LOG4J2-1448 URL: https://issues.apache.org/jira/browse/LOG4J2-1448 Project: Log4j 2

Re: I can see! (colors)

2016-06-24 Thread Ralph Goers
? Every appender accepts a Layout for rendering and they all use one. A File appender can use a Pattern layout, a JSON layout, etc. So it is incorrect to say any appender wants no rendering. I think what you are really wanting is a way to either a) enhance the Message.getFormattedMessage() to

Re: I can see! (colors)

2016-06-24 Thread Gary Gregory
Since an HTML layout and a Console JAnsi layout need different interpretation of the message string, why not allow each appender to do its own rendering? Also, you want no rendering for other appenders like file, JMS, and so on. Gary On Jun 24, 2016 11:07 AM, "Ralph Goers" wrote: > Yes. Of cours

Re: Lock pattern

2016-06-24 Thread Paul Benedict
That may be the one! Thanks for searching for it. I can't believe it's from three years ago! :-) Anyway, it goes on for some time and provides good arguments to consider from both sides. Cheers, Paul On Fri, Jun 24, 2016 at 4:10 AM, Gary Gregory wrote: > On Thu, Jun 23, 2016 at 4:51 PM, Greg Th

Re: I can see! (colors)

2016-06-24 Thread Ralph Goers
Yes. Of course the converter would need to be aware what the target is, which I am not sure is currently available. In this case I would think you would want to just enhance the %m converter to support these new plugins, rather than creating a new message converter. If you didn’t want to hav

Re: I can see! (colors)

2016-06-24 Thread Gary Gregory
Thank you for the feedback. I can see that I could invent a new kind of %m converter that parses the message and does the coloring. I could have an ANSI kind of %m, an HTML %m, and so on. Gary On Jun 24, 2016 10:00 AM, "Ralph Goers" wrote: > > I am not sure I get this idea at all. First, I wou

Re: I can see! (colors)

2016-06-24 Thread Ralph Goers
I am not sure I get this idea at all. First, I would expect that “styles” would be plugins much as converters are for the PatternLayout. But it isn’t clear to me at all why I would want or require a StyledMessage to do that. If you want to support “styles” then implement the support in the ap

Re: I can see! (colors)

2016-06-24 Thread Gary Gregory
Another question is what should the syntax be for a StyledMessage? The same as for a pattern layout ( https://logging.apache.org/log4j/2.x/manual/layouts.html#PatternLayout)? Something else? Could it be simpler and still allow for parameters and escaping? SyledMessageFactory factory = SyledMessage

Re: [1/4] logging-log4j2 git commit: Add AutoCloseableLock.

2016-06-24 Thread Matt Sicker
Oh, I didn't even think of that. Your approach makes more sense that way. On 24 June 2016 at 09:54, Gary Gregory wrote: > If we do that, then we have to change the return type of: > > lock() > lockInterruptibly() > > to void and create two new methods that return something since a try block > _m

Re: [1/4] logging-log4j2 git commit: Add AutoCloseableLock.

2016-06-24 Thread Gary Gregory
If we do that, then we have to change the return type of: lock() lockInterruptibly() to void and create two new methods that return something since a try block _must_ contain an assignment. What would you call these two methods? Gary On Fri, Jun 24, 2016 at 7:42 AM, Matt Sicker wrote: > I ki

[jira] [Commented] (LOG4J2-1243) Faulty placeholder substitution in config xml

2016-06-24 Thread Veit Guna (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15348373#comment-15348373 ] Veit Guna commented on LOG4J2-1243: --- Any news on this? > Faulty placeholder substitut

Fwd: [1/4] logging-log4j2 git commit: Add AutoCloseableLock.

2016-06-24 Thread Matt Sicker
I kinda imagined AutoCloseableLock to implement both AutoCloseable and Lock. -- Forwarded message -- From: Date: 24 June 2016 at 03:50 Subject: [1/4] logging-log4j2 git commit: Add AutoCloseableLock. To: comm...@logging.apache.org Repository: logging-log4j2 Updated Branches: r

Re: Lock pattern

2016-06-24 Thread Matt Sicker
That thread makes me think we should make some jmh tests for this. On 24 June 2016 at 04:10, Gary Gregory wrote: > On Thu, Jun 23, 2016 at 4:51 PM, Greg Thomas > wrote: > >> I''m sure I read somewhere that it was a deliberate choice not to make >> it, to stop people using the very common patter

[jira] [Commented] (LOG4J2-1392) PluginBuilder.build() looses reason for error

2016-06-24 Thread JIRA
[ https://issues.apache.org/jira/browse/LOG4J2-1392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15348112#comment-15348112 ] Bernhard Mähr commented on LOG4J2-1392: --- Not able to test it yet (because of LOG4J2

Re: Lock pattern

2016-06-24 Thread Gary Gregory
On Thu, Jun 23, 2016 at 4:51 PM, Greg Thomas wrote: > I''m sure I read somewhere that it was a deliberate choice not to make it, > to stop people using the very common pattern of creating the object in the > try() - which isn't much use for a lock. > Here? http://mail.openjdk.java.net/pipermail/

Re: Lock pattern

2016-06-24 Thread Gary Gregory
Please see the branch "AutoCloseableLock" for my experiment, look for usage of the class AutoCloseableLock. Gary On Thu, Jun 23, 2016 at 8:58 PM, Matt Sicker wrote: > FWIW, I'm still interested in this AutoCloseableLock idea. > > On 23 June 2016 at 22:25, Gary Gregory wrote: > >> Before you go

[jira] [Commented] (LOG4J2-1010) Injectable context properties

2016-06-24 Thread JIRA
[ https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15348005#comment-15348005 ] Mikael Ståldal commented on LOG4J2-1010: OK, let's go for Core, and an interface