Re: Logging stack traces conditionally

2016-10-26 Thread Matt Sicker
Wouldn't that introduce a new API compatibility issue like with the unrolled args issue? Like (Marker, null) would cause an ambiguous method. Then again, that might already be a problem if you try that. On 26 October 2016 at 18:24, Gary Gregory wrote: > On Wed, Oct 26, 2016 at 4:02 PM, Remko Pop

Re: Logging stack traces conditionally

2016-10-26 Thread Gary Gregory
On Wed, Oct 26, 2016 at 4:02 PM, Remko Popma wrote: > I would split them up and use a marker: > > logger.warn(sqlWarning.getMessage()); > logger.warn(SQL_WARN_EX, sqlWarning); > I tried that but the (Marker, Object) API logs the toString() of the exception, not the exception. It seems to me we

Re: Logging stack traces conditionally

2016-10-26 Thread Remko Popma
I would split them up and use a marker: logger.warn(sqlWarning.getMessage()); logger.warn(SQL_WARN_EX, sqlWarning); Then use a marker filter in configuration to exclude the stack traces with the marker. Sent from my iPhone > On 27 Oct 2016, at 2:41, Gary Gregory wrote: > > I have the follow

[jira] [Commented] (LOG4J2-1651) Makes the dat format more user friendly

2016-10-26 Thread Romain Manni-Bucau (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15609483#comment-15609483 ] Romain Manni-Bucau commented on LOG4J2-1651: good catch, only primitives are

[jira] [Commented] (LOG4J2-1651) Makes the dat format more user friendly

2016-10-26 Thread Matt Sicker (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15609332#comment-15609332 ] Matt Sicker commented on LOG4J2-1651: - We're using DataOutputStream, not normal Seria

Logging stack traces conditionally

2016-10-26 Thread Gary Gregory
I have the following use cases that I am pondering on how to best handle: I log exceptions like a JDBC SQLWarning (a subclass of Exception): logger.warn(sqlWarning.getMessage(). sqlWarning); and I want to be able to tell users: "do this to hide this stack trace but you'll still see the message,

[jira] [Commented] (LOG4J2-1651) Makes the dat format more user friendly

2016-10-26 Thread Romain Manni-Bucau (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15609119#comment-15609119 ] Romain Manni-Bucau commented on LOG4J2-1651: maven + gradle build tools or ne

[jira] [Commented] (LOG4J2-1651) Makes the dat format more user friendly

2016-10-26 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15609100#comment-15609100 ] Gary Gregory commented on LOG4J2-1651: -- I do use a shaded jar in a few places and th

[jira] [Commented] (LOG4J2-1644) Inefficient locking in AbstractLoggerAdapter

2016-10-26 Thread Tim Gokcen (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15609038#comment-15609038 ] Tim Gokcen commented on LOG4J2-1644: >From the original author of the unit test: no,

Flume 1.7

2016-10-26 Thread Gary Gregory
Do we want to update our dependency on Flume to 1.7? https://flume.apache.org/releases/1.7.0.html Gary -- E-Mail: garydgreg...@gmail.com | ggreg...@apache.org Java Persistence with Hibernate, Second Edition

[jira] [Commented] (LOG4J2-1651) Makes the dat format more user friendly

2016-10-26 Thread Matt Sicker (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15608881#comment-15608881 ] Matt Sicker commented on LOG4J2-1651: - Good point. The main thing to address here is

[jira] [Commented] (LOG4J2-1651) Makes the dat format more user friendly

2016-10-26 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15608865#comment-15608865 ] Ralph Goers commented on LOG4J2-1651: - I don't see how changing the file format will

[jira] [Commented] (LOG4J2-1644) Inefficient locking in AbstractLoggerAdapter

2016-10-26 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15608824#comment-15608824 ] Gary Gregory commented on LOG4J2-1644: -- Hi, this is a question for the dev-ML, can y

[jira] [Commented] (LOG4J2-1644) Inefficient locking in AbstractLoggerAdapter

2016-10-26 Thread Matt Barron (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15608804#comment-15608804 ] Matt Barron commented on LOG4J2-1644: - Just a quick question...is it necessary to hav

[jira] [Updated] (LOG4J2-1652) Shutdown only works correctly once

2016-10-26 Thread Tom (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tom updated LOG4J2-1652: Description: I am trying to reset log4j via the following code at runtime in order to write to new logfiles in new

[jira] [Created] (LOG4J2-1652) Shutdown only works correctly once

2016-10-26 Thread Tom (JIRA)
Tom created LOG4J2-1652: --- Summary: Shutdown only works correctly once Key: LOG4J2-1652 URL: https://issues.apache.org/jira/browse/LOG4J2-1652 Project: Log4j 2 Issue Type: Bug Affects Versions: 2.7,