[jira] [Commented] (LOG4J2-1676) Use Message.getThrowable() in log(Message) methods

2016-11-07 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15646807#comment-15646807 ] Gary Gregory commented on LOG4J2-1676: -- Can you please provide a unit test to demons

[jira] [Commented] (LOG4J2-1226) Message instances are simply serialized. They mustn't.

2016-11-07 Thread Joern Huxhorn (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15646745#comment-15646745 ] Joern Huxhorn commented on LOG4J2-1226: --- I created LOG4J2-1676 for this. > Message

[jira] [Created] (LOG4J2-1676) Use Message.getThrowable() in log(Message) methods

2016-11-07 Thread Joern Huxhorn (JIRA)
Joern Huxhorn created LOG4J2-1676: - Summary: Use Message.getThrowable() in log(Message) methods Key: LOG4J2-1676 URL: https://issues.apache.org/jira/browse/LOG4J2-1676 Project: Log4j 2 Issue

[jira] [Closed] (LOG4J2-1226) Message instances are simply serialized. They mustn't.

2016-11-07 Thread Joern Huxhorn (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joern Huxhorn closed LOG4J2-1226. - Fix works as expected. > Message instances are simply serialized. They mustn't. > --

[jira] [Commented] (LOG4J2-1226) Message instances are simply serialized. They mustn't.

2016-11-07 Thread Joern Huxhorn (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15646724#comment-15646724 ] Joern Huxhorn commented on LOG4J2-1226: --- OK, with {{Throwable}} as additional argum

[jira] [Commented] (LOG4J2-1675) Compile-time incompatibility regarding SimpleMessage

2016-11-07 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15645861#comment-15645861 ] Gary Gregory commented on LOG4J2-1675: -- It seems fair to document this the same way

[jira] [Commented] (LOG4J2-1226) Message instances are simply serialized. They mustn't.

2016-11-07 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15645784#comment-15645784 ] Remko Popma commented on LOG4J2-1226: - Thanks for confirming that the fix solves the

[jira] [Commented] (LOG4J2-1675) Compile-time incompatibility regarding SimpleMessage

2016-11-07 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15645767#comment-15645767 ] Remko Popma commented on LOG4J2-1675: - I'm okay to close this ticket but I'll wait fo

[jira] [Commented] (LOG4J2-1651) Makes the dat format more user friendly

2016-11-07 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15645389#comment-15645389 ] Ralph Goers commented on LOG4J2-1651: - Parsing ARBITRARY JSON is a minefield. We woul

[jira] [Commented] (LOG4J2-1651) Makes the dat format more user friendly

2016-11-07 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15645361#comment-15645361 ] Gary Gregory commented on LOG4J2-1651: -- FWIW, "Parsing JSON is a minefield": http://

[jira] [Commented] (LOG4J2-1651) Makes the dat format more user friendly

2016-11-07 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15644843#comment-15644843 ] Gary Gregory commented on LOG4J2-1651: -- Yeah, that's one way to go that I would not,

[jira] [Commented] (LOG4J2-878) Failover appender throws "Error flushing stream //L-Computer1/test/logs/primary.log" at the time of retry, but the location is up

2016-11-07 Thread Rowan Lonsdale (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15644596#comment-15644596 ] Rowan Lonsdale commented on LOG4J2-878: --- Yes, that is correct. However, I have to a

[jira] [Commented] (LOG4J2-1226) Message instances are simply serialized. They mustn't.

2016-11-07 Thread Joern Huxhorn (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15644477#comment-15644477 ] Joern Huxhorn commented on LOG4J2-1226: --- Just checked against 2.5, 2.6 and 2.7. All

[jira] [Commented] (LOG4J2-1226) Message instances are simply serialized. They mustn't.

2016-11-07 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1563#comment-1563 ] Remko Popma commented on LOG4J2-1226: - Was this problem introduced by the fix for thi

[jira] [Commented] (LOG4J2-1226) Message instances are simply serialized. They mustn't.

2016-11-07 Thread Joern Huxhorn (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15644436#comment-15644436 ] Joern Huxhorn commented on LOG4J2-1226: --- I have no idea. But that one was indeed es

[jira] [Commented] (LOG4J2-1226) Message instances are simply serialized. They mustn't.

2016-11-07 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15644413#comment-15644413 ] Remko Popma commented on LOG4J2-1226: - That is certainly strange. How can FooMessage

[jira] [Commented] (LOG4J2-1675) Compile-time incompatibility regarding SimpleMessage

2016-11-07 Thread Joern Huxhorn (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15644406#comment-15644406 ] Joern Huxhorn commented on LOG4J2-1675: --- I know. That's why I gave this a "minor" p

[jira] [Comment Edited] (LOG4J2-1226) Message instances are simply serialized. They mustn't.

2016-11-07 Thread Joern Huxhorn (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15644392#comment-15644392 ] Joern Huxhorn edited comment on LOG4J2-1226 at 11/7/16 2:55 PM: ---

[jira] [Commented] (LOG4J2-1675) Compile-time incompatibility regarding SimpleMessage

2016-11-07 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15644393#comment-15644393 ] Remko Popma commented on LOG4J2-1675: - Thank you, I think we had missed that one... W

[jira] [Commented] (LOG4J2-1226) Message instances are simply serialized. They mustn't.

2016-11-07 Thread Joern Huxhorn (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15644392#comment-15644392 ] Joern Huxhorn commented on LOG4J2-1226: --- I don't think so... In the {sandbox|http

[jira] [Commented] (LOG4J2-1226) Message instances are simply serialized. They mustn't.

2016-11-07 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15644362#comment-15644362 ] Remko Popma commented on LOG4J2-1226: - The throwables that were logged can still be o

[jira] [Commented] (LOG4J2-1226) Message instances are simply serialized. They mustn't.

2016-11-07 Thread Joern Huxhorn (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15644214#comment-15644214 ] Joern Huxhorn commented on LOG4J2-1226: --- The fact that {{FooMessage}} in the sandbo

[jira] [Created] (LOG4J2-1675) Compile-time incompatibility regarding SimpleMessage

2016-11-07 Thread Joern Huxhorn (JIRA)
Joern Huxhorn created LOG4J2-1675: - Summary: Compile-time incompatibility regarding SimpleMessage Key: LOG4J2-1675 URL: https://issues.apache.org/jira/browse/LOG4J2-1675 Project: Log4j 2 Issu

[jira] [Commented] (LOG4J2-1226) Message instances are simply serialized. They mustn't.

2016-11-07 Thread Joern Huxhorn (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15644166#comment-15644166 ] Joern Huxhorn commented on LOG4J2-1226: --- The fix looks good so far. All messages of

[jira] [Updated] (LOG4J2-1595) (GC) Avoid allocating temporary objects in Filter implementations

2016-11-07 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Remko Popma updated LOG4J2-1595: Description: Review current Filter implementation classes and change them to be garbage-free where

[jira] [Updated] (LOG4J2-1595) (GC) Avoid allocating temporary objects in Filter implementations

2016-11-07 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Remko Popma updated LOG4J2-1595: Description: Review current Filter implementation classes and change them to be garbage-free where