[jira] (LOG4J2-1803) JMH generated benchmark classes not included in jar

2017-01-30 Thread Remko Popma (JIRA)
Title: Message Title Remko Popma updated an issue

Re: FileAppenderBenchmark

2017-01-30 Thread Remko Popma
The log4j-perf issue seems to be that the classes generated by JMH under log4j-perf\target\generated-sources\annotations are not included in the shaded benchmarks.jar or in log4j-perf-2.8.1-SNAPSHOT.jar... On Tue, Jan 31, 2017 at 3:42 AM, Matt Sicker wrote: > Oh, the log4j-perf issue would prob

Re: FileAppenderBenchmark

2017-01-30 Thread Matt Sicker
Oh, the log4j-perf issue would probably be from combining all the .dat files. I thought we had a maven shade plugin transformer for that? I remember an old jira ticket about that. On 30 January 2017 at 12:18, Gary Gregory wrote: > On Mon, Jan 30, 2017 at 10:15 AM, Apache > wrote: > >> OK. But a

[jira] (LOG4J2-1803) JMH generated benchmark classes not included in jar

2017-01-30 Thread Remko Popma (JIRA)
Title: Message Title Remko Popma updated an issue

[jira] (LOG4J2-1803) JMH benchmarks fail to run

2017-01-30 Thread Remko Popma (JIRA)
Title: Message Title Remko Popma created an issue

Re: FileAppenderBenchmark

2017-01-30 Thread Gary Gregory
On Mon, Jan 30, 2017 at 10:15 AM, Apache wrote: > OK. But according to Matt this change wasn’t required. What was breaking > that needed fixing? > hm... maybe I was trying to remove some redundancies. can't quite recall ATM, sorry. Gary > > Ralph > > On Jan 30, 2017, at 9:49 AM, Gary Gregory

Re: FileAppenderBenchmark

2017-01-30 Thread Apache
Since the change isn’t required and it is breaking log4j-perf can you please revert it? Ralph > On Jan 30, 2017, at 11:15 AM, Apache wrote: > > OK. But according to Matt this change wasn’t required. What was breaking that > needed fixing? > > Ralph > >> On Jan 30, 2017, at 9:49 AM, Gary Gre

Re: FileAppenderBenchmark

2017-01-30 Thread Apache
OK. But according to Matt this change wasn’t required. What was breaking that needed fixing? Ralph > On Jan 30, 2017, at 9:49 AM, Gary Gregory wrote: > > > > On Jan 30, 2017 12:28 AM, "Apache" > wrote: > Gary moved it, presumably since many modules need to

Re: FileAppenderBenchmark

2017-01-30 Thread Gary Gregory
On Jan 30, 2017 12:28 AM, "Apache" wrote: Gary moved it, presumably since many modules need to generate a .dat file. Right, that was the idea. Gary Ralph On Jan 29, 2017, at 9:55 AM, Matt Sicker wrote: That maven-compiler-plugin config was originally only included in log4j-core in order t

Re: FileAppenderBenchmark

2017-01-30 Thread Matt Sicker
Annotation processing is enabled by default. I set up log4j-core like that because the annotation processor has to be compiled before it can be used, so it requires a second pass. On 30 January 2017 at 02:27, Apache wrote: > Gary moved it, presumably since many modules need to generate a .dat fi

[jira] (LOG4J2-1799) Error determining the current charset

2017-01-30 Thread Eduard Gizatullin (JIRA)
Title: Message Title Eduard Gizatullin edited a comment on LOG4J2-1799

[jira] (LOG4J2-1799) Error determining the current charset

2017-01-30 Thread Eduard Gizatullin (JIRA)
Title: Message Title Eduard Gizatullin commented on LOG4J2-1799

Re: FileAppenderBenchmark

2017-01-30 Thread Apache
Gary moved it, presumably since many modules need to generate a .dat file. Ralph > On Jan 29, 2017, at 9:55 AM, Matt Sicker wrote: > > That maven-compiler-plugin config was originally only included in log4j-core > in order to allow the PluginProcessor annotation processor to re-run against >