https://issues.apache.org/bugzilla/show_bug.cgi?id=45753
grobmeier changed:
What|Removed |Added
CC||log4j-...@logging.apache.or
https://issues.apache.org/bugzilla/show_bug.cgi?id=45753
--- Comment #15 from Ralph Goers 2011-10-21
13:51:52 UTC ---
I modified BurstFilter in 2.0 as you suggested.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: --
https://issues.apache.org/bugzilla/show_bug.cgi?id=45753
--- Comment #14 from John Vasileff 2011-10-03 22:25:21 UTC ---
Ralph, I believe the bug fix for #1 is either as shown in comment 12 (nanos
first) or comment 10 (use float for rate). Items #2 and #3 are just ideas.
I'm not sure it makes se
https://issues.apache.org/bugzilla/show_bug.cgi?id=45753
--- Comment #13 from Ralph Goers 2011-10-03
20:12:36 UTC ---
John, I encourage you to open a separate Jira issue for Log4J 2 and submit a
patch with how you'd like this to work and enhance the unit test as well.
Bugzilla really is for Log4
https://issues.apache.org/bugzilla/show_bug.cgi?id=45753
--- Comment #12 from John Vasileff 2011-10-03 17:53:02 UTC ---
I took a look at BurstFilter and have a few thoughts:
1) The calculation of burstInterval loses precision. Better may be to store
burstIntervalNanos with something like:
this
https://issues.apache.org/bugzilla/show_bug.cgi?id=45753
--- Comment #11 from Ralph Goers 2011-10-03
02:16:01 UTC ---
I agree and have made the suggested changes. If the max is left off it defaults
to 10 times the rate.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab
https://issues.apache.org/bugzilla/show_bug.cgi?id=45753
--- Comment #10 from John Vasileff 2011-10-03 00:57:30 UTC ---
I wonder if it would be easier for end users if the configuration was made with
rate instead of burstInterval:
float rate; // average number of log statements allowed per secon
https://issues.apache.org/bugzilla/show_bug.cgi?id=45753
--- Comment #9 from Ralph Goers 2011-10-02
19:52:01 UTC ---
If you've looked at the code you will see that it is using a DelayQueue to
control how many log entries can be written. From what I could tell in looking
at your code your bucket
https://issues.apache.org/bugzilla/show_bug.cgi?id=45753
--- Comment #8 from Chad LaVigne 2011-10-02 17:42:04
UTC ---
Thank you for adding this, I thought my contribution might be a lost cause. So
it looks like this is basically the same filter except that you no longer
define the fill amount, i
https://issues.apache.org/bugzilla/show_bug.cgi?id=45753
--- Comment #7 from Chad LaVigne 2011-10-02 17:34:16
UTC ---
Hi Ralph,
The unit test should work, although it's a little hard to read the results. You
should see 100 of 110 info log statements print with the first test, then
there's a sec
https://issues.apache.org/bugzilla/show_bug.cgi?id=45753
--- Comment #6 from Ralph Goers 2011-10-02
07:26:37 UTC ---
I implemented a BurstFilter that behaves a bit differently that yours to the
Log4j 2.0 experimental branch. It will behave a bit differently than yours in
that it only needs the
https://issues.apache.org/bugzilla/show_bug.cgi?id=45753
--- Comment #5 from Ralph Goers 2011-10-02
02:33:15 UTC ---
I tried adding this to my Log4j 2.0 branch but am having some problems. It
isn't passing the unit test. It seems to me that when the filter is called it
does nothing until fillInt
https://issues.apache.org/bugzilla/show_bug.cgi?id=45753
--- Comment #4 from Chad LaVigne 2011-09-30 18:40:29
UTC ---
I opened this issue quite a while ago and never received feedback after making
the changes initially requested. I've found this filter useful on quite a few
projects and each tim
https://issues.apache.org/bugzilla/show_bug.cgi?id=45753
--- Comment #3 from Chad LaVigne 2009-04-01 11:42:05
PST ---
Is there any feedback on this contribution?
(In reply to comment #2)
> Created an attachment (id=23401)
--> (https://issues.apache.org/bugzilla/attachment.cgi?id=23401) [d
https://issues.apache.org/bugzilla/show_bug.cgi?id=45753
--- Comment #2 from Chad LaVigne 2009-03-23 14:56:31
PST ---
Created an attachment (id=23401)
--> (https://issues.apache.org/bugzilla/attachment.cgi?id=23401)
Update to BurstFilter contribution
The attached code addresses the follow
https://issues.apache.org/bugzilla/show_bug.cgi?id=45753
Curt Arnold changed:
What|Removed |Added
Summary|Code contribution |Code contribution:
16 matches
Mail list logo
