[
https://issues.apache.org/jira/browse/LOG4J2-1356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15234064#comment-15234064
]
Remko Popma commented on LOG4J2-1356:
-
Thanks! Looks like I missed that when I removed the
[
https://issues.apache.org/jira/browse/LOG4J2-1356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15234019#comment-15234019
]
Mikael Ståldal commented on LOG4J2-1356:
GelfLayout is just a Layout, not connected to any
[
https://issues.apache.org/jira/browse/LOG4J2-1356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15234010#comment-15234010
]
Remko Popma commented on LOG4J2-1356:
-
Agree no need to check Constants.ENABLE_THREADLOCALS if
[
https://issues.apache.org/jira/browse/LOG4J2-1356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15234001#comment-15234001
]
Mikael Ståldal commented on LOG4J2-1356:
Maybe not even need to check for
[
https://issues.apache.org/jira/browse/LOG4J2-1356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15233999#comment-15233999
]
Mikael Ståldal commented on LOG4J2-1356:
So then I don't need to check for
[
https://issues.apache.org/jira/browse/LOG4J2-1356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15233993#comment-15233993
]
Remko Popma commented on LOG4J2-1356:
-
Sorry I was unclear. Layouts should provide both mechanisms:
[
https://issues.apache.org/jira/browse/LOG4J2-1356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15233986#comment-15233986
]
Mikael Ståldal commented on LOG4J2-1356:
OK, added usage of Constants.ENABLE_DIRECT_ENCODERS in
[
https://issues.apache.org/jira/browse/LOG4J2-1356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15233627#comment-15233627
]
Remko Popma commented on LOG4J2-1356:
-
Had a look at the branch. Looks fine to me.
> Update
[
https://issues.apache.org/jira/browse/LOG4J2-1356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15233517#comment-15233517
]
Remko Popma commented on LOG4J2-1356:
-
Cool. If there's no impact to other layouts I wouldn't worry
[
https://issues.apache.org/jira/browse/LOG4J2-1356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15233511#comment-15233511
]
Mikael Ståldal commented on LOG4J2-1356:
- Mention GelfLayout in garbagefree.xml documentation.
-
[
https://issues.apache.org/jira/browse/LOG4J2-1356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15233173#comment-15233173
]
Remko Popma commented on LOG4J2-1356:
-
I'll try to take a look as soon as I can. Are there changes
[
https://issues.apache.org/jira/browse/LOG4J2-1356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15232101#comment-15232101
]
Mikael Ståldal commented on LOG4J2-1356:
[~rem...@yahoo.com] Does this looks good now?
> Update
[
https://issues.apache.org/jira/browse/LOG4J2-1356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15226125#comment-15226125
]
Mikael Ståldal commented on LOG4J2-1356:
Check branch LOG4J2-1356 in Git.
> Update GelfLayout to
13 matches
Mail list logo