[
https://issues.apache.org/jira/browse/LOG4J2-1748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15828646#comment-15828646
]
ASF subversion and git services commented on LOG4J2-1748:
-
Commit
[
https://issues.apache.org/jira/browse/LOG4J2-1748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15828649#comment-15828649
]
ASF subversion and git services commented on LOG4J2-1748:
-
Commit
[
https://issues.apache.org/jira/browse/LOG4J2-1748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15828648#comment-15828648
]
ASF subversion and git services commented on LOG4J2-1748:
-
Commit
[
https://issues.apache.org/jira/browse/LOG4J2-1748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15828651#comment-15828651
]
ASF GitHub Bot commented on LOG4J2-1748:
Github user asfgit closed the pull request at:
[
https://issues.apache.org/jira/browse/LOG4J2-1748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15828495#comment-15828495
]
ASF GitHub Bot commented on LOG4J2-1748:
Github user rgoers commented on the issue:
[
https://issues.apache.org/jira/browse/LOG4J2-1748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15828492#comment-15828492
]
ASF GitHub Bot commented on LOG4J2-1748:
Github user jvz commented on the issue:
[
https://issues.apache.org/jira/browse/LOG4J2-1748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15828378#comment-15828378
]
ASF subversion and git services commented on LOG4J2-1748:
-
Commit
[
https://issues.apache.org/jira/browse/LOG4J2-1748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15828375#comment-15828375
]
ASF subversion and git services commented on LOG4J2-1748:
-
Commit
[
https://issues.apache.org/jira/browse/LOG4J2-1748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15828377#comment-15828377
]
ASF subversion and git services commented on LOG4J2-1748:
-
Commit
[
https://issues.apache.org/jira/browse/LOG4J2-1748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15828379#comment-15828379
]
ASF GitHub Bot commented on LOG4J2-1748:
Github user mikaelstaldal commented on a diff in the
[
https://issues.apache.org/jira/browse/LOG4J2-1748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15828319#comment-15828319
]
ASF GitHub Bot commented on LOG4J2-1748:
Github user jvz commented on a diff in the pull request:
[
https://issues.apache.org/jira/browse/LOG4J2-1748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15827720#comment-15827720
]
ASF GitHub Bot commented on LOG4J2-1748:
Github user mikaelstaldal commented on a diff in the
[
https://issues.apache.org/jira/browse/LOG4J2-1748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15827671#comment-15827671
]
ASF GitHub Bot commented on LOG4J2-1748:
Github user mikaelstaldal commented on the issue:
[
https://issues.apache.org/jira/browse/LOG4J2-1748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15826975#comment-15826975
]
ASF GitHub Bot commented on LOG4J2-1748:
Github user jvz commented on a diff in the pull request:
[
https://issues.apache.org/jira/browse/LOG4J2-1748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15826799#comment-15826799
]
ASF GitHub Bot commented on LOG4J2-1748:
GitHub user mikaelstaldal opened a pull request:
[
https://issues.apache.org/jira/browse/LOG4J2-1748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15826787#comment-15826787
]
ASF GitHub Bot commented on LOG4J2-1748:
Github user mikaelstaldal closed the pull request at:
[
https://issues.apache.org/jira/browse/LOG4J2-1748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15826786#comment-15826786
]
ASF GitHub Bot commented on LOG4J2-1748:
GitHub user mikaelstaldal opened a pull request:
[
https://issues.apache.org/jira/browse/LOG4J2-1748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15820805#comment-15820805
]
Mikael Ståldal commented on LOG4J2-1748:
I have a solution for this and LOG4J-1780, please review
[
https://issues.apache.org/jira/browse/LOG4J2-1748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15820759#comment-15820759
]
Mikael Ståldal commented on LOG4J2-1748:
I don't think it is that complicated to keep track of
[
https://issues.apache.org/jira/browse/LOG4J2-1748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15820692#comment-15820692
]
Remko Popma commented on LOG4J2-1748:
-
I disagree. We've seen problems in the past when the Async
[
https://issues.apache.org/jira/browse/LOG4J2-1748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15820630#comment-15820630
]
Mikael Ståldal commented on LOG4J2-1748:
The root cause of the problem is using non-daemon
[
https://issues.apache.org/jira/browse/LOG4J2-1748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15820604#comment-15820604
]
Mikael Ståldal commented on LOG4J2-1748:
Yes, I agree.
But while waiting for us to fix it, it
[
https://issues.apache.org/jira/browse/LOG4J2-1748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15820023#comment-15820023
]
Ralph Goers commented on LOG4J2-1748:
-
I have no problem using the ThreadFactory to create the
[
https://issues.apache.org/jira/browse/LOG4J2-1748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15819620#comment-15819620
]
Remko Popma commented on LOG4J2-1748:
-
It would be nice if the shutdown hook would be able to print a
[
https://issues.apache.org/jira/browse/LOG4J2-1748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15819604#comment-15819604
]
Remko Popma commented on LOG4J2-1748:
-
Probably best to have only one ExecutorService.
Naming-wise,
[
https://issues.apache.org/jira/browse/LOG4J2-1748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15819341#comment-15819341
]
Ralph Goers commented on LOG4J2-1748:
-
We have an ExecutorService. It is called
[
https://issues.apache.org/jira/browse/LOG4J2-1748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15819275#comment-15819275
]
Ralph Goers commented on LOG4J2-1748:
-
Again, lets just get rid of these ExecutorService instances.
[
https://issues.apache.org/jira/browse/LOG4J2-1748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15819273#comment-15819273
]
Ralph Goers commented on LOG4J2-1748:
-
I don't think that is a great recommendation.
> RollingFile
[
https://issues.apache.org/jira/browse/LOG4J2-1748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15819271#comment-15819271
]
Ralph Goers commented on LOG4J2-1748:
-
I don't know why those two ThreadPoolExecutors were added.
[
https://issues.apache.org/jira/browse/LOG4J2-1748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15819147#comment-15819147
]
Mikael Ståldal commented on LOG4J2-1748:
But I think the proper way to handle this is to have our
[
https://issues.apache.org/jira/browse/LOG4J2-1748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15816578#comment-15816578
]
Gary Gregory commented on LOG4J2-1748:
--
Yep, IIRC, that is why I did it that way.
> RollingFile
[
https://issues.apache.org/jira/browse/LOG4J2-1748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15816488#comment-15816488
]
Remko Popma commented on LOG4J2-1748:
-
I believe (I could be wrong) that the non-daemon thread was
[
https://issues.apache.org/jira/browse/LOG4J2-1748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15816208#comment-15816208
]
Mikael Ståldal commented on LOG4J2-1748:
Created a bug for the failure to shut down old
[
https://issues.apache.org/jira/browse/LOG4J2-1748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15816150#comment-15816150
]
Mikael Ståldal commented on LOG4J2-1748:
I am not sure that it will be dangerous to use a daemon
[
https://issues.apache.org/jira/browse/LOG4J2-1748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15814716#comment-15814716
]
Mikael Ståldal commented on LOG4J2-1748:
After looking more closely at this, I think it actually
[
https://issues.apache.org/jira/browse/LOG4J2-1748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15814711#comment-15814711
]
Mikael Ståldal commented on LOG4J2-1748:
A simple workaround is to add System.exit(0) at the end
[
https://issues.apache.org/jira/browse/LOG4J2-1748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15811186#comment-15811186
]
Remko Popma commented on LOG4J2-1748:
-
I think it's a good idea to use the
[
https://issues.apache.org/jira/browse/LOG4J2-1748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15811165#comment-15811165
]
Remko Popma commented on LOG4J2-1748:
-
... and another good catch! Two actually.
[
https://issues.apache.org/jira/browse/LOG4J2-1748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15811075#comment-15811075
]
Mikael Ståldal commented on LOG4J2-1748:
Anyway, we could change "shutdownTimeout" to a system
[
https://issues.apache.org/jira/browse/LOG4J2-1748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15811073#comment-15811073
]
Mikael Ståldal commented on LOG4J2-1748:
I don't really understand why we can't use a
[
https://issues.apache.org/jira/browse/LOG4J2-1748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15810301#comment-15810301
]
Remko Popma commented on LOG4J2-1748:
-
You wouldn't notice because I fixed it on Dec 27th by
[
https://issues.apache.org/jira/browse/LOG4J2-1748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15810287#comment-15810287
]
Ralph Goers commented on LOG4J2-1748:
-
Has this been tested with the latest code in master? I have
[
https://issues.apache.org/jira/browse/LOG4J2-1748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15810213#comment-15810213
]
Remko Popma commented on LOG4J2-1748:
-
Thank you for updating the JIRA.
The fact that this is a
[
https://issues.apache.org/jira/browse/LOG4J2-1748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15809938#comment-15809938
]
Mikael Ståldal commented on LOG4J2-1748:
I have added it to the JIRA now.
Here is goes also:
[
https://issues.apache.org/jira/browse/LOG4J2-1748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15808342#comment-15808342
]
Remko Popma commented on LOG4J2-1748:
-
Good point. Unfortunately, that JIRA doesn't document the name
[
https://issues.apache.org/jira/browse/LOG4J2-1748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15808189#comment-15808189
]
Mikael Ståldal commented on LOG4J2-1748:
Wait, now when we have
[
https://issues.apache.org/jira/browse/LOG4J2-1748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15777636#comment-15777636
]
Gary Gregory commented on LOG4J2-1748:
--
I do not think we should change the thread pool type to
[
https://issues.apache.org/jira/browse/LOG4J2-1748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15776596#comment-15776596
]
Remko Popma commented on LOG4J2-1748:
-
I've tracked down the cause: Log4j creates two
[
https://issues.apache.org/jira/browse/LOG4J2-1748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15773960#comment-15773960
]
Remko Popma commented on LOG4J2-1748:
-
If Log4j delays shutdown by one minute that's not good...
[
https://issues.apache.org/jira/browse/LOG4J2-1748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15773730#comment-15773730
]
Daniele Demichelis commented on LOG4J2-1748:
Hi [~garydgregory],
Configurator.shutdown(...)
[
https://issues.apache.org/jira/browse/LOG4J2-1748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15771374#comment-15771374
]
Gary Gregory commented on LOG4J2-1748:
--
You could also try to add a call to
[
https://issues.apache.org/jira/browse/LOG4J2-1748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15771292#comment-15771292
]
Gary Gregory commented on LOG4J2-1748:
--
I think the rollover happens on a separate thread. When
52 matches
Mail list logo