[jira] [Commented] (LOG4J2-585) Markers not as powerful as slf4j

[ https://issues.apache.org/jira/browse/LOG4J2-585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13967984#comment-13967984 ] Ralph Goers commented on LOG4J2-585: * I renamed set to setParents. * I don't really s

[jira] [Commented] (LOG4J2-585) Markers not as powerful as slf4j

[ https://issues.apache.org/jira/browse/LOG4J2-585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13967953#comment-13967953 ] Bruce Brouwer commented on LOG4J2-585: -- * I like the new fluent API. * Do you think

[jira] [Commented] (LOG4J2-585) Markers not as powerful as slf4j

[ https://issues.apache.org/jira/browse/LOG4J2-585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13967554#comment-13967554 ] Ralph Goers commented on LOG4J2-585: I've applied most of the changes in revision 1586

[jira] [Commented] (LOG4J2-585) Markers not as powerful as slf4j

[ https://issues.apache.org/jira/browse/LOG4J2-585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13961610#comment-13961610 ] Ralph Goers commented on LOG4J2-585: You don't need another issue to make the change t

[jira] [Commented] (LOG4J2-585) Markers not as powerful as slf4j

[ https://issues.apache.org/jira/browse/LOG4J2-585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13961604#comment-13961604 ] Bruce Brouwer commented on LOG4J2-585: -- * But we've made other breaking changes since

[jira] [Commented] (LOG4J2-585) Markers not as powerful as slf4j

[ https://issues.apache.org/jira/browse/LOG4J2-585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13961603#comment-13961603 ] Ralph Goers commented on LOG4J2-585: * What you are proposing is a good idea but if it

[jira] [Commented] (LOG4J2-585) Markers not as powerful as slf4j

[ https://issues.apache.org/jira/browse/LOG4J2-585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13961593#comment-13961593 ] Bruce Brouwer commented on LOG4J2-585: -- * Well, my recommendation in using define is

[jira] [Commented] (LOG4J2-585) Markers not as powerful as slf4j

[ https://issues.apache.org/jira/browse/LOG4J2-585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13961584#comment-13961584 ] Ralph Goers commented on LOG4J2-585: * It isn't clear to me why define() is a better n

[jira] [Commented] (LOG4J2-585) Markers not as powerful as slf4j

[ https://issues.apache.org/jira/browse/LOG4J2-585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13961566#comment-13961566 ] Bruce Brouwer commented on LOG4J2-585: -- So, here are my thoughts. Maybe some of these

[jira] [Commented] (LOG4J2-585) Markers not as powerful as slf4j

[ https://issues.apache.org/jira/browse/LOG4J2-585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13961543#comment-13961543 ] Ralph Goers commented on LOG4J2-585: Changes were applied in revision 1585355. Please

[jira] [Commented] (LOG4J2-585) Markers not as powerful as slf4j

[ https://issues.apache.org/jira/browse/LOG4J2-585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13961475#comment-13961475 ] Ralph Goers commented on LOG4J2-585: I spent quite a bit of time yesterday working on

[jira] [Commented] (LOG4J2-585) Markers not as powerful as slf4j

[ https://issues.apache.org/jira/browse/LOG4J2-585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13961223#comment-13961223 ] Bruce Brouwer commented on LOG4J2-585: -- {{java -jar target/microbenchmark.jar -t 8}}

[jira] [Commented] (LOG4J2-585) Markers not as powerful as slf4j

[ https://issues.apache.org/jira/browse/LOG4J2-585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13961204#comment-13961204 ] Ralph Goers commented on LOG4J2-585: Can you tell me what the command line is that you

[jira] [Commented] (LOG4J2-585) Markers not as powerful as slf4j

[ https://issues.apache.org/jira/browse/LOG4J2-585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13961199#comment-13961199 ] Bruce Brouwer commented on LOG4J2-585: -- So, are you saying that the only benefit is t

[jira] [Commented] (LOG4J2-585) Markers not as powerful as slf4j

[ https://issues.apache.org/jira/browse/LOG4J2-585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13961151#comment-13961151 ] Ralph Goers commented on LOG4J2-585: Lets say I want to create a parent marker called

[jira] [Commented] (LOG4J2-585) Markers not as powerful as slf4j

[ https://issues.apache.org/jira/browse/LOG4J2-585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13961148#comment-13961148 ] Bruce Brouwer commented on LOG4J2-585: -- Why make that rule that parents added during

[jira] [Commented] (LOG4J2-585) Markers not as powerful as slf4j

[ https://issues.apache.org/jira/browse/LOG4J2-585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13961145#comment-13961145 ] Ralph Goers commented on LOG4J2-585: No - I was referring to Bruce's suggestion to use

[jira] [Commented] (LOG4J2-585) Markers not as powerful as slf4j

[ https://issues.apache.org/jira/browse/LOG4J2-585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13961106#comment-13961106 ] Gary Gregory commented on LOG4J2-585: - Don't you mean "Gary"? ;) Had coffee yet :) ?

[jira] [Commented] (LOG4J2-585) Markers not as powerful as slf4j

[ https://issues.apache.org/jira/browse/LOG4J2-585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13961104#comment-13961104 ] Ralph Goers commented on LOG4J2-585: Bruce, that is too funny as that is exactly what

[jira] [Commented] (LOG4J2-585) Markers not as powerful as slf4j

[ https://issues.apache.org/jira/browse/LOG4J2-585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13961091#comment-13961091 ] Gary Gregory commented on LOG4J2-585: - If we want {code:java} getMarker(String name,

[jira] [Commented] (LOG4J2-585) Markers not as powerful as slf4j

[ https://issues.apache.org/jira/browse/LOG4J2-585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13961090#comment-13961090 ] Gary Gregory commented on LOG4J2-585: - If we want {code:java} getMarker(String name,

[jira] [Commented] (LOG4J2-585) Markers not as powerful as slf4j

[ https://issues.apache.org/jira/browse/LOG4J2-585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13960989#comment-13960989 ] Ralph Goers commented on LOG4J2-585: You mention that your code is slower so long as t

[jira] [Commented] (LOG4J2-585) Markers not as powerful as slf4j

[ https://issues.apache.org/jira/browse/LOG4J2-585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13960867#comment-13960867 ] Bruce Brouwer commented on LOG4J2-585: -- So another idea I had is along the lines of w

[jira] [Commented] (LOG4J2-585) Markers not as powerful as slf4j

[ https://issues.apache.org/jira/browse/LOG4J2-585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13959213#comment-13959213 ] Bruce Brouwer commented on LOG4J2-585: -- The problem with creating all new immutable m

[jira] [Commented] (LOG4J2-585) Markers not as powerful as slf4j

[ https://issues.apache.org/jira/browse/LOG4J2-585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13958810#comment-13958810 ] Gary Gregory commented on LOG4J2-585: - I did not look at your patch, but here are a fe

[jira] [Commented] (LOG4J2-585) Markers not as powerful as slf4j

[ https://issues.apache.org/jira/browse/LOG4J2-585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13954878#comment-13954878 ] Bruce Brouwer commented on LOG4J2-585: -- Interesting. I don't know if it makes sense f

[jira] [Commented] (LOG4J2-585) Markers not as powerful as slf4j

[ https://issues.apache.org/jira/browse/LOG4J2-585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13954871#comment-13954871 ] Gary Gregory commented on LOG4J2-585: - Why can't we have 2 Marker implementations? Mut

[jira] [Commented] (LOG4J2-585) Markers not as powerful as slf4j

[ https://issues.apache.org/jira/browse/LOG4J2-585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13954808#comment-13954808 ] Ralph Goers commented on LOG4J2-585: You could use CopyOnWriteArrayList. If adds and r

[jira] [Commented] (LOG4J2-585) Markers not as powerful as slf4j

[ https://issues.apache.org/jira/browse/LOG4J2-585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13954805#comment-13954805 ] Bruce Brouwer commented on LOG4J2-585: -- Cool. So, in my patch, when I make log4j Mark

[jira] [Commented] (LOG4J2-585) Markers not as powerful as slf4j

[ https://issues.apache.org/jira/browse/LOG4J2-585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13954781#comment-13954781 ] Ralph Goers commented on LOG4J2-585: I looked at BasicMarker again. It has changed a b

[jira] [Commented] (LOG4J2-585) Markers not as powerful as slf4j

[ https://issues.apache.org/jira/browse/LOG4J2-585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13954776#comment-13954776 ] Ralph Goers commented on LOG4J2-585: If you are going to use a lock you might consider

[jira] [Commented] (LOG4J2-585) Markers not as powerful as slf4j

[ https://issues.apache.org/jira/browse/LOG4J2-585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13954762#comment-13954762 ] Ralph Goers commented on LOG4J2-585: Yes, feel free to submit a patch. I have no prob

[jira] [Commented] (LOG4J2-585) Markers not as powerful as slf4j

[ https://issues.apache.org/jira/browse/LOG4J2-585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13954753#comment-13954753 ] Bruce Brouwer commented on LOG4J2-585: -- About the performance, I suspected what Ralph

[jira] [Commented] (LOG4J2-585) Markers not as powerful as slf4j

[ https://issues.apache.org/jira/browse/LOG4J2-585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13954715#comment-13954715 ] Gary Gregory commented on LOG4J2-585: - Would it possible for Log4J 2 to work with an a

[jira] [Commented] (LOG4J2-585) Markers not as powerful as slf4j

[ https://issues.apache.org/jira/browse/LOG4J2-585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13954714#comment-13954714 ] Ralph Goers commented on LOG4J2-585: The choice to make Markers immutable and not supp