[jira] [Commented] (LOG4J2-908) JSONLayout doesn't add a comma between log events

[ https://issues.apache.org/jira/browse/LOG4J2-908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15074340#comment-15074340 ] Robin Coe commented on LOG4J2-908: -- Could commas not be appended to each log event and th

[jira] [Commented] (LOG4J2-908) JSONLayout doesn't add a comma between log events

[ https://issues.apache.org/jira/browse/LOG4J2-908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15074388#comment-15074388 ] Gary Gregory commented on LOG4J2-908: - How about adding the "," if an event is not the

[jira] [Commented] (LOG4J2-908) JSONLayout doesn't add a comma between log events

[ https://issues.apache.org/jira/browse/LOG4J2-908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15075059#comment-15075059 ] Robin Coe commented on LOG4J2-908: -- Hi Gary, One typo in the javadoc of the JSONLayout c

[jira] [Commented] (LOG4J2-908) JSONLayout doesn't add a comma between log events

[ https://issues.apache.org/jira/browse/LOG4J2-908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15075394#comment-15075394 ] Gary Gregory commented on LOG4J2-908: - I fixed the Javadoc, thank you for noticing tha

[jira] [Commented] (LOG4J2-908) JSONLayout doesn't add a comma between log events

[ https://issues.apache.org/jira/browse/LOG4J2-908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15075405#comment-15075405 ] Gary Gregory commented on LOG4J2-908: - WRT commas and documents. Right now you can d

[jira] [Commented] (LOG4J2-908) JSONLayout doesn't add a comma between log events

[ https://issues.apache.org/jira/browse/LOG4J2-908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15075630#comment-15075630 ] Mikael Ståldal commented on LOG4J2-908: --- To me it seems quite arbitrary to use EOL (

[jira] [Commented] (LOG4J2-908) JSONLayout doesn't add a comma between log events

[ https://issues.apache.org/jira/browse/LOG4J2-908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15075698#comment-15075698 ] Gary Gregory commented on LOG4J2-908: - I agree that a decent parser should be able to

[jira] [Commented] (LOG4J2-908) JSONLayout doesn't add a comma between log events

[ https://issues.apache.org/jira/browse/LOG4J2-908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15075985#comment-15075985 ] Robin Coe commented on LOG4J2-908: -- True. A clever parse *should* but Logstash can't. O

[jira] [Commented] (LOG4J2-908) JSONLayout doesn't add a comma between log events

[ https://issues.apache.org/jira/browse/LOG4J2-908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15076047#comment-15076047 ] Gary Gregory commented on LOG4J2-908: - Don't forget that the layout now uses commas to

[jira] [Commented] (LOG4J2-908) JSONLayout doesn't add a comma between log events

[ https://issues.apache.org/jira/browse/LOG4J2-908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15076068#comment-15076068 ] Mikael Ståldal commented on LOG4J2-908: --- I guess that you use logstash to route log

[jira] [Commented] (LOG4J2-908) JSONLayout doesn't add a comma between log events

[ https://issues.apache.org/jira/browse/LOG4J2-908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15076069#comment-15076069 ] Mikael Ståldal commented on LOG4J2-908: --- The original issue is not about Logstash as

[jira] [Commented] (LOG4J2-908) JSONLayout doesn't add a comma between log events

[ https://issues.apache.org/jira/browse/LOG4J2-908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15076095#comment-15076095 ] Robin Coe commented on LOG4J2-908: -- I disagree with creating a new layout just for logsta

[jira] [Commented] (LOG4J2-908) JSONLayout doesn't add a comma between log events

[ https://issues.apache.org/jira/browse/LOG4J2-908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15076131#comment-15076131 ] Gary Gregory commented on LOG4J2-908: - I think we can close this issue since the bug i

[jira] [Commented] (LOG4J2-908) JSONLayout doesn't add a comma between log events

[ https://issues.apache.org/jira/browse/LOG4J2-908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15076182#comment-15076182 ] Ralph Goers commented on LOG4J2-908: I think I am very confused. This issue implies t

[jira] [Commented] (LOG4J2-908) JSONLayout doesn't add a comma between log events

[ https://issues.apache.org/jira/browse/LOG4J2-908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15076239#comment-15076239 ] Robin Coe commented on LOG4J2-908: -- I see your point. In that question, the solution is

[jira] [Commented] (LOG4J2-908) JSONLayout doesn't add a comma between log events

[ https://issues.apache.org/jira/browse/LOG4J2-908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15076240#comment-15076240 ] Mikael Ståldal commented on LOG4J2-908: --- In terms of JSON, there is a semantic diffe

[jira] [Commented] (LOG4J2-908) JSONLayout doesn't add a comma between log events

[ https://issues.apache.org/jira/browse/LOG4J2-908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15076241#comment-15076241 ] Mikael Ståldal commented on LOG4J2-908: --- BTW, have you tried to use Log4j's GelfLayo

[jira] [Commented] (LOG4J2-908) JSONLayout doesn't add a comma between log events

[ https://issues.apache.org/jira/browse/LOG4J2-908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15076244#comment-15076244 ] Robin Coe commented on LOG4J2-908: -- No but I did briefly look at it. I actually dropped

[jira] [Commented] (LOG4J2-908) JSONLayout doesn't add a comma between log events

[ https://issues.apache.org/jira/browse/LOG4J2-908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15076262#comment-15076262 ] Konstantinos Liakos commented on LOG4J2-908: The issue was about JsonLayout no

[jira] [Commented] (LOG4J2-908) JSONLayout doesn't add a comma between log events

[ https://issues.apache.org/jira/browse/LOG4J2-908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15076334#comment-15076334 ] Gary Gregory commented on LOG4J2-908: - Can you verify and close the issue please since

[jira] [Commented] (LOG4J2-908) JSONLayout doesn't add a comma between log events

[ https://issues.apache.org/jira/browse/LOG4J2-908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15076520#comment-15076520 ] Konstantinos Liakos commented on LOG4J2-908: Just tested it, and it seems ther

[jira] [Commented] (LOG4J2-908) JSONLayout doesn't add a comma between log events

[ https://issues.apache.org/jira/browse/LOG4J2-908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15076744#comment-15076744 ] Gary Gregory commented on LOG4J2-908: - Oops, try again from Git master please. > JSON

[jira] [Commented] (LOG4J2-908) JSONLayout doesn't add a comma between log events

[ https://issues.apache.org/jira/browse/LOG4J2-908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15081220#comment-15081220 ] Konstantinos Liakos commented on LOG4J2-908: It's good now. > JSONLayout does

[jira] [Commented] (LOG4J2-908) JSONLayout doesn't add a comma between log events

[ https://issues.apache.org/jira/browse/LOG4J2-908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15127949#comment-15127949 ] Anshu Garg commented on LOG4J2-908: --- When complete is set to false, comma is not added t

[jira] [Commented] (LOG4J2-908) JSONLayout doesn't add a comma between log events

[ https://issues.apache.org/jira/browse/LOG4J2-908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15127957#comment-15127957 ] Konstantinos Liakos commented on LOG4J2-908: The docs say: the appender output

[jira] [Commented] (LOG4J2-908) JSONLayout doesn't add a comma between log events

[ https://issues.apache.org/jira/browse/LOG4J2-908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15128504#comment-15128504 ] Mikael Ståldal commented on LOG4J2-908: --- The implementation is correct and documenta

[jira] [Commented] (LOG4J2-908) JSONLayout doesn't add a comma between log events

[ https://issues.apache.org/jira/browse/LOG4J2-908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15128518#comment-15128518 ] Mikael Ståldal commented on LOG4J2-908: --- Fixed documentation. > JSONLayout doesn't

[jira] [Commented] (LOG4J2-908) JSONLayout doesn't add a comma between log events

[ https://issues.apache.org/jira/browse/LOG4J2-908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14228753#comment-14228753 ] Gary Gregory commented on LOG4J2-908: - Ate you setting complete = true ? > JSONLayout

[jira] [Commented] (LOG4J2-908) JSONLayout doesn't add a comma between log events

[ https://issues.apache.org/jira/browse/LOG4J2-908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14228764#comment-14228764 ] Konstantinos Liakos commented on LOG4J2-908: Yes, I am setting , and not only

[jira] [Commented] (LOG4J2-908) JSONLayout doesn't add a comma between log events

[ https://issues.apache.org/jira/browse/LOG4J2-908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14265357#comment-14265357 ] Patrick Flaherty commented on LOG4J2-908: - I sent an email to the log4j list... H

[jira] [Commented] (LOG4J2-908) JSONLayout doesn't add a comma between log events

[ https://issues.apache.org/jira/browse/LOG4J2-908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14271962#comment-14271962 ] Gary Gregory commented on LOG4J2-908: - We have two issues here: The first, which appe

[jira] [Commented] (LOG4J2-908) JSONLayout doesn't add a comma between log events

[ https://issues.apache.org/jira/browse/LOG4J2-908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14272005#comment-14272005 ] Patrick Flaherty commented on LOG4J2-908: - If you check the gist output, I get the

[jira] [Commented] (LOG4J2-908) JSONLayout doesn't add a comma between log events

[ https://issues.apache.org/jira/browse/LOG4J2-908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14272027#comment-14272027 ] Gary Gregory commented on LOG4J2-908: - If you use compact=false, you should get an EOL

[jira] [Commented] (LOG4J2-908) JSONLayout doesn't add a comma between log events

[ https://issues.apache.org/jira/browse/LOG4J2-908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14273181#comment-14273181 ] Patrick Flaherty commented on LOG4J2-908: - No trailing EOL, so it doesn't get cons

[jira] [Commented] (LOG4J2-908) JSONLayout doesn't add a comma between log events

[ https://issues.apache.org/jira/browse/LOG4J2-908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14281224#comment-14281224 ] Gary Gregory commented on LOG4J2-908: - Please see [LOG4J2-941] to produce one compact