might have done that, sorry. I wonder how long we want to
> keep Java 6 as the base platform...
>
> Gary
> -- Forwarded message --
> From:
> Date: Sun, Apr 5, 2015 at 12:00 AM
> Subject: logging-log4j2 git commit: LOG4J2-980 Replaced Long.compare(long,
> 0)
, sorry. I wonder how long we want to keep
>> Java 6 as the base platform...
>>
>> Gary
>> -- Forwarded message --
>> From:
>> Date: Sun, Apr 5, 2015 at 12:00 AM
>> Subject: logging-log4j2 git commit: LOG4J2-980 Replaced Long.compare(long,
ase platform...
>
> Gary
> -- Forwarded message --
> From: mailto:rpo...@apache.org>>
> Date: Sun, Apr 5, 2015 at 12:00 AM
> Subject: logging-log4j2 git commit: LOG4J2-980 Replaced Long.compare(long, 0)
> with Long.signum(long) in BurstFilter: the
) in BurstFilter: the compare method needs Java7.
To: comm...@logging.apache.org
Repository: logging-log4j2
Updated Branches:
refs/heads/master 4f9361914 -> eed00545a
LOG4J2-980 Replaced Long.compare(long,0) with Long.signum(long) in
BurstFilter: the compare method needs Java7.
Project: h
fine. Thanks!
> Numerical overflow in BurstFilter not handled correctly
> ---
>
> Key: LOG4J2-980
> URL: https://issues.apache.org/jira/browse/LOG4J2-980
> Project: Log4j 2
>
[
https://issues.apache.org/jira/browse/LOG4J2-980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mikhail Mazurskiy closed LOG4J2-980.
> Numerical overflow in BurstFilter not handled correc
e of {{nanoTime()}} ?
> Numerical overflow in BurstFilter not handled correctly
> ---
>
> Key: LOG4J2-980
> URL: https://issues.apache.org/jira/browse/LOG4J2-980
> Project: Log4j 2
>
ied a patch inspired by the patch you
provided. You may wish to study it. In particular, it keeps the {{LogDelay}}
class private and reuses the {{Long.compare(long, long)}} method.
Please review and close.
Thank you again and keep the patches coming
Gary
> Numerical overflow in BurstFilter not
in BurstFilter not handled correctly
> ---
>
> Key: LOG4J2-980
> URL: https://issues.apache.org/jira/browse/LOG4J2-980
> Project: Log4j 2
> Issue Type: Bug
> Componen
Mikhail Mazurskiy created LOG4J2-980:
Summary: Numerical overflow in BurstFilter not handled correctly
Key: LOG4J2-980
URL: https://issues.apache.org/jira/browse/LOG4J2-980
Project: Log4j 2
Hi,
https://issues.apache.org/bugzilla/show_bug.cgi?id=45753
it has a BurstFilter for companions, but later I saw some comments by
Ralph it arrived in log4j 2.
So I think we should close this issue and refer people to log4j 2 in this case.
Any objections?
Cheers
Christian
--
http
[
https://issues.apache.org/jira/browse/LOG4J2-173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ralph Goers closed LOG4J2-173.
--
> BurstFilter does not honour level
> -
>
>
[
https://issues.apache.org/jira/browse/LOG4J2-173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ralph Goers resolved LOG4J2-173.
Resolution: Not A Problem
> BurstFilter does not honour le
3 AM:
--
Ahh, you're right -- RTFM, Henry. Apologies for wasting your time on this,
Ralph.
FWIW I achieved my goal (emailing errors, but preventing email flooding)
without modifying the BurstFilter with the following filter configuration :
Thanks for looking into this, and
3 AM:
--
Ahh, you're right -- RTFM, Henry. Apologies for wasting your time on this,
Ralph.
FWIW I achieved my goal (emailing errors, but preventing email flooding)
without modifying the BurstFilter with the following filter configuration :
{code:javascript}
{code}
Thanks fo
2 AM:
--
Ahh, you're right -- RTFM, Henry. Apologies for wasting your time on this,
Ralph.
FWIW I achieved my goal (emailing errors, but preventing email flooding)
without modifying the BurstFilter with the following filter configuration :
{code:xml}
{code}
Thanks for looking
ogies for wasting your time on this,
Ralph.
FWIW I achieved my goal (emailing errors, but preventing email flooding)
without modifying the BurstFilter with the following filter configuration :
{code}
{code}
Thanks for looking into this, and apolog
m not sure the BurstFilter works the way you
think it does. When you set the level to info all warn and error messages
should go through without being blocked (they are not subject to burst
filtering). Events at info, debug, trace, etc are allowed through so long as
they don't exceed the
8 PM:
-
Further to this, when I made the mod I suggested to BurstFilter the test still
failed due to the burst filtering kicking in for tests that assumed it would
not. There seemed to be a number of issues expecting 110 results to be logged
when the burst size is configured to be 100, and a lac
sted to BurstFilter the test still
failed due to the burst filtering kicking in for tests that assumed it would
not. There seemed to be a number of issues expecting 110 results to be logged
when the burst size is configured to be 100, and a lack of sleeps between tests.
Also, the final test ass
[
https://issues.apache.org/jira/browse/LOG4J2-173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Henry Clout updated LOG4J2-173:
---
Attachment: BurstFilterTest.java
> BurstFilter does not honour le
[
https://issues.apache.org/jira/browse/LOG4J2-173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Henry Clout updated LOG4J2-173:
---
Attachment: (was: BurstFilterTest.java)
> BurstFilter does not honour le
[
https://issues.apache.org/jira/browse/LOG4J2-173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Henry Clout updated LOG4J2-173:
---
Comment: was deleted
(was: Revised burst filter test.)
> BurstFilter does not honour le
(int i = 0; i < 110; i++) {
111:logger.debug(
112:"TEST FAILED! Logging 110 debug messages, shouldn't see any
of them because they are debugs #" + (i + 1));
113:}
...
This now consistently fails when I run the test. I'll att
[
https://issues.apache.org/jira/browse/LOG4J2-173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Henry Clout updated LOG4J2-173:
---
Attachment: BurstFilterTest.java
Revised burst filter test.
> BurstFilter does
"TEST FAILED! Logging 110 debug messages, shouldn't see any
of them because they are debugs #" + (i + 1));
113:}
...
This now consistently fails when I run the test. I'll attach the modified
source.
it seems to test things properly and the
unit test runs without errors. Can you provide a test that you believe should
work that doesn't?
> BurstFilter does not honour level
> -
>
> Key: LOG4J2-173
&g
[
https://issues.apache.org/jira/browse/LOG4J2-173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Henry Clout updated LOG4J2-173:
---
Description:
I've been getting info (and below) logging out of the BurstFilter despite it
bein
[
https://issues.apache.org/jira/browse/LOG4J2-173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Henry Clout updated LOG4J2-173:
---
Description:
I've been getting info (and below) logging out of the BurstFilter despite it
bein
[
https://issues.apache.org/jira/browse/LOG4J2-173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Henry Clout updated LOG4J2-173:
---
Description:
I've been getting info (and below) logging out of the BurstFilter despi
[
https://issues.apache.org/jira/browse/LOG4J2-173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Henry Clout updated LOG4J2-173:
---
Fix Version/s: (was: 2.0-beta4)
> BurstFilter does not honour le
Henry Clout created LOG4J2-173:
--
Summary: BurstFilter does not honour level
Key: LOG4J2-173
URL: https://issues.apache.org/jira/browse/LOG4J2-173
Project: Log4j 2
Issue Type: Bug
https://issues.apache.org/bugzilla/show_bug.cgi?id=45753
grobmeier changed:
What|Removed |Added
CC||log4j-...@logging.apache.or
https://issues.apache.org/bugzilla/show_bug.cgi?id=45753
--- Comment #15 from Ralph Goers 2011-10-21
13:51:52 UTC ---
I modified BurstFilter in 2.0 as you suggested.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because
makes sense for me to dig further into this since you are
already on the 10 yard line, but if you still feel otherwise I'll try to
provide a Jira patch when I find some time.
Hopefully the above discussion will help out if BurstFilter (in some form) is
added to Log4j 1.x, but if I have further
https://issues.apache.org/bugzilla/show_bug.cgi?id=45753
--- Comment #13 from Ralph Goers 2011-10-03
20:12:36 UTC ---
John, I encourage you to open a separate Jira issue for Log4J 2 and submit a
patch with how you'd like this to work and enhance the unit test as well.
Bugzilla really is for Log4
https://issues.apache.org/bugzilla/show_bug.cgi?id=45753
--- Comment #12 from John Vasileff 2011-10-03 17:53:02 UTC ---
I took a look at BurstFilter and have a few thoughts:
1) The calculation of burstInterval loses precision. Better may be to store
burstIntervalNanos with something like
https://issues.apache.org/bugzilla/show_bug.cgi?id=45753
--- Comment #11 from Ralph Goers 2011-10-03
02:16:01 UTC ---
I agree and have made the suggested changes. If the max is left off it defaults
to 10 times the rate.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab
https://issues.apache.org/bugzilla/show_bug.cgi?id=45753
--- Comment #10 from John Vasileff 2011-10-03 00:57:30 UTC ---
I wonder if it would be easier for end users if the configuration was made with
rate instead of burstInterval:
float rate; // average number of log statements allowed per secon
https://issues.apache.org/bugzilla/show_bug.cgi?id=45753
--- Comment #9 from Ralph Goers 2011-10-02
19:52:01 UTC ---
If you've looked at the code you will see that it is using a DelayQueue to
control how many log entries can be written. From what I could tell in looking
at your code your bucket
(In reply to comment #6)
> I implemented a BurstFilter that behaves a bit differently that yours to the
> Log4j 2.0 experimental branch. It will behave a bit differently than yours in
> that it only needs the interval and queue size. You can find it at
> https://svn.apache.org/repos/
https://issues.apache.org/bugzilla/show_bug.cgi?id=45753
--- Comment #7 from Chad LaVigne 2011-10-02 17:34:16
UTC ---
Hi Ralph,
The unit test should work, although it's a little hard to read the results. You
should see 100 of 110 info log statements print with the first test, then
there's a sec
https://issues.apache.org/bugzilla/show_bug.cgi?id=45753
--- Comment #6 from Ralph Goers 2011-10-02
07:26:37 UTC ---
I implemented a BurstFilter that behaves a bit differently that yours to the
Log4j 2.0 experimental branch. It will behave a bit differently than yours in
that it only needs the
https://issues.apache.org/bugzilla/show_bug.cgi?id=45753
--- Comment #5 from Ralph Goers 2011-10-02
02:33:15 UTC ---
I tried adding this to my Log4j 2.0 branch but am having some problems. It
isn't passing the unit test. It seems to me that when the filter is called it
does nothing until fillInt
https://issues.apache.org/bugzilla/show_bug.cgi?id=45753
--- Comment #4 from Chad LaVigne 2011-09-30 18:40:29
UTC ---
I opened this issue quite a while ago and never received feedback after making
the changes initially requested. I've found this filter useful on quite a few
projects and each tim
=23401) [details]
> Update to BurstFilter contribution
>
> The attached code addresses the following issues mentioned by Curt.
>
> 1) License headers are fixed
> 2) @Author tags removed
> 3) JavaDoc comments added to all methods
> 4) Filter is now level aware
> 5) Bu
https://issues.apache.org/bugzilla/show_bug.cgi?id=45753
--- Comment #2 from Chad LaVigne 2009-03-23 14:56:31
PST ---
Created an attachment (id=23401)
--> (https://issues.apache.org/bugzilla/attachment.cgi?id=23401)
Update to BurstFilter contribution
The attached code addresses
:
||BurstFilter for extras
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug
48 matches
Mail list logo
