Re: LOG4J2-1472 Make org.apache.logging.log4j.core.LoggerContext implement Closeable

2016-07-20 Thread Gary Gregory
to semantic reasons (same goes for Terminable). > > On 20 July 2016 at 22:21, Gary Gregory wrote: > >> Hi All: >> >> With: >> >> LOG4J2-1472 >> Make org.apache.logging.log4j.core.LoggerContext implement Closeable >> https://issues.apache.org/jira

Re: LOG4J2-1472 Make org.apache.logging.log4j.core.LoggerContext implement Closeable

2016-07-20 Thread Matt Sicker
I think you should use AutoCloseable. I don't think the LifeCycle classes should necessarily advertise themselves as closeable due to semantic reasons (same goes for Terminable). On 20 July 2016 at 22:21, Gary Gregory wrote: > Hi All: > > With: > >

[jira] [Resolved] (LOG4J2-1472) Make org.apache.logging.log4j.core.LoggerContext implement Closeable

2016-07-20 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1472?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory resolved LOG4J2-1472. -- Resolution: Fixed > Make org.apache.logging.log4j.core.LoggerContext implement Closeable >

[jira] [Commented] (LOG4J2-1472) Make org.apache.logging.log4j.core.LoggerContext implement Closeable

2016-07-20 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15387071#comment-15387071 ] Gary Gregory commented on LOG4J2-1472: -- Code is in Git master. > Make org.apache.lo

LOG4J2-1472 Make org.apache.logging.log4j.core.LoggerContext implement Closeable

2016-07-20 Thread Gary Gregory
Hi All: With: LOG4J2-1472 Make org.apache.logging.log4j.core.LoggerContext implement Closeable https://issues.apache.org/jira/browse/LOG4J2-1472 I have questions: public class LoggerContext extends AbstractLifeCycle implements org.apache.logging.log4j.spi.LoggerContext, Closeable

[jira] [Created] (LOG4J2-1472) Make org.apache.logging.log4j.core.LoggerContext implement Closeable

2016-07-20 Thread Gary Gregory (JIRA)
Gary Gregory created LOG4J2-1472: Summary: Make org.apache.logging.log4j.core.LoggerContext implement Closeable Key: LOG4J2-1472 URL: https://issues.apache.org/jira/browse/LOG4J2-1472 Project: Log4j 2