I have never used markers. If we need more tests for them, someone more
familiar with the concept should do them.
On Wed, Jun 29, 2016 at 8:52 PM, Matt Sicker wrote:
> It's supposed to work the same way that MarkerFilter works. Checking if a
> message is filtered based on the marker means you ca
It's supposed to work the same way that MarkerFilter works. Checking if a
message is filtered based on the marker means you can deny or allow events
strictly based on what marker is attached. You can do some pretty cool
stuff with MarkerFilter if you're using markers a lot.
On 29 June 2016 at 12:3
I have now added unit tests for Logger.isEnabled(Level, Marker) similar to
those existing for Logger.isEnabled(Level), and fixed the Javadoc.
If we want more elaborate tests, I am a bit unsure about how it supposed to
work so someone else should do that.
On Wed, Jun 29, 2016 at 5:43 PM, Matt Sick
There are two options to test that, then:
1. Update TestLogger in log4j-api/test to add support for marker filters.
2. Make a full integration test (i.e., with a config file) for MarkerFilter
as the current test only uses the filter directly.
On 29 June 2016 at 03:54, Mikael Ståldal wrote:
> Th
There is no unit test coverage of Logger.isEnabled(Level, Marker)
On Tue, Jun 28, 2016 at 5:52 PM, Gary Gregory
wrote:
> On Tue, Jun 28, 2016 at 8:48 AM, Mikael Ståldal > wrote:
>
>> The Javadoc for the Logger.isEnabled methods looks a bit odd. I just
>> fixed a few obvious errors, but some que
The marker is checked by the underlying Filter which could be a
MarkerFilter or a ScriptFilter or some custom filter (all our other filters
ignore the marker).
On 28 June 2016 at 10:52, Gary Gregory wrote:
> On Tue, Jun 28, 2016 at 8:48 AM, Mikael Ståldal > wrote:
>
>> The Javadoc for the Logge
On Tue, Jun 28, 2016 at 8:48 AM, Mikael Ståldal
wrote:
> The Javadoc for the Logger.isEnabled methods looks a bit odd. I just fixed
> a few obvious errors, but some questions:
>
> - I guess that the note about Level.OFF applies to both of them?
>
I would guess yes and I hope we have a unit test
The Javadoc for the Logger.isEnabled methods looks a bit odd. I just fixed
a few obvious errors, but some questions:
- I guess that the note about Level.OFF applies to both of them?
- Is the marker optional?
- I guess that the marker param should not be formulated like it is?
/**
* Checks whet
