At 09:44 PM 11/28/2004, Mark Womack wrote:
Ceki,
I guess I am missing the context here since we are successfully
configuring plugins today with the old XML configurator.
And looking at the code, the o.a.l.spi.LoggerRepository interface has new
methods to get/return the PR associated with it. Th
At 09:37 PM 11/28/2004, Mark Womack wrote:
OK. Then we should change the name of the event to firePluginAdded
instead of firePluginStarted, and we should find a different way to report
that a plugin has been started, if it is important.
No because I doubt anyone would be interested in the fact t
-
From: "Ceki Gülcü" <[EMAIL PROTECTED]>
To: "Log4J Developers List" <[EMAIL PROTECTED]>
Sent: Sunday, November 28, 2004 11:09 AM
Subject: Re: PluginRegistry Review
Mark,
One additional point, a PR knows about its owning LoggingRepository but the
inverse is not true. T
Ceki,
It's a separation of concerns' issue. The PluginRegistry is just a
bag containing plugins, plus keeps track of listeners.
Also keep in mind that we already have a model for configuring log4j
components. It is as follows:
1) Create a new instance of the desired class, call this ins
Mark,
One additional point, a PR knows about its owning LoggingRepository but the
inverse is not true. The owning LoggingRepository does not know its PR.
This of course makes configuring plugins through a config file impossible.
--
Ceki Gülcü
The complete log4j manual: http://qos.ch/eclm
Prof
27;t true anymore, the registry has no
> idea when the plugin will be started. Just wondering if this is an
> oversight or if there was a reason. Is there ever a case where you
> would want to add a plugin to the registry but not start it
> immediately?
It's a separation of concerns&
Attempting to get my head wrapped around this stuff
before starting on the watchdog design and implementation.
1) You guys beat me to it. I was going to
make the change from a static, separate PluginRegistry to a per-LoggerRepository
instance. Good move. That really simplified the
> Hello Paul, Scott,
>
> Is there any good reason why the PluginRegistry should be static?
>
> I began implementing changes so that each LoggerRepository
> has its own
> PluginRegistry. The resulting code is slightly simpler and
> easier to read.
> If there are n
Hello Paul, Scott,
Is there any good reason why the PluginRegistry should be static?
I began implementing changes so that each LoggerRepository has its own
PluginRegistry. The resulting code is slightly simpler and easier to read.
If there are no objections, I'll check in my changes later
