Re: Possible NPEs in org.apache.logging.log4j.core.layout.PatternLayout

2014-05-26 Thread Matt Sicker
Fixed in r1597669. On 25 May 2014 00:06, Matt Sicker wrote: > I added a createDefaultLayout() method to PatternLayout, but I don't think > I addressed the header/footer concern. I did, however, replace all those > calls to createLayout() with a bunch of null values as part of the > migration to

Re: Possible NPEs in org.apache.logging.log4j.core.layout.PatternLayout

2014-05-24 Thread Matt Sicker
I added a createDefaultLayout() method to PatternLayout, but I don't think I addressed the header/footer concern. I did, however, replace all those calls to createLayout() with a bunch of null values as part of the migration to typed parameters in factory methods. On 20 May 2014 22:55, Gary Grego

Possible NPEs in org.apache.logging.log4j.core.layout.PatternLayout

2014-05-20 Thread Gary Gregory
Plenty of tests pass null for the config to PatternLayout. If you look at readers of the config ivar, NPE's can be happen, in theory, in getFooter() and getHeader(). createPatternParser() handles a null config with a special case. If look at PatternLayoutTest, all tests make sure to pass a valid