Re: FileAppenderBenchmark

The log4j-perf issue seems to be that the classes generated by JMH under log4j-perf\target\generated-sources\annotations are not included in the shaded benchmarks.jar or in log4j-perf-2.8.1-SNAPSHOT.jar... On Tue, Jan 31, 2017 at 3:42 AM, Matt Sicker wrote: > Oh, the log4j-perf issue would prob

Re: FileAppenderBenchmark

Oh, the log4j-perf issue would probably be from combining all the .dat files. I thought we had a maven shade plugin transformer for that? I remember an old jira ticket about that. On 30 January 2017 at 12:18, Gary Gregory wrote: > On Mon, Jan 30, 2017 at 10:15 AM, Apache > wrote: > >> OK. But a

Re: FileAppenderBenchmark

On Mon, Jan 30, 2017 at 10:15 AM, Apache wrote: > OK. But according to Matt this change wasn’t required. What was breaking > that needed fixing? > hm... maybe I was trying to remove some redundancies. can't quite recall ATM, sorry. Gary > > Ralph > > On Jan 30, 2017, at 9:49 AM, Gary Gregory

Re: FileAppenderBenchmark

Since the change isn’t required and it is breaking log4j-perf can you please revert it? Ralph > On Jan 30, 2017, at 11:15 AM, Apache wrote: > > OK. But according to Matt this change wasn’t required. What was breaking that > needed fixing? > > Ralph > >> On Jan 30, 2017, at 9:49 AM, Gary Gre

Re: FileAppenderBenchmark

OK. But according to Matt this change wasn’t required. What was breaking that needed fixing? Ralph > On Jan 30, 2017, at 9:49 AM, Gary Gregory wrote: > > > > On Jan 30, 2017 12:28 AM, "Apache" > wrote: > Gary moved it, presumably since many modules need to

Re: FileAppenderBenchmark

On Jan 30, 2017 12:28 AM, "Apache" wrote: Gary moved it, presumably since many modules need to generate a .dat file. Right, that was the idea. Gary Ralph On Jan 29, 2017, at 9:55 AM, Matt Sicker wrote: That maven-compiler-plugin config was originally only included in log4j-core in order t

Re: FileAppenderBenchmark

Annotation processing is enabled by default. I set up log4j-core like that because the annotation processor has to be compiled before it can be used, so it requires a second pass. On 30 January 2017 at 02:27, Apache wrote: > Gary moved it, presumably since many modules need to generate a .dat fi

Re: FileAppenderBenchmark

Gary moved it, presumably since many modules need to generate a .dat file. Ralph > On Jan 29, 2017, at 9:55 AM, Matt Sicker wrote: > > That maven-compiler-plugin config was originally only included in log4j-core > in order to allow the PluginProcessor annotation processor to re-run against >

Re: FileAppenderBenchmark

That maven-compiler-plugin config was originally only included in log4j-core in order to allow the PluginProcessor annotation processor to re-run against log4j-core without needing to split it into its own jar. I'm not sure why it's configured for everything now. On 29 January 2017 at 08:59, Ralph

Re: FileAppenderBenchmark

Yes. Ralph > On Jan 28, 2017, at 11:59 PM, Remko Popma wrote: > > Ralph, are your benchmark results with 4 threads (-t 4)? > >> On Sun, Jan 29, 2017 at 5:51 PM, Apache wrote: >> While I couldn’t get it to work with Log4j 2.8 the results I get for 2.7 do >> not match Ceki’s at all. These are

Re: FileAppenderBenchmark

The cause seems to be a change in the master pom: the maven-compiler-plugin plugin now has the below section which was not there in 2.7. If I take it out and build only log4j-perf, the benchmarks run without error. (But building all modules fails: some problem in log4j-core...)

Re: FileAppenderBenchmark

Ralph, are your benchmark results with 4 threads (-t 4)? On Sun, Jan 29, 2017 at 5:51 PM, Apache wrote: > While I couldn’t get it to work with Log4j 2.8 the results I get for 2.7 > do not match Ceki’s at all. These are the results for Java 7: > > Benchmark

Re: FileAppenderBenchmark

That error is exactly what I am seeing. For some reason the class files under log4j-perf\target\generated-sources\annotations (generated by JMH) are not included in the shaded benchmarks.jar or in log4j-perf-2.8.1-SNAPSHOT.jar... Thanks for mentioning that it works with 2.7. That means it is likel

Re: FileAppenderBenchmark

While I couldn’t get it to work with Log4j 2.8 the results I get for 2.7 do not match Ceki’s at all. These are the results for Java 7: Benchmark Mode SamplesScoreError Units o.a.l.l.p.j.FileAppenderBenchmark.julFile

Re: FileAppenderBenchmark

I can no longer get the benchmarks to work. I get java.lang.IllegalArgumentException: Benchmark does not match a class at org.openjdk.jmh.util.ClassUtils.loadClass(ClassUtils.java:90) at org.openjdk.jmh.runner.BaseRunner.runBenchmark(BaseRunner.java:198) at org.openjdk.jmh.

Re: FileAppenderBenchmark

> On Jan 29, 2017, at 9:38, Remko Popma wrote: > > I want to ask a favor: can anyone run the FileAppenderBenchmark benchmark > (with -f 1 -wi 10 -i 10 -t 4) and post the summary? Someone is reporting a > performance regression. This is the regression report: https://mobile.twitter.com/ceki/st