Re: cvs commit: logging-log4j/src/java/org/apache/log4j ConsoleAppender.java

2005-05-07 Thread Curt Arnold
On May 7, 2005, at 6:15 PM, Claudio Corsi wrote: Curt, I noticed that you removed the protected closeWriter method. This need to be included because these streams should not be closed. They aren't. SystemOutStream.close does not call down to System.out.close. I also wanted to point out that

Re: cvs commit: logging-log4j/src/java/org/apache/log4j ConsoleAppender.java

2005-05-07 Thread Claudio Corsi
Curt, I noticed that you removed the protected closeWriter method. This need to be included because these streams should not be closed. I also wanted to point out that you only need a single reference of SystemErrStream and SystemOutStream. I would recommend that instead of creating new SystemE