Re: logging-log4j2 git commit: Add missing license headers

I just checked in a fix. Ralph > On Sep 25, 2016, at 3:28 PM, Gary Gregory wrote: > > I'll fix that when I get home tonight. > > Gary > > > On Sep 25, 2016 1:38 PM, "Ralph Goers" > wrote: > Yeah, I fixed those but your hadoop tests in the 1.2 module are cr

Re: logging-log4j2 git commit: Add missing license headers

I'll fix that when I get home tonight. Gary On Sep 25, 2016 1:38 PM, "Ralph Goers" wrote: > Yeah, I fixed those but your hadoop tests in the 1.2 module are creating > trash in the source directory. That needs to be fixed as my rat check is > failing. > > Ralph > > On Sep 25, 2016, at 11:37 AM,

Re: logging-log4j2 git commit: Add missing license headers

Yeah, I fixed those but your hadoop tests in the 1.2 module are creating trash in the source directory. That needs to be fixed as my rat check is failing. Ralph > On Sep 25, 2016, at 11:37 AM, Gary Gregory wrote: > > My bad, thanks for the catch. > > I think there is a way to make RAT fail a

Re: logging-log4j2 git commit: Add missing license headers

Too bad I did it to the wrong branch. Just added them again to master. Ralph > On Sep 19, 2016, at 7:39 PM, Remko Popma wrote: > > Thank you! Sorry I missed that. > > Sent from my iPhone > >> On 2016/09/20, at 9:31, rgo...@apache.org wrote: >> >> Repository: logging-log4j2 >> Updated Branch

Re: logging-log4j2 git commit: Add missing license headers

Thank you! Sorry I missed that. Sent from my iPhone > On 2016/09/20, at 9:31, rgo...@apache.org wrote: > > Repository: logging-log4j2 > Updated Branches: > refs/heads/LOG4J2-1597 21ac645e0 -> 4a5f2b70d > > > Add missing license headers > > > Project: http://git-wip-us.apache.org/repos/asf/

Re: logging-log4j2 git commit: Add missing license headers

Keeping it all in one place was convenient for me during development. I will clean this up. On Wed, Apr 27, 2016 at 2:02 AM, Ralph Goers wrote: > You are welcome, but I am curious as to why the shell script and .bat file > are located in the middle of the java class hierarchy and not under > src

Re: logging-log4j2 git commit: Add missing license headers

You are welcome, but I am curious as to why the shell script and .bat file are located in the middle of the java class hierarchy and not under src/test/resources? Ralph > On Apr 26, 2016, at 9:06 AM, Remko Popma wrote: > > Thank you! > > On Wed, Apr 27, 2016 at 1:04 AM,

Re: logging-log4j2 git commit: Add missing license headers

Thank you! On Wed, Apr 27, 2016 at 1:04 AM, wrote: > Repository: logging-log4j2 > Updated Branches: > refs/heads/master 6ddc0250c -> 73a678189 > > > Add missing license headers > > > Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo > Commit: > http://git-wip-us.apache.org/re

Re: logging-log4j2 git commit: Add missing license headers

Looking at Log4jLogEvent::hashCode, there are many unnecessary Checkstyle MagicNumber warnings for this. I've tried surrounding the offending lines between //Check:OFF: MagicNumber and // Check:ON: MagicNumber comments, and added a SuppressionCommentFilter to /logging-log4j2/checkstyle.xml but Chec

Re: logging-log4j2 git commit: Add missing license headers

I am not sure how to run rat that way effectively. I build the site and review each project’s rat report. Ralph > On Sep 9, 2015, at 9:52 PM, Gary Gregory wrote: > > Thank you Ralph. Should we make a build fail if a license header is missing? > I've seen some projects do that... > > Gary >