Jacob Kjome <[EMAIL PROTECTED]> wrote:
At 03:24 AM 12/4/2004 +0000, you wrote:
>Hi Ceki,
> I'm having several interesting problems
>trying to build and run the log4j unit tests at the moment
>on my system which I suspect are due to my environment not
>being quite right yet after a recent clean OS re-install
>:-(
>
Can you explain your issue? There is one case where unit tests depend on code in "examples" source tree (InterpreterTest) causing compile failures if you don't have "examples/src" configured as a location for source files.
The first problem I found was not being able to compile the tests due to having an unsatisfied dependency on jetty. Being unable to download jetty I found that the PassByJNDI test case has no target in tests\build.xml and is not run as part of the runAll target. Is the runAll target not the recommended way of running the tests?
To resolve this I modified the build.xml to have a separate conditional compile target only executed when jetty is found, the same way used in the main log4j build for optional dependencies. I can supply a patch if you require.
The second problem was the dependencies on examples code you pointed out along with a more subtle dependency. Copying the NOPAction class to the test tree and modifying the import in InterpreterTest resolved that but when you remove the examples/classes directory from the test classpath in the build.xml file, the PatternLayoutTest fails as it has a runtime dependency on examples\pattern\MyPatternLayout. It appears that test14 is trying to verify output generated using MyPatternLayout.
To resolve this I have:
removed method: test14 from PatternLayoutTest
removed patternLayout.14.properties from tests/input/pattern
removed patternLayout.14 from tests/witness/pattern
Again a patch can be supplied.
The third problem I had seems to be a mis-understanding between the SocketServer tests and my firewall which caused them to seemingly hang at random points. No problem when firewall turned off :-)
Kind Regards
Andy The information contained in this e-mail is intended only for the person or entity to which it is addressed and may contain confidential and/or privileged material. If You are not the intended recipient of this e-mail, the use of this information or any disclosure, copying or distribution is Prohibited and may be unlawful. If you received this in error, please contact the sender and delete the material from any computer. The views expressed in this e-mail may not necessarily be the views of The PCMS Group plc and should not be taken as authority to carry out any instruction contained.
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
