Re: v1 tabs vs. spaces

2012-05-28 Thread Ralph Goers
On May 28, 2012, at 7:24 AM, Gary Gregory wrote: > On Sun, May 27, 2012 at 12:48 PM, Christian Grobmeier > wrote: > On Sun, May 27, 2012 at 4:18 PM, Jacob Kjome wrote: > > > > To ensure a proper style one could use Checkstyle. > > OK, sounds good. How about I start with using the same checks

Re: v1 tabs vs. spaces

2012-05-28 Thread Christian Grobmeier
On Mon, May 28, 2012 at 4:24 PM, Gary Gregory wrote: > On Sun, May 27, 2012 at 12:48 PM, Christian Grobmeier > wrote: >> >> On Sun, May 27, 2012 at 4:18 PM, Jacob Kjome wrote: >> > >> > +1 >> > >> > Also, how about some standard code formatting, either for >> > Intellij/Eclipse >> > or a build c

Re: v1 tabs vs. spaces

2012-05-28 Thread Gary Gregory
On Sun, May 27, 2012 at 12:48 PM, Christian Grobmeier wrote: > On Sun, May 27, 2012 at 4:18 PM, Jacob Kjome wrote: > > > > +1 > > > > Also, how about some standard code formatting, either for > Intellij/Eclipse > > or a build component that we can run to reformat prior to checkin? For > > instan

Re: v1 tabs vs. spaces

2012-05-27 Thread Christian Grobmeier
On Sun, May 27, 2012 at 4:18 PM, Jacob Kjome wrote: > > +1 > > Also, how about some standard code formatting, either for Intellij/Eclipse > or a build component that we can run to reformat prior to checkin?  For > instance, trimming line endings and using standard braces makes diffs easier > to re

Re: v1 tabs vs. spaces

2012-05-27 Thread Jacob Kjome
+1 Also, how about some standard code formatting, either for Intellij/Eclipse or a build component that we can run to reformat prior to checkin?  For instance, trimming line endings and using standard braces makes diffs easier to read, as only relevant changes show up.  We'd probably want to