DO NOT REPLY [Bug 44888] problem in showing Filename and Line number in log file

2008-05-16 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=44888 --- Comment #6 from Ralph Goers <[EMAIL PROTECTED]> 2008-05-16 00:49:47 PST --- I ran the build and it was successful. I modified the Appender code I showed below to print the stacktrace and the info in LocationInfo before it was correc

Log4j regression test failure?

2008-05-16 Thread Jess Holle
I grabbed the 1.2.15 sources, built them, and then tried to run the regression tests -- in preparation for making changes and then verifying no tests fail. Unfortunately, I get the following failure: Minimum: [junit] Running org.apache.log4j.MinimumTestCase [junit] Testsuite:

Proposed synchronization changes

2008-05-16 Thread Jess Holle
We as many others have been bitten by the synchronization nuances of log4j. Attached is a proposed patch to reduce the scope of the problem. No, this is not yet regression tested due to the issues I e-mailed about previously with the regression test suite, but I'd like to spur some discussion

Re: Proposed synchronization changes

2008-05-16 Thread Jess Holle
I made a slight adjustment to the pre-Java-5 solution and replaced it (unconditionally here, though this could easily be made conditional) with a Java 5 implementation. Jess Holle wrote: We as many others have been bitten by the synchronization nuances of log4j. Attached is a proposed patch

Re: Proposed synchronization changes

2008-05-16 Thread Jess Holle
By the way, I am aware that these changes don't (yet) address the opportunity for deadlock. That'll come later (hopefully). This just *reduces* both the bottleneck and deadlock potential. Jess Holle wrote: I made a slight adjustment to the pre-Java-5 solution and replaced it (unconditionally

Re: Proposed synchronization changes

2008-05-16 Thread Jess Holle
In case it's not obvious the other major issue I'm alluding to is the synchronization in AppenderSkeleton. This is harder to remove without breaking things -- and might be better addressed by an AppenderSkeleton2 or by an extra argument to the AppenderSkeleton constructor indicating the desire