[Bug 54035] New: logger.setLevel is not thread safe.

2012-10-22 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54035 Priority: P2 Bug ID: 54035 Assignee: log4j-dev@logging.apache.org Summary: logger.setLevel is not thread safe. Severity: normal Classification: Unclassified OS: All

[jira] [Commented] (LOG4J2-100) Allow Log4jLogEvent serialization with subclasses

2012-10-22 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13481232#comment-13481232 ] Ralph Goers commented on LOG4J2-100: OK - here is one other idea for you to think abou

[jira] [Closed] (LOG4J2-102) Bad priority in Syslog messages

2012-10-22 Thread Emanuele Colombo (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Emanuele Colombo closed LOG4J2-102. --- The problem is now solved. Thanks! > Bad priority in Syslog messages > -

[jira] [Closed] (LOG4J2-101) Attribute "format" for SyslogAppender is mandatory

2012-10-22 Thread Emanuele Colombo (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Emanuele Colombo closed LOG4J2-101. --- The problem is now solved. Thanks! > Attribute "format" for SyslogAppender is ma

[jira] [Commented] (LOG4J2-100) Allow Log4jLogEvent serialization with subclasses

2012-10-22 Thread Das Archive (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13481256#comment-13481256 ] Das Archive commented on LOG4J2-100: Yes, but then AsynchAppender and the normal Rewri

Re: Failure in org.apache.logging.log4j.core.layout.HTMLLayoutTest

2012-10-22 Thread Ralph Goers
Darn. Probably Windows again. Ralph On Oct 22, 2012, at 7:53 AM, Gary Gregory wrote: > Does anyone else see failures in > org.apache.logging.log4j.core.layout.HTMLLayoutTest? > > Running org.apache.logging.log4j.core.layout.HTMLLayoutTest > Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Tim

Re: Failure in org.apache.logging.log4j.core.layout.HTMLLayoutTest

2012-10-22 Thread Ralph Goers
Looks like I will have to revisit this. The code is replacing LINE_SEP with "". The unit test has "\n" in it. On Windows this probably isn't matching. On Oct 22, 2012, at 8:31 AM, Ralph Goers wrote: > Darn. Probably Windows again. > > Ralph > > On Oct 22, 2012, at 7:53 AM, Gary Gregory wr

Re: [v2] New Logger.isEnabled(Level) should be like v1's Category.isEnabledFor(Priority)

2012-10-22 Thread Gary Gregory
So... throw an IllegalArgumentException? Seems harsh. If not an exception, then returning true is the only option. ? Gary On Mon, Oct 22, 2012 at 11:34 AM, Ralph Goers wrote: > I would suggest that isEnabled() specifically disallow Level.OFF as that > makes no sense. The test for a level is >

Re: [v2] New Logger.isEnabled(Level) should be like v1's Category.isEnabledFor(Priority)

2012-10-22 Thread Ralph Goers
I guess the best solution is to note it in the javadoc and then always return true. Ralph On Oct 22, 2012, at 9:12 AM, Gary Gregory wrote: > So... throw an IllegalArgumentException? Seems harsh. If not an exception, > then returning true is the only option. > > ? > > Gary > > On Mon, Oct 22

Re: [v2] New Logger.isEnabled(Level) should be like v1's Category.isEnabledFor(Priority)

2012-10-22 Thread Gary Gregory
Done. Gary On Mon, Oct 22, 2012 at 12:18 PM, Ralph Goers wrote: > I guess the best solution is to note it in the javadoc and then always > return true. > > Ralph > > On Oct 22, 2012, at 9:12 AM, Gary Gregory wrote: > > So... throw an IllegalArgumentException? Seems harsh. If not an exception, >

[Bug 41214] Deadlock with RollingFileAppender

2012-10-22 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=41214 --- Comment #47 from Jason Marshall --- After discussion with some colleagues, I would like to propose the following fix: You cannot protect AppenderAttachableImpl from here. You can only protect the lazy instantiation. All of the publi

[Bug 41214] Deadlock with RollingFileAppender

2012-10-22 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=41214 --- Comment #48 from Ralph Goers --- Since you asked for thoughts Please test Log4j 2. -- You are receiving this mail because: You are the assignee for the bug. - T

Re: Failure in org.apache.logging.log4j.core.layout.HTMLLayoutTest

2012-10-22 Thread Ralph Goers
This should now work on Windows Ralph On Oct 22, 2012, at 7:53 AM, Gary Gregory wrote: > Does anyone else see failures in > org.apache.logging.log4j.core.layout.HTMLLayoutTest? > > Running org.apache.logging.log4j.core.layout.HTMLLayoutTest > Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, T