Camel accepts PRs. I think we should be able to do it. ICLAs still apply,
though.
On 2 September 2014 12:12, Ralph Goers wrote:
> That sounds reasonable.
>
> Ralph
>
>
> On Sep 2, 2014, at 9:41 AM, Yogesh Rao wrote:
>
> > Hi Ralph,
> >
> > IMO new Object[0] as a param value is valid and should
If you prefer using GitHub, you can file a pull request instead of a patch
file. I still want to test out the functionality, but it should work just
fine.
On 2 September 2014 09:29, Yogesh Rao wrote:
> Hi,
>
> Just an update on this... i had little time last week to work on this
> issue. I am l
That sounds reasonable.
Ralph
On Sep 2, 2014, at 9:41 AM, Yogesh Rao wrote:
> Hi Ralph,
>
> IMO new Object[0] as a param value is valid and should behave similar to a
> call to the method without param i.e. logger.error("Hello World {} in {} ");
>
> In the above context adding a conditional
Hi Ralph,
IMO new Object[0] as a param value is valid and should behave similar to a
call to the method without param i.e. logger.error("Hello World {} in {} ");
In the above context adding a conditional check params.length > 0 with then
the "if" @ line 157 wouldn't end up throwing the error and
After looking at SmtpAppender, SmtpManager and your eamil it doesn’t sound to
me like there is a lot of benefit in extending SmtpAppender or SmtpManager.
Their primary purpose of those, and the majority of the code, is to send email
- which you have said your version doesn’t do. The only code yo
What will you do instead of throwing an ArrayIndexOutOfBoundsException? This
is obviously a user error. It would be misleading (but maybe acceptable) to
substitute “null” for the placeholders, but just throwing a different exception
probably isn’t worth the trouble.
Ralph
On Sep 2, 2014, at
Thanks for all your input.
I'm going to try and implement the appender we need to maintain our current
throttling infrastructure. I will send a patch with the changes we need as
far as moving items from private to protected and removing the final
keyword.
On Sat, Aug 30, 2014 at 2:02 PM, Matt S
Create Patch would be way for me then :-) and will get the plugin support
for eclipse
Regards,
-Yogesh
On Tue, Sep 2, 2014 at 8:26 PM, Gary Gregory wrote:
> The easiest path will be for you to let an IDE (like Eclipse, my favorite)
> generate a patch for you from the Team->Create Patch... dial
The easiest path will be for you to let an IDE (like Eclipse, my favorite)
generate a patch for you from the Team->Create Patch... dialog.
Depending on your Eclipse set up you might have to install EGit to get git
support in Eclipse.
Gary
On Tue, Sep 2, 2014 at 10:53 AM, Yogesh Rao wrote:
> H
Hi Gary,
I haven't worked on Git as yet, I think i will provide a diff of the files
(with Git Master branch) and attach it to JIRA .
Alternatively if there any link for creating and submitting Git patches,
please do let me know I can provide that as well.
Regards,
-Yogesh
On Tue, Sep 2, 2014 a
Yogesh,
Thank you for you message.
We can only take code submissions via unified diff files attached to JIRA.
I think we might also be able to (legally) accept Git pull requests but I
am not 100% sure on that one.
When providing a patch it would be most helpful to do so against the Git
master br
Hi,
Just an update on this... i had little time last week to work on this
issue. I am looking into this now and checking if a sandbox can be created
for execution of the test cases using class loaders.
Thank you!
Regards,
-Yogesh
On Mon, Aug 25, 2014 at 10:48 AM, Yogesh Rao wrote:
> Sure Rem
Hi,
There seems to be an issue with SimpleLogger implementation provided by
log4j2. The issue seems to be in the new improved API supporting
placeholders and var args when called with an Object Array of size 0.
for e.g logger.error("Hello World {} in {} " , new Object[0]);
A statement above resu
13 matches
Mail list logo
