Buffering in Console Appender?

2017-04-13 Thread Jaromir Hamala
Hello, I wonder whether log4j could add (optional) buffering into the Console Appender. I believe it could be useful e.g. when the stdout is redirected to a file (think of Maven Surefire), etc. Would you accept a patch adding this? Cheers, Jaromir -- “Perfection is achieved, not when there is

Re: Buffering in Console Appender?

2017-04-13 Thread Matt Sicker
Sounds like an interesting use case. Patches are always welcome! Make sure to file a JIRA ticket as well so we have something to refer to in the changelog. On 13 April 2017 at 09:29, Jaromir Hamala wrote: > Hello, > > I wonder whether log4j could add (optional) buffering into the Console > Appen

Re: Buffering in Console Appender?

2017-04-14 Thread Jaromir Hamala
Hello Matt, thanks for you reply. I realized this is something what should probably be handled inside Surefire and not inside Log4J. I'll talk to Surefire folks. Cheers, Jaromir On Thu, Apr 13, 2017 at 7:23 PM, Matt Sicker wrote: > Sounds like an interesting use case. Patches are always welco

Re: Buffering in Console Appender?

2017-04-18 Thread Mikael Ståldal
If you add this, don't forget to do some performance tests to verify that it actually improves performance. On Fri, Apr 14, 2017 at 1:33 PM, Jaromir Hamala wrote: > Hello Matt, > > thanks for you reply. I realized this is something what should > probably be handled inside Surefire and not inside

Re: Buffering in Console Appender?

2017-04-18 Thread Jaromir Hamala
Hello Mikael, this fix was already merged into Surefire. It made a massive difference difference in our cases: as confirmed by both data from Java Flight Recorder and real-world exper