Re: XMLLayout indents, but not the first child tag ()

2016-04-20 Thread Kamal Mettananda
Hi Garry My change is done only to the way the DefaultXmlPrettyPrinter works. So the change is there only on the XmlLayout class which initializes the JacksonFactory.XML() which internally creates an instance of DefaultXmlPrettyPrinter - and there is no way to inject a new class instance, hence ha

Re: XMLLayout indents, but not the first child tag ()

2016-04-19 Thread Gary Gregory
Hi, Does the build pass when you run 'mvn clean test'? Does your patch affect the other Jackson-based layouts (JSON and YAML)? Hopefully not. I think that if all the tests pass and the other layouts are not affected, you should create a JIRA and attach your patch. Even if not, you can still crea

Re: XMLLayout indents, but not the first child tag ()

2016-04-19 Thread Kamal Mettananda
Hi Gary Not really, the number of blank lines are exactly the same in both cases, but the new one has the indentation also fixed. Please see below summarized version of the two files (both having two *BLANK LINE*s, but it's location is different). *Current Xml file* *BLANK LINE* *BLANK LINE*

Re: XMLLayout indents, but not the first child tag ()

2016-04-18 Thread Gary Gregory
Hi, yes they way to go is to create a JIRA and then _attach_ your patch in united diff format to the JIRA issue. There is more blank lines with this right? That's not great but submit your patch and let's see what happens. Gary On Mon, Apr 18, 2016 at 10:55 AM, Kamal Mettananda wrote: > Hi all

Re: XMLLayout indents, but not the first child tag ()

2016-04-18 Thread Kamal Mettananda
Hi all Already there is one blank line between any two blocks within the XML file; but that is because of the way the existing PrettyPrinter class behaves. However I too feel it is not good to have multiple blank lines between blocks. I did a slight change to the way the PrettyPrinter works; an

Re: XMLLayout indents, but not the first child tag ()

2016-04-17 Thread Ralph Goers
I certainly wouldn’t expect to see any blank lines. Ralph > On Apr 17, 2016, at 2:42 PM, Gary Gregory wrote: > > IMO there should not be any blank lines, even in non-compact mode. > > Thoughts from others? > Gary > On Apr 17, 2016 1:34 PM, "Kamal Mettananda" wrote: > >> Hi Gary & all >> >>

Re: XMLLayout indents, but not the first child tag ()

2016-04-17 Thread Gary Gregory
IMO there should not be any blank lines, even in non-compact mode. Thoughts from others? Gary On Apr 17, 2016 1:34 PM, "Kamal Mettananda" wrote: > Hi Gary & all > > I looked at the code and did some modifications around the > jackson-dataformat-xml based formatting area. As per current > impleme

Re: XMLLayout indents, but not the first child tag ()

2016-04-17 Thread Kamal Mettananda
Hi Gary & all I looked at the code and did some modifications around the jackson-dataformat-xml based formatting area. As per current implementation, there is one additional line between each ending tag and next new tag; but with this fix, there will be another additional new line between those

Re: XMLLayout indents, but not the first child tag ()

2016-04-11 Thread Gary Gregory
Feel free to submit a unit test and patch. Gary On Mon, Mar 28, 2016 at 12:00 PM, Kamal Mettananda wrote: > Hi all > > I am using log4j 2.5 to print the logs via XMLLayout. I have set > compact="true", hence the new line and indents of sub tags work correctly. > However I have noticed that the

Re: XMLLayout dependencies

2015-05-11 Thread Remko Popma
I suspect you need Jackson. Dependencies are documented here: http://logging.apache.org/log4j/2.x/log4j-core/index.html Sent from my iPhone > On 2015/05/11, at 17:24, Mikael Ståldal wrote: > > Which library dependencies do I need to use the XMLLayout? Is this > documented somewhere? > > --

Re: XMLLayout

2005-10-20 Thread Rob Gregory
You can't see the output in I.E. as the output from the Log4j XMLLayout is not valid xml - Log4j omits the XML declaration and the default root node (including namespace declaration) if you check the source this is to allow the layout to be used with other appenders etc, but either way you will

Re: XMLLayout and CData tag

2004-08-23 Thread Jacob Kjome
Well, the error is in Crimson, not Log4j. Try using Xerces. Put it in JAVA_HOME/jre/lib/endorsed along with xml-apis.jar that comes with Xerces and try again. I don't know for sure this will fix your problem, but its worth a shot. If this doesn't work, I suggest pinging the Xerces list as t

RE: XMLLayout

2004-07-30 Thread James Stauffer
You should be able to at least view the file in a text editor. James Stauffer -Original Message- From: Philippe Waltregny [mailto:[EMAIL PROTECTED] Sent: Friday, July 30, 2004 3:40 AM To: [EMAIL PROTECTED] Subject: XMLLayout Hello, Sorry to bother you but is anybody able to help me?